Skip to content

Commit c5996f9

Browse files
committed
chore(filter-operands): restore findValueInSet as protected
1 parent e7255a0 commit c5996f9

File tree

1 file changed

+12
-21
lines changed

1 file changed

+12
-21
lines changed

projects/igniteui-angular/src/lib/data-operations/filtering-condition.ts

Lines changed: 12 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ export class IgxFilteringOperand {
4848
* Returns an array of names of the conditions which are visible in the filtering UI
4949
*/
5050
public conditionList(): string[] {
51-
return this.operations.filter(f => !f.hidden && !f.isNestedQuery).map((element) => element.name);
51+
return this.operations.filter(f => !f.hidden && !f.isNestedQuery).map((element) => element.name);
5252
}
5353

5454
/**
@@ -76,10 +76,7 @@ export class IgxFilteringOperand {
7676
this.operations.push(operation);
7777
}
7878

79-
/**
80-
* @hidden
81-
*/
82-
public findValueInSet(target: any, searchVal: Set<any>) {
79+
protected findValueInSet(target: any, searchVal: Set<any>) {
8380
return searchVal.has(target);
8481
}
8582
}
@@ -119,7 +116,7 @@ export class IgxBooleanFilteringOperand extends IgxFilteringOperand {
119116
iconName: 'filter_not_empty',
120117
logic: (target: boolean) => target !== null && target !== undefined
121118
}];
122-
119+
123120
this.operations = newOperations.concat(this.operations);
124121
}
125122
}
@@ -143,7 +140,7 @@ class IgxBaseDateTimeFilteringOperand extends IgxFilteringOperand {
143140
iconName: 'filter_not_empty',
144141
logic: (target: Date) => target !== null && target !== undefined
145142
}];
146-
143+
147144
this.operations = newOperations.concat(this.operations);
148145
}
149146

@@ -189,10 +186,7 @@ class IgxBaseDateTimeFilteringOperand extends IgxFilteringOperand {
189186
return res;
190187
}
191188

192-
/**
193-
* @hidden
194-
*/
195-
public override findValueInSet(target: any, searchVal: Set<any>) {
189+
protected override findValueInSet(target: any, searchVal: Set<any>) {
196190
if (!target) {
197191
return false;
198192
}
@@ -416,11 +410,11 @@ export class IgxDateFilteringOperand extends IgxBaseDateTimeFilteringOperand {
416410
return d.year === now.year + 1;
417411
}
418412
}];
419-
413+
420414
this.operations = newOperations.concat(this.operations);
421415
}
422416

423-
public override findValueInSet(target: any, searchVal: Set<any>) {
417+
protected override findValueInSet(target: any, searchVal: Set<any>) {
424418
if (!target) {
425419
return false;
426420
}
@@ -637,7 +631,7 @@ export class IgxDateTimeFilteringOperand extends IgxBaseDateTimeFilteringOperand
637631
return d.year === now.year + 1;
638632
}
639633
}];
640-
634+
641635
this.operations = newOperations.concat(this.operations);
642636
}
643637
}
@@ -741,14 +735,11 @@ export class IgxTimeFilteringOperand extends IgxBaseDateTimeFilteringOperand {
741735
true : targetn.hours === search.hours && targetn.minutes === search.minutes && targetn.seconds > search.seconds;
742736
}
743737
}];
744-
738+
745739
this.operations = newOperations.concat(this.operations);
746740
}
747741

748-
/**
749-
* @hidden
750-
*/
751-
public override findValueInSet(target: any, searchVal: Set<any>) {
742+
protected override findValueInSet(target: any, searchVal: Set<any>) {
752743
if (!target) {
753744
return false;
754745
}
@@ -806,7 +797,7 @@ export class IgxNumberFilteringOperand extends IgxFilteringOperand {
806797
iconName: 'filter_not_empty',
807798
logic: (target: number) => target !== null && target !== undefined && !isNaN(target)
808799
}];
809-
800+
810801
this.operations = newOperations.concat(this.operations);
811802
}
812803
}
@@ -885,7 +876,7 @@ export class IgxStringFilteringOperand extends IgxFilteringOperand {
885876
iconName: 'filter_not_empty',
886877
logic: (target: string) => target !== null && target !== undefined && target.length > 0
887878
}];
888-
879+
889880
this.operations = newOperations.concat(this.operations);
890881
}
891882

0 commit comments

Comments
 (0)