Skip to content

Commit c6199e5

Browse files
authored
fix(input-group): remove unused interim-bottom-line-color property (#15854)
1 parent c7a077a commit c6199e5

File tree

5 files changed

+67
-3
lines changed

5 files changed

+67
-3
lines changed

projects/igniteui-angular/migrations/migration-collection.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -231,6 +231,11 @@
231231
"version": "20.0.0",
232232
"description": "Updates Ignite UI for Angular from v19.2.0 to v20.0.0",
233233
"factory": "./update-20_0_0"
234+
},
235+
"migration-47": {
236+
"version": "20.0.2",
237+
"description": "Updates Ignite UI for Angular from v20.0.0 to v20.0.2",
238+
"factory": "./update-20_0_2"
234239
}
235240
}
236241
}
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
{
2+
"$schema": "../../common/schema/theme-changes.schema.json",
3+
"changes": [
4+
{
5+
"name": "$interim-bottom-line-color",
6+
"remove": true,
7+
"owner": "input-group-theme",
8+
"type": "property"
9+
}
10+
]
11+
}
Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
import * as path from 'path';
2+
3+
import { SchematicTestRunner, UnitTestTree } from '@angular-devkit/schematics/testing';
4+
import { setupTestTree } from '../common/setup.spec';
5+
6+
const version = '20.0.2';
7+
8+
describe(`Update to ${version}`, () => {
9+
let appTree: UnitTestTree;
10+
const schematicRunner = new SchematicTestRunner('ig-migrate', path.join(__dirname, '../migration-collection.json'));
11+
12+
beforeEach(() => {
13+
appTree = setupTestTree();
14+
});
15+
16+
const migrationName = 'migration-47';
17+
18+
it('should remove the $interim-bottom-line-color property from the input-group theme', async () => {
19+
const testFilePath = `/testSrc/appPrefix/component/test.component.scss`;
20+
21+
appTree.create(
22+
testFilePath,
23+
`$my-input-group-theme: input-group-theme(
24+
$box-background: #ccc,
25+
$interim-bottom-line-color: orange,
26+
);`
27+
);
28+
29+
const tree = await schematicRunner.runSchematic(migrationName, {}, appTree);
30+
31+
expect(tree.readContent(testFilePath)).toEqual(
32+
`$my-input-group-theme: input-group-theme(
33+
$box-background: #ccc,
34+
);`
35+
);
36+
});
37+
});
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
import type {
2+
Rule,
3+
SchematicContext,
4+
Tree
5+
} from '@angular-devkit/schematics';
6+
import { UpdateChanges } from '../common/UpdateChanges';
7+
8+
const version = '20.0.2';
9+
10+
export default (): Rule => async (host: Tree, context: SchematicContext) => {
11+
context.logger.info(`Applying migration for Ignite UI for Angular to version ${version}`);
12+
const update = new UpdateChanges(__dirname, host, context);
13+
update.applyChanges();
14+
};

projects/igniteui-angular/src/lib/core/styles/components/input/_input-group-theme.scss

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
/// @param {Color} $idle-bottom-line-color [null] - The bottom line and border colors in the idle state.
3535
/// @param {Color} $hover-bottom-line-color [null] - The bottom line and border colors in the hover state.
3636
/// @param {Color} $focused-bottom-line-color [null] - The bottom line and border colors in the focused state.
37-
/// @param {Color} $interim-bottom-line-color [null] - The bottom line and border colors during the to-focused transition.
3837
/// @param {Color} $disabled-bottom-line-color [null] - The bottom line and border colors in the disabled state.
3938
/// @param {Color} $border-color [null] - The border color for input groups of type border and fluent.
4039
/// @param {Color} $hover-border-color [null] - The hover input border for input groups of type border and fluent.
@@ -86,7 +85,6 @@
8685
$idle-bottom-line-color: null,
8786
$hover-bottom-line-color: null,
8887
$focused-bottom-line-color: null,
89-
$interim-bottom-line-color: null,
9088
$disabled-bottom-line-color: null,
9189
9290
$border-color: null,
@@ -234,7 +232,6 @@
234232
idle-bottom-line-color: $idle-bottom-line-color,
235233
hover-bottom-line-color: $hover-bottom-line-color,
236234
focused-bottom-line-color: $focused-bottom-line-color,
237-
interim-bottom-line-color: $interim-bottom-line-color,
238235
disabled-bottom-line-color: $disabled-bottom-line-color,
239236
border-color: $border-color,
240237
hover-border-color: $hover-border-color,

0 commit comments

Comments
 (0)