Skip to content

Commit c654203

Browse files
committed
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular into rkaraivanov/keyboard-fixes
2 parents f6f0d8b + 9017e18 commit c654203

File tree

6 files changed

+42
-79
lines changed

6 files changed

+42
-79
lines changed

projects/igniteui-angular/src/lib/core/styles/components/card/_card-component.scss

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,10 +67,6 @@
6767

6868
@include b(igx-card-content) {
6969
@extend %igx-card-content !optional;
70-
71-
@include e(text) {
72-
@extend %igx-card-content-text !optional;
73-
}
7470
}
7571

7672
@include b(igx-card-actions) {

projects/igniteui-angular/src/lib/core/styles/components/card/_card-theme.scss

Lines changed: 6 additions & 73 deletions
Original file line numberDiff line numberDiff line change
@@ -123,43 +123,14 @@
123123

124124
$variant: map-get($theme, 'variant');
125125
$not-material-theme: $variant != 'material';
126-
$bootstrap-theme: $variant == 'bootstrap';
127-
128-
// Bootstrap card spacing
129-
// if you need to change the spacing for the bootstrap card, please, change only $bs-spacing-val.
130-
// All the margin will automatically calculate accordingly in order to keep the right proportion.
131-
$bs-spacing-val: rem(20px);
132-
$bs-margin-media: $bs-spacing-val;
133-
$bs-margin-heading: rem(12px);
134-
$bs-margin-heading-difference: calc(#{$bs-spacing-val} - #{$bs-margin-heading});
135-
$bs-margin-content: rem(16px);
136-
$bs-margin-actions: $bs-spacing-val;
137-
138-
$card-heading-padding: map-get((
139-
material: rem(16px),
140-
fluent: rem(16px),
141-
bootstrap: 0 $bs-spacing-val,
142-
), $variant);
143-
144-
$card-heading-compact-padding: map-get((
145-
material: rem(16px, 16px),
146-
fluent: rem(16px, 16px),
147-
bootstrap: 0 $bs-spacing-val,
148-
), $variant);
149-
150-
$card-content-padding: map-get((
151-
material: rem(14px),
152-
fluent: rem(14px),
153-
bootstrap: 0 $bs-spacing-val,
154-
), $variant);
155-
156-
$card-actions-padding: map-get((
157-
material: rem(8px),
158-
fluent: rem(8px),
159-
bootstrap: 0 $bs-spacing-val,
160-
), $variant);
126+
127+
$card-heading-padding: rem(16px);
128+
$card-heading-compact-padding: rem(16px, 16px);
129+
$card-content-padding: rem(14px);
130+
$card-actions-padding: rem(8px);
161131

162132
$card-tgroup-margin: 0 em(16px);
133+
163134
$card-transitions: box-shadow .3s cubic-bezier(.25, .8, .25, 1);
164135
$left: if-ltr(left, right);
165136
$right: if-ltr(right, left);
@@ -204,21 +175,9 @@
204175
width: 100%;
205176
padding: $card-heading-padding;
206177
color: --var($theme, 'header-text-color');
207-
@if $bootstrap-theme {
208-
margin-bottom: $bs-margin-heading;
209-
210-
&:first-child {
211-
padding-top: $bs-spacing-val;
212-
}
213-
214-
&:last-child {
215-
margin-bottom: calc(#{$bs-margin-heading-difference} + #{$bs-margin-heading});
216-
}
217-
}
218178

219179
&:empty {
220180
display: block;
221-
min-height: $bs-spacing-val;
222181
padding: 0;
223182
}
224183
}
@@ -277,31 +236,12 @@
277236
flex: 1 1 auto;
278237
padding: $card-content-padding;
279238
color: --var($theme, 'content-text-color');
280-
281-
@if $bootstrap-theme {
282-
margin-bottom: $bs-margin-content;
283-
284-
&:first-child {
285-
padding-top: $bs-spacing-val;
286-
}
287-
288-
&:last-child {
289-
margin-bottom: calc(#{$bs-margin-heading-difference} + #{$bs-margin-heading});
290-
}
291-
}
292239
}
293240

294241
%igx-card-media {
295242
display: block;
296243
overflow: hidden;
297244
line-height: 0;
298-
@if $bootstrap-theme {
299-
margin-bottom: $bs-margin-media;
300-
301-
&:last-child {
302-
margin-bottom: 0;
303-
}
304-
}
305245

306246
> * {
307247
width: 100%;
@@ -323,13 +263,6 @@
323263
flex: 0 1 auto;
324264
align-items: center;
325265
padding: $card-actions-padding;
326-
@if $bootstrap-theme {
327-
margin-bottom: $bs-margin-actions;
328-
329-
&:first-child {
330-
padding-top: $bs-spacing-val;
331-
}
332-
}
333266

334267
[igxButton] ~ [igxButton] {
335268
margin-#{$left}: rem(8px);

projects/igniteui-angular/src/lib/core/styles/components/dialog/_dialog-theme.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,7 @@
148148
}
149149

150150
%igx-dialog-title {
151+
display: flex;
151152
color: --var($theme, 'title-color');
152153
padding: $dialog-title-padding;
153154

src/app/card/card.sample.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ <h3 class="igx-card-header__title--small">{{ cards[6].title }}</h3>
193193
<h5 class="igx-card-header__subtitle">{{ cards[6].subtitle }}</h5>
194194
</div>
195195
</igx-card-header>
196-
<div style="overflow: hidden">
196+
<div style="overflow: hidden; line-height: 0">
197197
<img width="100%" height="100%" [src]="cards[6].imageUrl">
198198
</div>
199199
<igx-card-actions>

src/app/dialog/dialog.sample.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
}
44

55
.login-form {
6-
padding: 24px;
6+
padding: 0 24px 24px 24px;
77
}
88

99
.icon {

src/app/dialog/dialog.sample.html

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,5 +90,38 @@ <h4 class="sample-title">Custom Dialog</h4>
9090
</div>
9191
</igx-dialog>
9292
</article>
93+
94+
<article class="sample-column">
95+
<h4 class="sample-title">Templated Dialog</h4>
96+
<p class="sample-description">Detailed description to be added</p>
97+
<br>
98+
<button igxButton="raised" igxRipple (click)="templated.open()">Trigger</button>
99+
100+
<igx-dialog #templated [closeOnOutsideSelect]="true">
101+
<igx-dialog-title>Title</igx-dialog-title>
102+
103+
<div class="login-form">
104+
<igx-input-group>
105+
<igx-prefix>
106+
<igx-icon>person</igx-icon>
107+
</igx-prefix>
108+
<input type="text" igxInput />
109+
<label igxLabel>Username</label>
110+
</igx-input-group>
111+
<igx-input-group>
112+
<igx-prefix>
113+
<igx-icon>lock</igx-icon>
114+
</igx-prefix>
115+
<label igxLabel>Password</label>
116+
<input type="password" igxInput />
117+
</igx-input-group>
118+
</div>
119+
120+
<igx-dialog-actions>
121+
<button igxButton (click)="templated.close()">CANCEL</button>
122+
<button igxButton (click)="templated.close()">SIGN IN</button>
123+
</igx-dialog-actions>
124+
</igx-dialog>
125+
</article>
93126
</section>
94127
</div>

0 commit comments

Comments
 (0)