Skip to content

Commit c9832e2

Browse files
committed
refactor(*): remove prop in 19.2
1 parent 7056e06 commit c9832e2

File tree

7 files changed

+79
-5
lines changed

7 files changed

+79
-5
lines changed

CHANGELOG.md

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,14 @@
11
# Ignite UI for Angular Change Log
22

33
All notable changes for each version of this project will be documented in this file.
4+
5+
## 19.2.0
6+
### General
7+
- `IgxCarousel`
8+
- Removed deprecated property `keyboardSupport`.
9+
- `IgxSlide`
10+
- **Deprecation** - `tabIndex` has been deprecated and will be removed in a future version.
11+
412
## 19.1.1
513
### New Features
614
- IgxListItem
@@ -9,11 +17,8 @@ All notable changes for each version of this project will be documented in this
917
## 19.1.0
1018
### General
1119
- `IgxCarousel`
12-
- Removed deprecated property `keyboardSupport`.
1320
- **Behavioral Changes** - the `maximumIndicatorsCount` input property now defaults to `10`.
1421
- **Deprecation** - `CarouselIndicatorsOrientation` enum members `top` and `bottom` have been deprecated and will be removed in a future version. Use `start` and `end` instead.
15-
- `IgxSlide`
16-
- **Deprecation** - `tabIndex` has been deprecated and will be removed in a future version.
1722

1823
### New Features
1924
- `IgxBanner`

projects/igniteui-angular/migrations/migration-collection.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,11 @@
216216
"version": "19.1.1",
217217
"description": "Updates Ignite UI for Angular from v19.1.0 to v19.1.1",
218218
"factory": "./update-19_1_1"
219+
},
220+
"migration-44": {
221+
"version": "19.2.0",
222+
"description": "Updates Ignite UI for Angular from v19.1.1 to v19.2.0",
223+
"factory": "./update-19_2_0"
219224
}
220225
}
221226
}
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
{
2+
"$schema": "../../common/schema/binding.schema.json",
3+
"changes": [
4+
{
5+
"name": "keyboardSupport",
6+
"remove": true,
7+
"owner": {
8+
"selector": "igx-carousel",
9+
"type": "component"
10+
}
11+
}
12+
]
13+
}
Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
import * as path from 'path';
2+
3+
import { SchematicTestRunner, UnitTestTree } from '@angular-devkit/schematics/testing';
4+
import { setupTestTree } from '../common/setup.spec';
5+
6+
const version = '19.2.0';
7+
8+
describe(`Update to ${version}`, () => {
9+
let appTree: UnitTestTree;
10+
const schematicRunner = new SchematicTestRunner('ig-migrate', path.join(__dirname, '../migration-collection.json'));
11+
12+
beforeEach(() => {
13+
appTree = setupTestTree();
14+
});
15+
16+
const migrationName = 'migration-44';
17+
18+
it('should remove igx-caroursel property `keyboardSupport` in template', async () => {
19+
appTree.create(`/testSrc/appPrefix/component/test.component.html`,
20+
`
21+
<igx-carousel [keyboardSupport]="true"></igx-carousel>
22+
<igx-carousel [keyboardSupport]="false"></igx-carousel>
23+
<igx-carousel [keyboardSupport]="myProp"></igx-carousel>
24+
`
25+
);
26+
27+
const tree = await schematicRunner.runSchematic(migrationName, { shouldInvokeLS: false }, appTree);
28+
29+
expect(tree.readContent('/testSrc/appPrefix/component/test.component.html')).toEqual(
30+
`
31+
<igx-carousel></igx-carousel>
32+
<igx-carousel></igx-carousel>
33+
<igx-carousel></igx-carousel>
34+
`
35+
);
36+
});
37+
});
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
import type {
2+
Rule,
3+
SchematicContext,
4+
Tree
5+
} from '@angular-devkit/schematics';
6+
import { UpdateChanges } from '../common/UpdateChanges';
7+
8+
const version = '19.2.0';
9+
10+
export default (): Rule => async (host: Tree, context: SchematicContext) => {
11+
context.logger.info(`Applying migration for Ignite UI for Angular to version ${version}`);
12+
const update = new UpdateChanges(__dirname, host, context);
13+
update.applyChanges();
14+
};

projects/igniteui-angular/src/lib/carousel/carousel.component.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ describe('Carousel', () => {
186186
expect(carousel.slideChanged.emit).toHaveBeenCalledTimes(3);
187187

188188
spyOn(carousel.slideAdded, 'emit');
189-
const newSlide = new IgxSlideComponent(null, null);
189+
const newSlide = new IgxSlideComponent(null);
190190
carousel.add(newSlide);
191191
fixture.detectChanges();
192192
args = {

projects/igniteui-angular/src/lib/carousel/slide.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ export class IgxSlideComponent implements AfterContentChecked, OnDestroy, IgxSli
5454
* ```
5555
*
5656
* @memberof IgxSlideComponent
57-
* @deprecated in version 19.1.0.
57+
* @deprecated in version 19.2.0.
5858
*/
5959
@HostBinding('attr.tabindex')
6060
public get tabIndex() {

0 commit comments

Comments
 (0)