Skip to content

Commit cafb427

Browse files
authored
Merge pull request #13591 from IgniteUI/dmdimitrov/fix-esf-conditional-filter-dropdown
fix(esf): conditional filter drop down items focus - 16.1.x
2 parents 0f0b5a4 + 50f8de2 commit cafb427

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

projects/igniteui-angular/src/lib/grids/filtering/excel-style/excel-style-conditional-filter.component.html

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@
55
(click)="onTextFilterClick($event)"
66
[igxDropDownItemNavigation]="subMenu"
77
role="menuitem"
8-
aria-haspopup="true">
8+
aria-haspopup="true"
9+
[attr.aria-controls]="this.subMenu.listId"
10+
[attr.aria-activedescendant]="!this.subMenu.collapsed ? this.subMenu.focusedItem?.id : null">
911
<span>{{ subMenuText }}</span>
1012
<igx-icon>keyboard_arrow_right</igx-icon>
1113
</div>
@@ -15,8 +17,7 @@
1517
[maxHeight]="'397px'"
1618
[displayDensity]="esf.displayDensity"
1719
(selectionChanging)="onSubMenuSelection($event)"
18-
(closed)="onSubMenuClosed()"
19-
[allowItemsFocus]="true">
20+
(closed)="onSubMenuClosed()">
2021
<div>
2122
<igx-drop-down-item
2223
*ngFor="let condition of conditions"

projects/igniteui-angular/src/lib/grids/filtering/excel-style/excel-style-conditional-filter.component.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,8 @@ export class IgxExcelStyleConditionalFilterComponent implements OnDestroy {
7878
public onTextFilterKeyDown(eventArgs: KeyboardEvent) {
7979
if (eventArgs.key === this.platform.KEYMAP.ENTER) {
8080
this.onTextFilterClick(eventArgs);
81+
} else if (eventArgs.key === this.platform.KEYMAP.TAB) {
82+
this.subMenu.close();
8183
}
8284
}
8385

0 commit comments

Comments
 (0)