Skip to content

Commit ce557f2

Browse files
Merge pull request #8477 from IgniteUI/ibarakov/fix-8184-10.2.x
fix(esf-templates): reset blank items on column change in esf templates
2 parents 3f07c85 + 533b4b3 commit ce557f2

File tree

2 files changed

+15
-0
lines changed

2 files changed

+15
-0
lines changed

projects/igniteui-angular/src/lib/grids/filtering/excel-style/grid.excel-style-filtering.component.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -619,6 +619,7 @@ export class IgxGridExcelStyleFilteringComponent implements OnDestroy {
619619

620620
private addItems(shouldUpdateSelection: boolean) {
621621
this.selectAllSelected = true;
622+
this.containsNullOrEmpty = false;
622623
this.selectAllIndeterminate = false;
623624

624625
this.uniqueValues.forEach(element => {

projects/igniteui-angular/src/lib/grids/grid/grid-filtering-ui.spec.ts

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4860,6 +4860,20 @@ describe('IgxGrid - Filtering actions - Excel style filtering #grid', () => {
48604860
inputNativeElement = GridFunctions.getExcelStyleSearchComponentInput(fix);
48614861
expect(inputNativeElement.value).toBe('', 'input value didn\'t reset');
48624862
}));
4863+
4864+
it('Should reset blank items on column change.', fakeAsync(() => {
4865+
GridFunctions.clickExcelFilterIconFromCode(fix, grid, 'ProductName');
4866+
flush();
4867+
4868+
let listItems = GridFunctions.getExcelStyleSearchComponentListItems(fix);
4869+
expect(listItems[1].innerText).toBe('(Blanks)');
4870+
4871+
GridFunctions.clickExcelFilterIconFromCode(fix, grid, 'AnotherField');
4872+
flush();
4873+
4874+
listItems = GridFunctions.getExcelStyleSearchComponentListItems(fix);
4875+
expect(listItems[1].innerText).not.toBe('(Blanks)');
4876+
}));
48634877
});
48644878

48654879
describe('Load values on demand', () => {

0 commit comments

Comments
 (0)