chore(*): using an already existing enum

Author: viktorkombov

CHANGELOG.md

@@ -7,8 +7,10 @@ All notable changes for each version of this project will be documented in this
 ### New Features
 - `IgxCsvExporterService`, `IgxExcelExporterService`
     - Exporter services are no longer required to be provided in the application since they are now injected on a root level.
+- `IgxGridToolbarPinningComponent`, `IgxGridToolbarHidingComponent`
+    - Exposed new input `buttonText` which sets the text that is displayed inside the dropdown button in the toolbar.
 - `IgxCombo`
-    - Added `groupsSortingDirection` input, which allows you to set groups sorting order.
+    - Added `groupSortingDirection` input, which allows you to set groups sorting order.
 
 ### General
 
@@ -3650,3 +3652,4 @@ export class IgxCustomFilteringOperand extends IgxFilteringOperand {
     - `IgxDraggableDirective` moved inside `../directives/dragdrop/` folder
     - `IgxRippleDirective` moved inside `../directives/ripple/` folder
     - Folder `"./navigation/nav-service"` renamed to `"./navigation/nav.service"`
+    

projects/igniteui-angular/src/lib/combo/combo.component.html

@@ -52,7 +52,7 @@
         [tabindex]="dropdown.collapsed ? -1 : 0" role="listbox" [attr.id]="dropdown.id">
         <igx-combo-item role="option" [itemHeight]='itemHeight' *igxFor="let item of data
             | comboFiltering:filterValue:displayKey:filterable:filteringOptions
-            | comboGrouping:groupKey:valueKey:groupsSortingDirection;
+            | comboGrouping:groupKey:valueKey:groupSortingDirection;
             index as rowIndex; containerSize: itemsMaxHeight; scrollOrientation: 'vertical'; itemSize: itemHeight"
             [value]="item" [isHeader]="item.isHeader" [index]="rowIndex">
             <ng-container *ngIf="item.isHeader">

projects/igniteui-angular/src/lib/combo/combo.component.spec.ts

@@ -28,6 +28,7 @@ import { AbsoluteScrollStrategy, ConnectedPositioningStrategy } from '../service
 import { IgxSelectionAPIService } from '../core/selection';
 import { IgxIconService } from '../icon/public_api';
 import { IBaseCancelableBrowserEventArgs } from '../core/utils';
+import { SortingDirection } from '../data-operations/sorting-expression.interface';
 
 const CSS_CLASS_COMBO = 'igx-combo';
 const CSS_CLASS_COMBO_DROPDOWN = 'igx-combo__drop-down';
@@ -2173,12 +2174,12 @@ describe('igxCombo', () => {
             expect(combo.dropdown.headers[0].element.nativeElement.innerText).toEqual(fallBackGroup);
         });
         it('should sort groups correctly', () => {
-            combo.groupsSortingDirection = 'ascending';
+            combo.groupSortingDirection = SortingDirection.Asc;
             combo.toggle();
             fixture.detectChanges();
             expect(combo.dropdown.headers[0].element.nativeElement.innerText).toEqual('East North Central');
 
-            combo.groupsSortingDirection = 'descending';
+            combo.groupSortingDirection = SortingDirection.Desc;
             combo.toggle();
             fixture.detectChanges();
             expect(combo.dropdown.headers[0].element.nativeElement.innerText).toEqual('West South Cent');

projects/igniteui-angular/src/lib/combo/combo.component.ts

@@ -42,6 +42,7 @@ import { EditorProvider } from '../core/edit-provider';
 import { IgxInputState, IgxInputDirective } from '../directives/input/input.directive';
 import { IgxInputGroupType, IGX_INPUT_GROUP_TYPE } from '../input-group/public_api';
 import { caseSensitive } from '@igniteui/material-icons-extended';
+import { SortingDirection } from '../data-operations/sorting-expression.interface';
 
 /**
  * @hidden
@@ -69,16 +70,6 @@ const ItemHeights = {
  */
 const itemsInContainer = 10;
 
-/**
- * @hidden
- */
- export const GroupsSortingDirection = mkenum({
-    ascending: 'ascending',
-    descending: 'descending'
-});
-
-export type GroupsSortingDirection = (typeof GroupsSortingDirection)[keyof typeof GroupsSortingDirection];
-
 export enum IgxComboState {
     /**
      * Combo with initial state.
@@ -787,17 +778,22 @@ export class IgxComboComponent extends DisplayDensityBase implements IgxComboBas
     public filterable = true;
 
     /**
-     * An @Input property that sets groups sorting order. The default is `ascending`.
+     * An @Input property that sets groups sorting order.
+     *
+     * @example
      * ```html
-     * <igx-combo [groupsSortingDirection]="'ascending'">
+     * <igx-combo [groupSortingDirection]="groupSortingDirection"></igx-combo>
+     * ```
+     * ```typescript
+     * public groupSortingDirection = SortingDirection.Asc;
      * ```
      */
     @Input()
-    public get groupsSortingDirection() {
-        return this._groupsSortingDirection;
+    public get groupSortingDirection(): SortingDirection {
+        return this._groupSortingDirection;
     }
-    public set groupsSortingDirection(val: GroupsSortingDirection) {
-        this._groupsSortingDirection = val;
+    public set groupSortingDirection(val: SortingDirection) {
+        this._groupSortingDirection = val;
     }
 
     /**
@@ -932,7 +928,7 @@ export class IgxComboComponent extends DisplayDensityBase implements IgxComboBas
     private _overlaySettings: OverlaySettings;
     private _value = '';
     private _valid = IgxComboState.INITIAL;
-    private _groupsSortingDirection: GroupsSortingDirection = GroupsSortingDirection.ascending;
+    private _groupSortingDirection: SortingDirection = SortingDirection.Asc;
 
     constructor(
         protected elementRef: ElementRef,

projects/igniteui-angular/src/lib/combo/combo.pipes.ts

@@ -4,7 +4,7 @@ import { DataUtil } from '../data-operations/data-util';
 import { SortingDirection } from '../data-operations/sorting-expression.interface';
 import { IGX_COMBO_COMPONENT, IgxComboBase } from './combo.common';
 import { DefaultSortingStrategy } from '../data-operations/sorting-strategy';
-import { IComboFilteringOptions, GroupsSortingDirection } from './combo.component';
+import { IComboFilteringOptions } from './combo.component';
 
 
 /**
@@ -44,15 +44,14 @@ export class IgxComboGroupingPipe implements PipeTransform {
 
     constructor(@Inject(IGX_COMBO_COMPONENT) public combo: IgxComboBase) { }
 
-    public transform(collection: any[], groupKey: any, valueKey: any, sortingDirection: GroupsSortingDirection) {
+    public transform(collection: any[], groupKey: any, valueKey: any, sortingDirection: SortingDirection) {
         this.combo.filteredData = collection;
         if ((!groupKey && groupKey !== 0) || !collection.length) {
             return collection;
         }
-        const dir: SortingDirection = sortingDirection === 'ascending' ? SortingDirection.Asc : SortingDirection.Desc;
         const sorted = DataUtil.sort(cloneArray(collection), [{
             fieldName: groupKey,
-            dir,
+            dir: sortingDirection,
             ignoreCase: true,
             strategy: DefaultSortingStrategy.instance()
         }]);