Merge branch 'master' into grid-endEdit-facade

Author: rkaraivanov

.github/workflows/codeql-analysis.yml

@@ -0,0 +1,67 @@
+# For most projects, this workflow file will not need changing; you simply need
+# to commit it to your repository.
+#
+# You may wish to alter this file to override the set of languages analyzed,
+# or to provide custom queries or build logic.
+#
+# ******** NOTE ********
+# We have attempted to detect the languages in your repository. Please check
+# the `language` matrix defined below to confirm you have the correct set of
+# supported CodeQL languages.
+#
+name: "CodeQL"
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    # The branches below must be a subset of the branches above
+    branches: [ master ]
+  schedule:
+    - cron: '33 4 * * 4'
+
+jobs:
+  analyze:
+    name: Analyze
+    runs-on: ubuntu-latest
+
+    strategy:
+      fail-fast: false
+      matrix:
+        language: [ 'javascript' ]
+        # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python' ]
+        # Learn more:
+        # https://docs.github.com/en/free-pro-team@latest/github/finding-security-vulnerabilities-and-errors-in-your-code/configuring-code-scanning#changing-the-languages-that-are-analyzed
+
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v2
+
+    # Initializes the CodeQL tools for scanning.
+    - name: Initialize CodeQL
+      uses: github/codeql-action/init@v1
+      with:
+        languages: ${{ matrix.language }}
+        # If you wish to specify custom queries, you can do so here or in a config file.
+        # By default, queries listed here will override any specified in a config file.
+        # Prefix the list here with "+" to use these queries and those in the config file.
+        # queries: ./path/to/local/query, your-org/your-repo/queries@main
+
+    # Autobuild attempts to build any compiled languages  (C/C++, C#, or Java).
+    # If this step fails, then you should remove it and run the build manually (see below)
+    - name: Autobuild
+      uses: github/codeql-action/autobuild@v1
+
+    # ℹ️ Command-line programs to run using the OS shell.
+    # 📚 https://git.io/JvXDl
+
+    # ✏️ If the Autobuild fails above, remove it and uncomment the following three lines
+    #    and modify them (or add more) to build your code if your project
+    #    uses a compiled language
+
+    #- run: |
+    #   make bootstrap
+    #   make release
+
+    - name: Perform CodeQL Analysis
+      uses: github/codeql-action/analyze@v1

projects/igniteui-angular/src/lib/grids/cell.component.html

@@ -90,8 +90,12 @@
         </igx-input-group>
     </ng-container>
     <ng-container *ngIf="column.dataType === 'boolean'">
+        <!-- The additional [checked] binding is needed as after the initial call of the checked getter
+        it is never called again as no change detection is triggered in the grid after that, resulting in wrong
+        rendered state of the checkbox. -->
         <igx-checkbox
             [(ngModel)]="editValue"
+            [checked]="editValue"
             [igxFocus]="true"
             [disableRipple]="true"
         ></igx-checkbox>

projects/igniteui-angular/src/lib/grids/grid/grid-cell-editing.spec.ts

@@ -164,6 +164,7 @@ describe('IgxGrid - Cell Editing #grid', () => {
             const editTemplate = cellDomBoolean.query(By.css('.igx-checkbox'));
             expect(editTemplate).toBeDefined();
             expect(cell.value).toBe(true);
+            expect(cell.nativeElement.querySelector('.igx-checkbox--checked')).toBeInstanceOf(HTMLElement);
 
             editTemplate.nativeElement.click();
             fixture.detectChanges();
@@ -173,6 +174,7 @@ describe('IgxGrid - Cell Editing #grid', () => {
 
             expect(cell.editMode).toBe(false);
             expect(cell.value).toBe(false);
+            expect(cell.nativeElement.querySelector('.igx-checkbox--checked')).toBeNull();
         }));
 
         it('edit template should be according column data type -- date', () => {

projects/igniteui-angular/src/lib/test-utils/configure-suite.ts

@@ -26,7 +26,14 @@ export const configureTestSuite = () => {
     }
   };
 
+  /** Clear the svg tags from the svgContainer created by the IconService
+    to avoid increasing their count to over 10000. */
+  const clearSVGContainer = () => {
+    document.querySelectorAll('svg').forEach((tag) => tag.remove());
+  };
+
   afterEach(() => {
+    clearSVGContainer();
     const testBedApi: any = getTestBed();
     testBedApi._activeFixtures.forEach((fixture: ComponentFixture<any>) => {
       try {