Skip to content

Commit d0013bf

Browse files
authored
Merge pull request #7804 from IgniteUI/mvenkov/close-overlays-on-escape-correctly
Correctly close all overlays on escape key
2 parents b9aa66a + 26eabfa commit d0013bf

File tree

1 file changed

+2
-6
lines changed
  • projects/igniteui-angular/src/lib/services/overlay

1 file changed

+2
-6
lines changed

projects/igniteui-angular/src/lib/services/overlay/overlay.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,6 @@ export class IgxOverlayService implements OnDestroy {
356356
info.settings.scrollStrategy.detach();
357357
this.removeOutsideClickListener(info);
358358
this.removeResizeHandler();
359-
this.removeCloseOnEscapeListener();
360359

361360
const child: HTMLElement = info.elementRef.nativeElement;
362361
if (info.settings.modal) {
@@ -502,6 +501,7 @@ export class IgxOverlayService implements OnDestroy {
502501
if (this._overlayInfos.length === 0 && this._overlayElement && this._overlayElement.parentElement) {
503502
this._overlayElement.parentElement.removeChild(this._overlayElement);
504503
this._overlayElement = null;
504+
this.removeCloseOnEscapeListener();
505505
}
506506
}
507507

@@ -737,11 +737,7 @@ export class IgxOverlayService implements OnDestroy {
737737
}
738738

739739
private removeCloseOnEscapeListener() {
740-
const closingOverlaysCount =
741-
this._overlayInfos
742-
.filter(o => o.closeAnimationPlayer && o.closeAnimationPlayer.hasStarted())
743-
.length;
744-
if (this._overlayInfos.length - closingOverlaysCount === 1 && this._keyPressEventListener) {
740+
if (this._keyPressEventListener) {
745741
this._keyPressEventListener.unsubscribe();
746742
this._keyPressEventListener = null;
747743
}

0 commit comments

Comments
 (0)