Skip to content

Commit d10f5f9

Browse files
committed
fix(grid): Remove unnecessary summary cell method. Fix detect change on local again.
1 parent ffa87c5 commit d10f5f9

File tree

2 files changed

+4
-11
lines changed

2 files changed

+4
-11
lines changed

projects/igniteui-angular/src/lib/grids/grid-base.directive.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3513,7 +3513,8 @@ export abstract class IgxGridBaseDirective implements GridType,
35133513
// Reset currency position because of new locale.
35143514
this._currencyPositionLeft = undefined;
35153515
if (!this._init) {
3516-
this.notifyChanges();
3516+
this.pipeTrigger++;
3517+
this.notifyChanges(true);
35173518
}
35183519
});
35193520
}

projects/igniteui-angular/src/lib/grids/summaries/summary-cell.component.ts

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { GridColumnDataType } from '../../data-operations/data-util';
77
import { NgTemplateOutlet } from '@angular/common';
88
import { ISelectionNode } from '../common/types';
99
import { ColumnType } from '../common/grid.interface';
10-
import { formatCurrency, formatDate, formatNumber, formatPercent, getCurrencyCode, getCurrencySymbol, trackByIdentity } from '../../core/utils';
10+
import { formatCurrency, formatDate, formatNumber, formatPercent, getCurrencyCode, trackByIdentity } from '../../core/utils';
1111

1212
@Component({
1313
changeDetection: ChangeDetectionStrategy.OnPush,
@@ -112,14 +112,6 @@ export class IgxSummaryCellComponent {
112112
return getCurrencyCode(this.locale, this.column.pipeArgs.currencyCode);
113113
}
114114

115-
/**
116-
* @hidden @internal
117-
*/
118-
public get currencySymbol(): string {
119-
return this.column.pipeArgs.display ?
120-
this.column.pipeArgs.display : getCurrencySymbol(getCurrencyCode(this.locale), this.locale);
121-
}
122-
123115
/** cached single summary res after filter resets collection */
124116
protected trackSummaryResult = trackByIdentity;
125117

@@ -155,7 +147,7 @@ export class IgxSummaryCellComponent {
155147
case GridColumnDataType.Time:
156148
return formatDate(summary.summaryResult, args.format, locale, args.timezone);
157149
case GridColumnDataType.Currency:
158-
return formatCurrency(summary.summaryResult, locale, this.currencySymbol, this.currencyCode, args.digitsInfo);
150+
return formatCurrency(summary.summaryResult, locale, args.display, this.currencyCode, args.digitsInfo);
159151
case GridColumnDataType.Percent:
160152
return formatPercent(summary.summaryResult, locale, args.digitsInfo);
161153
}

0 commit comments

Comments
 (0)