Skip to content

Commit d119a37

Browse files
authored
Merge pull request #7356 from IgniteUI/simeonoff/ripple-fix
fix(ripple): reset margin and border to avoid displacement
2 parents 2aeaca0 + 2ce4987 commit d119a37

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

projects/igniteui-angular/src/lib/core/styles/components/ripple/_ripple-theme.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,8 @@
5959
transform: translate3d(0, 0, 0) scale(0);
6060
will-change: opacity, transform;
6161
opacity: .5;
62+
margin: 0 !important;
63+
border: none !important;
6264
}
6365

6466
%igx-ripple-wrapper {

projects/igniteui-angular/src/lib/directives/ripple/ripple.directive.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,8 @@ export class IgxRippleDirective {
122122

123123
const rectBounds = target.getBoundingClientRect();
124124
const radius = Math.max(rectBounds.width, rectBounds.height);
125-
let left = event.clientX - rectBounds.left - radius / 2;
126-
let top = event.clientY - rectBounds.top - radius / 2;
125+
let left = Math.round(event.clientX - rectBounds.left - radius / 2);
126+
let top = Math.round(event.clientY - rectBounds.top - radius / 2);
127127

128128
if (this._centered) {
129129
left = top = 0;

src/app/app.component.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,15 +36,15 @@
3636

3737
<ng-template *ngIf="drawerState.miniVariant" igxDrawerMini>
3838
<nav>
39-
<span *ngFor="let item of componentLinks" igxDrawerItem routerLinkActive #rla="routerLinkActive" [active]="rla.isActive" routerLink="{{item.link}}">
39+
<span *ngFor="let item of componentLinks" igxRipple igxDrawerItem routerLinkActive #rla="routerLinkActive" [active]="rla.isActive" routerLink="{{item.link}}">
4040
<igx-icon fontSet="material">{{item.icon}}</igx-icon>
4141
</span>
4242

43-
<span *ngFor="let item of directiveLinks" igxDrawerItem routerLinkActive #rla="routerLinkActive" [active]="rla.isActive" routerLink="{{item.link}}">
43+
<span *ngFor="let item of directiveLinks" igxDrawerItem igxRipple routerLinkActive #rla="routerLinkActive" [active]="rla.isActive" routerLink="{{item.link}}">
4444
<igx-icon fontSet="material">{{item.icon}}</igx-icon>
4545
</span>
4646

47-
<span *ngFor="let item of styleLinks" igxDrawerItem routerLinkActive #rla="routerLinkActive" [active]="rla.isActive" routerLink="{{item.link}}">
47+
<span *ngFor="let item of styleLinks" igxDrawerItem igxRipple routerLinkActive #rla="routerLinkActive" [active]="rla.isActive" routerLink="{{item.link}}">
4848
<igx-icon fontSet="material">{{item.icon}}</igx-icon>
4949
</span>
5050
</nav>

0 commit comments

Comments
 (0)