Skip to content

Commit d13bd4e

Browse files
authored
Merge pull request #7431 from IgniteUI/mkirova/fix-7324
fix(igxGrid): Position pinned rows at bottom with absolute position.
2 parents 45a5bb0 + 1212a00 commit d13bd4e

File tree

5 files changed

+5
-11
lines changed

5 files changed

+5
-11
lines changed

projects/igniteui-angular/src/lib/core/styles/components/grid/_grid-theme.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1132,6 +1132,8 @@
11321132

11331133
%igx-grid__tr--pinned-bottom {
11341134
border-top: map-get($cell-pin, 'style') map-get($cell-pin, 'color') !important;
1135+
position: absolute;
1136+
bottom: 0;
11351137
}
11361138

11371139
%igx-grid__tr--edit {

projects/igniteui-angular/src/lib/grids/grid-base.directive.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4294,14 +4294,6 @@ export class IgxGridBaseDirective extends DisplayDensityBase implements
42944294
return this.calcHeight ? this.calcHeight + this.pinnedRowHeight : this.calcHeight;
42954295
}
42964296

4297-
get pinnedBottom() {
4298-
const start = this.verticalScrollContainer.state.startIndex;
4299-
const end = this.verticalScrollContainer.state.startIndex + this.verticalScrollContainer.state.chunkSize - 1;
4300-
const bottom = this.verticalScrollContainer.getScrollForIndex(end, true) - this.verticalScrollContainer.getScrollForIndex(start);
4301-
return bottom;
4302-
}
4303-
4304-
43054297
/**
43064298
* Recalculates grid width/height dimensions.
43074299
* @remarks

projects/igniteui-angular/src/lib/grids/grid/grid.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@
123123
'igx-grid__tr--pinned-bottom': !isRowPinningToTop,
124124
'igx-grid__tr--pinned-top': isRowPinningToTop
125125
}"
126-
class='igx-grid__tr--pinned' [style.bottom.px]=' !isRowPinningToTop ? pinnedBottom : null'>
126+
class='igx-grid__tr--pinned' [style.width.px]='calcWidth'>
127127
<ng-container *ngFor="let rowData of pinnedData; let rowIndex = index">
128128
<ng-container *ngTemplateOutlet="pinned_record_template; context: getContext(rowData, rowIndex, true)">
129129
</ng-container>

projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-grid.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@
102102
| gridSort:sortingExpressions:sortStrategy:id:pipeTrigger:true as pinnedData">
103103
<div #pinContainer *ngIf='pinnedData.length > 0' class='igx-grid__tr--pinned'
104104
[ngClass]="{ 'igx-grid__tr--pinned-bottom': !isRowPinningToTop, 'igx-grid__tr--pinned-top': isRowPinningToTop }"
105-
[style.bottom.px]=' !isRowPinningToTop ? pinnedBottom : null'>
105+
[style.width.px]='calcWidth'>
106106
<ng-container *ngFor="let rowData of pinnedData; let rowIndex = index">
107107
<ng-container *ngTemplateOutlet="pinned_hierarchical_record_template; context: getContext(rowData, rowIndex, true)">
108108
</ng-container>

projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@
8787
'igx-grid__tr--pinned-bottom': !isRowPinningToTop,
8888
'igx-grid__tr--pinned-top': isRowPinningToTop
8989
}"
90-
class='igx-grid__tr--pinned' [style.bottom.px]=' !isRowPinningToTop ? pinnedBottom : null'>
90+
class='igx-grid__tr--pinned' [style.width.px]='calcWidth'>
9191
<ng-container *ngFor="let rowData of pinnedData;let rowIndex = index;">
9292
<ng-container *ngTemplateOutlet="pinned_record_template; context: getContext(rowData, rowIndex, true)">
9393
</ng-container>

0 commit comments

Comments
 (0)