Skip to content

Commit d353e65

Browse files
authored
Merge branch 'master' into apetrov/fix-tabs-demo-icon
2 parents 4ced377 + 801d14f commit d353e65

File tree

10 files changed

+151
-80
lines changed

10 files changed

+151
-80
lines changed

package-lock.json

Lines changed: 73 additions & 28 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@
118118
"gulp-uglify": "^3.0.1",
119119
"hammer-simulator": "0.0.1",
120120
"hammerjs": "^2.0.8",
121-
"ig-typedoc-theme": "^6.0.0",
121+
"ig-typedoc-theme": "^7.0.0",
122122
"igniteui-dockmanager": "^1.17.0",
123123
"igniteui-sassdoc-theme": "^2.1.0",
124124
"igniteui-webcomponents": "6.2.1",
@@ -146,8 +146,8 @@
146146
"stylelint-prettier": "^5.0.2",
147147
"stylelint-scss": "^6.9.0",
148148
"ts-node": "^10.8.1",
149-
"typedoc": "^0.27.0",
150-
"typedoc-plugin-localization": "^3.0.6",
149+
"typedoc": "^0.28.14",
150+
"typedoc-plugin-localization": "^3.1.0",
151151
"typescript": "5.8.3"
152152
}
153153
}

projects/igniteui-angular/src/lib/core/styles/components/time-picker/_time-picker-theme.scss

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -23,21 +23,6 @@
2323
'indigo': rem(16px),
2424
), $variant);
2525

26-
.igx-input-group {
27-
display: flex;
28-
flex-direction: column;
29-
30-
@if $variant == 'indigo' or $variant == 'bootstrap' {
31-
[igxLabel] {
32-
margin-block-end: rem(4px);
33-
}
34-
} @else if $variant == 'fluent' {
35-
[igxLabel] {
36-
margin-block-end: rem(5px);
37-
}
38-
}
39-
}
40-
4126
%time-picker-display {
4227
@include sizable();
4328

projects/igniteui-angular/src/lib/core/styles/components/tooltip/_tooltip-theme.scss

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
gap: rem(8px);
2424
min-height: rem(24px);
2525
min-width: rem(24px);
26-
max-width: 200px;
26+
max-width: rem(200px);
2727
width: fit-content;
2828

2929
igx-icon {
@@ -34,6 +34,10 @@
3434
display: flex;
3535
cursor: default;
3636
}
37+
38+
&:not([data-default]) {
39+
max-width: initial;
40+
}
3741
}
3842

3943
%arrow--top {
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<span igxTooltip>{{content}}</span>
1+
<span data-default igxTooltip>{{content}}</span>

projects/igniteui-angular/src/lib/directives/tooltip/tooltip.directive.spec.ts

Lines changed: 33 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { DebugElement } from '@angular/core';
22
import { fakeAsync, TestBed, tick, flush, waitForAsync, ComponentFixture } from '@angular/core/testing';
33
import { By } from '@angular/platform-browser';
44
import { NoopAnimationsModule } from '@angular/platform-browser/animations';
5-
import { IgxTooltipSingleTargetComponent, IgxTooltipMultipleTargetsComponent, IgxTooltipPlainStringComponent, IgxTooltipWithToggleActionComponent, IgxTooltipMultipleTooltipsComponent, IgxTooltipWithCloseButtonComponent } from '../../test-utils/tooltip-components.spec';
5+
import { IgxTooltipSingleTargetComponent, IgxTooltipMultipleTargetsComponent, IgxTooltipPlainStringComponent, IgxTooltipWithToggleActionComponent, IgxTooltipMultipleTooltipsComponent, IgxTooltipWithCloseButtonComponent, IgxTooltipWithNestedContentComponent } from '../../test-utils/tooltip-components.spec';
66
import { UIInteractions } from '../../test-utils/ui-interactions.spec';
77
import { HorizontalAlignment, VerticalAlignment, AutoPositionStrategy } from '../../services/public_api';
88
import { IgxTooltipDirective } from './tooltip.directive';
@@ -28,7 +28,8 @@ describe('IgxTooltip', () => {
2828
IgxTooltipMultipleTargetsComponent,
2929
IgxTooltipPlainStringComponent,
3030
IgxTooltipWithToggleActionComponent,
31-
IgxTooltipWithCloseButtonComponent
31+
IgxTooltipWithCloseButtonComponent,
32+
IgxTooltipWithNestedContentComponent
3233
]
3334
}).compileComponents();
3435
UIInteractions.clearOverlay();
@@ -500,6 +501,36 @@ describe('IgxTooltip', () => {
500501

501502
verifyTooltipVisibility(tooltipNativeElement, tooltipTarget, false);
502503
}));
504+
505+
it('Should respect default max-width constraint for plain string tooltip', fakeAsync(() => {
506+
hoverElement(button);
507+
flush();
508+
509+
verifyTooltipVisibility(tooltipNativeElement, tooltipTarget, true);
510+
511+
const maxWidth = getComputedStyle(tooltipNativeElement).maxWidth;
512+
expect(maxWidth).toBe('200px');
513+
}));
514+
});
515+
516+
describe('Custom content tooltip', () => {
517+
beforeEach(waitForAsync(() => {
518+
fix = TestBed.createComponent(IgxTooltipWithNestedContentComponent);
519+
fix.detectChanges();
520+
button = fix.debugElement.query(By.directive(IgxTooltipTargetDirective));
521+
tooltipTarget = fix.componentInstance.tooltipTarget;
522+
tooltipNativeElement = fix.debugElement.query(By.directive(IgxTooltipDirective)).nativeElement;
523+
}));
524+
525+
it('Should not have max-width constraint for custom content tooltip', fakeAsync(() => {
526+
hoverElement(button);
527+
flush();
528+
529+
verifyTooltipVisibility(tooltipNativeElement, tooltipTarget, true);
530+
531+
const maxWidth = getComputedStyle(tooltipNativeElement).maxWidth;
532+
expect(maxWidth).toBe('none');
533+
}));
503534
});
504535

505536
describe('Multiple targets with single tooltip', () => {

projects/igniteui-angular/src/lib/grids/columns/column.component.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1066,6 +1066,7 @@ export class IgxColumnComponent implements AfterContentInit, OnDestroy, ColumnTy
10661066
return (this.grid as any)._columns.indexOf(this);
10671067
}
10681068

1069+
/* mustCoerceToInt */
10691070
/**
10701071
* Gets the pinning position of the column.
10711072
* ```typescript

projects/igniteui-angular/src/lib/services/excel/excel-exporter.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ export class IgxExcelExporterService extends IgxBaseExporter {
146146
}
147147

148148
private saveFile(data: Uint8Array, fileName: string): void {
149-
const blob = new Blob([data], {
149+
const blob = new Blob([data as BlobPart], {
150150
type: 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet'
151151
});
152152

projects/igniteui-angular/src/lib/test-utils/tooltip-components.spec.ts

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -149,3 +149,23 @@ export class IgxTooltipWithCloseButtonComponent {
149149
@ViewChild(IgxTooltipDirective, { static: true }) public tooltip: IgxTooltipDirective;
150150
@ViewChild(IgxTooltipTargetDirective, { static: true }) public tooltipTarget: IgxTooltipTargetDirective;
151151
}
152+
153+
@Component({
154+
template: `
155+
<button class="btn" [igxTooltipTarget]="tooltipRef">
156+
Hover me
157+
</button>
158+
159+
<div igxTooltip #tooltipRef="tooltip">
160+
<div class="nested" style="background: red; width: 400px; color: white; padding: 4px;">
161+
<span>Nested content</span>
162+
</div>
163+
</div>
164+
`,
165+
imports: [IgxTooltipDirective, IgxTooltipTargetDirective],
166+
standalone: true
167+
})
168+
export class IgxTooltipWithNestedContentComponent {
169+
@ViewChild(IgxTooltipDirective, { static: true }) public tooltip!: IgxTooltipDirective;
170+
@ViewChild(IgxTooltipTargetDirective, { static: true }) public tooltipTarget!: IgxTooltipTargetDirective;
171+
}

0 commit comments

Comments
 (0)