Skip to content

Commit d4d0176

Browse files
authored
Merge branch '15.0.x' into randriova/localization-grid-15.0.x
2 parents e6bdecc + 14fe923 commit d4d0176

File tree

27 files changed

+436
-58
lines changed

27 files changed

+436
-58
lines changed

package-lock.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@
114114
"hammer-simulator": "0.0.1",
115115
"ig-typedoc-theme": "^4.2.0",
116116
"igniteui-sassdoc-theme": "^1.1.4",
117-
"igniteui-theming": "^1.1.4",
117+
"igniteui-theming": "^1.2.0",
118118
"igniteui-webcomponents": "^4.0.0",
119119
"jasmine": "^4.5.0",
120120
"jasmine-core": "~4.5.0",

projects/igniteui-angular/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@
8383
"@angular/core": "^15.0.0",
8484
"@angular/animations": "^15.0.0",
8585
"@angular/forms": "^15.0.0",
86-
"igniteui-theming": "^1.1.2"
86+
"igniteui-theming": "^1.2.0"
8787
},
8888
"igxDevDependencies": {
8989
"@igniteui/angular-schematics": "~15.0.1100"

projects/igniteui-angular/src/lib/action-strip/grid-actions/grid-editing-actions.component.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,9 @@ export class IgxGridEditingActionsComponent extends IgxGridActionsBaseDirective
117117
// be sure row is in view
118118
if (grid.rowList.filter(r => r === row).length !== 0) {
119119
grid.gridAPI.crudService.enterEditMode(firstEditable, event);
120-
firstEditable.activate(event);
120+
if (!grid.gridAPI.crudService.nonEditable){
121+
firstEditable.activate(event);
122+
}
121123
}
122124
this.strip.hide();
123125
}

projects/igniteui-angular/src/lib/combo/combo.common.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -986,12 +986,12 @@ export abstract class IgxComboBaseDirective extends DisplayDensityBase implement
986986
});
987987
}
988988

989-
/** @hidden @internal */
990-
public ngDoCheck() {
991-
if (this.data?.length && this.selection.length) {
992-
this._value = this.createDisplayText(this.selection, []);
993-
}
989+
/** @hidden @internal */
990+
public ngDoCheck() {
991+
if (this.data?.length && this.selection.length && !this._value) {
992+
this._value = this.createDisplayText(this.selection, []);
994993
}
994+
}
995995

996996
/** @hidden @internal */
997997
public ngOnDestroy() {

projects/igniteui-angular/src/lib/combo/combo.component.spec.ts

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2243,6 +2243,29 @@ describe('igxCombo', () => {
22432243
const expectedOutput = 'One';
22442244
expect(input.nativeElement.value).toEqual(expectedOutput);
22452245
}));
2246+
it('should display custom displayText on selection/deselection', () => {
2247+
combo.valueKey = 'key';
2248+
combo.displayKey = 'value';
2249+
combo.data = [
2250+
{ key: 1, value: 'One' },
2251+
{ key: 2, value: 'Two' },
2252+
{ key: 3, value: 'Three' },
2253+
];
2254+
2255+
spyOn(combo.selectionChanging, 'emit').and.callFake(
2256+
(event: IComboSelectionChangingEventArgs) => event.displayText = `Selected Count: ${event.newSelection.length}`);
2257+
2258+
combo.select([1]);
2259+
fixture.detectChanges();
2260+
2261+
expect(combo.selection).toEqual([1]);
2262+
expect(combo.value).toBe('Selected Count: 1');
2263+
2264+
combo.deselect([1]);
2265+
2266+
expect(combo.selection).toEqual([]);
2267+
expect(combo.value).toBe('Selected Count: 0');
2268+
});
22462269
});
22472270
describe('Grouping tests: ', () => {
22482271
configureTestSuite();

projects/igniteui-angular/src/lib/core/styles/components/button/_button-theme.scss

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -258,9 +258,9 @@
258258
$button-icon-padding: 0;
259259

260260
$button-padding-material: (
261-
comfortable: rem(9px, 16px) rem(16px, 16px),
262-
cosy: rem(6px, 16px) rem(16px, 16px),
263-
compact: rem(3px, 16px) rem(16px, 16px)
261+
comfortable: rem(7px, 16px) rem(16px, 16px),
262+
cosy: rem(4px, 16px) rem(16px, 16px),
263+
compact: rem(1px, 16px) rem(16px, 16px)
264264
);
265265

266266
$outlined-button-padding-material: (

projects/igniteui-angular/src/lib/core/styles/components/calendar/_calendar-theme.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -640,6 +640,8 @@
640640
igx-years-view,
641641
igx-month-picker,
642642
igx-months-view {
643+
color: var-get($theme, 'content-text-color');
644+
643645
%cal-body-display {
644646
@if $bootstrap-theme {
645647
padding-bottom: 0;

projects/igniteui-angular/src/lib/core/styles/components/dock-manager/_dock-manager-theme.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@
6565

6666
$theme: digest-schema($dock-manager-schema);
6767

68-
@return extend($theme, (name: $name), keywords($rest));
68+
@return extend($theme, (name: $name, prefix: 'igc'), keywords($rest));
6969
}
7070

7171
/// @param {Map} $theme - The theme used to style the component.

projects/igniteui-angular/src/lib/core/styles/components/grid-toolbar/_grid-toolbar-theme.scss

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,8 @@
121121
);
122122

123123
%igx-grid-toolbar {
124+
position: absolute;
125+
width: 100%;
124126
display: flex;
125127
align-items: center;
126128
justify-content: space-between;
@@ -136,7 +138,6 @@
136138
background: var-get($theme, 'background-color');
137139
height: auto;
138140
min-height: map.get($grid-toolbar-height, 'comfortable');
139-
position: relative;
140141
padding-block: 0;
141142
padding-inline: map.get($grid-toolbar-padding, 'comfortable');
142143

@@ -164,15 +165,24 @@
164165
}
165166
}
166167
}
168+
169+
+ igx-grid-header-row {
170+
margin-top: map.get($grid-toolbar-height, 'comfortable');
171+
}
167172
}
168173

174+
169175
%igx-grid-toolbar--cosy {
170176
min-height: map.get($grid-toolbar-height, 'cosy');
171177
padding-inline: map.get($grid-toolbar-padding, 'cosy');
172178

173179
[igxButton] {
174180
margin-inline-start: map.get($grid-toolbar-spacer, 'cosy');
175181
}
182+
183+
+ igx-grid-header-row {
184+
margin-top: map.get($grid-toolbar-height, 'cosy');
185+
}
176186
}
177187

178188
%igx-grid-toolbar--compact {
@@ -182,6 +192,10 @@
182192
[igxButton] {
183193
margin-inline-start: map.get($grid-toolbar-spacer, 'compact');
184194
}
195+
196+
+ igx-grid-header-row {
197+
margin-top: map.get($grid-toolbar-height, 'compact');
198+
}
185199
}
186200

187201
%igx-grid-toolbar__title {

0 commit comments

Comments
 (0)