Skip to content

Commit d5cd233

Browse files
authored
Merge pull request #14406 from IgniteUI/simeonoff/navbar-sizes-17.2.x
fix(navbar): update component sizes in the context of the navbar
2 parents 797de67 + 6d34f03 commit d5cd233

File tree

6 files changed

+37
-17
lines changed

6 files changed

+37
-17
lines changed

package-lock.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
"@types/source-map": "0.5.2",
7171
"express": "^4.19.2",
7272
"fflate": "^0.8.1",
73-
"igniteui-theming": "^6.3.1",
73+
"igniteui-theming": "^6.3.2",
7474
"igniteui-trial-watermark": "^3.0.2",
7575
"lodash-es": "^4.17.21",
7676
"rxjs": "^7.8.0",

projects/igniteui-angular/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@
7474
"igniteui-trial-watermark": "^3.0.2",
7575
"lodash-es": "^4.17.21",
7676
"uuid": "^9.0.0",
77-
"igniteui-theming": "^6.3.1",
77+
"igniteui-theming": "^6.3.2",
7878
"@igniteui/material-icons-extended": "^3.0.0"
7979
},
8080
"peerDependencies": {

projects/igniteui-angular/src/lib/core/styles/components/navbar/_navbar-theme.scss

Lines changed: 26 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -110,21 +110,38 @@
110110
overflow: hidden;
111111
border-bottom: rem(1px) solid var-get($theme, 'border-color');
112112

113-
igx-avatar,
114-
igx-input-group,
115-
[igxIconButton],
116-
igc-avatar,
117-
igc-input,
118-
igc-icon-button {
113+
igx-avatar {
119114
--ig-size: 1;
120115
}
121116

122-
[igxButton],
123-
igc-button {
124-
--ig-size: 2;
117+
@if $variant == 'material' {
118+
igx-input-group {
119+
--ig-size: 1;
120+
}
121+
}
122+
123+
@if $variant == 'bootstrap' {
124+
igc-input,
125+
igc-icon-button {
126+
--ig-size: 1;
127+
}
128+
129+
[igxButton],
130+
igc-button,
131+
[igxIconButton],
132+
igx-input-group {
133+
--ig-size: 2;
134+
}
135+
}
136+
137+
@if $variant == 'fluent' {
138+
igx-input-group {
139+
--ig-size: 2;
140+
}
125141
}
126142

127143
@if $variant == 'indigo-design' {
144+
igx-avatar,
128145
igc-icon-button,
129146
[igxIconButton] {
130147
--ig-size: 2;

projects/igniteui-angular/src/lib/grids/grid/grid.component.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2419,7 +2419,7 @@ describe('IgxGrid Component Tests #grid', () => {
24192419
- grid.footer.nativeElement.offsetHeight
24202420
- (grid.isHorizontalScrollHidden ? 0 : grid.scrollSize);
24212421
expect(parseInt(window.getComputedStyle(gridBody.nativeElement).height, 10)).toBe(expectedHeight);
2422-
expect(parseInt(window.getComputedStyle(paging.nativeElement).height, 10)).toBe(30);
2422+
expect(parseInt(window.getComputedStyle(paging.nativeElement).height, 10)).toBe(36);
24232423
});
24242424

24252425
it('IgxTabs: should initialize a grid with correct height when height = 100%', async () => {
@@ -2437,7 +2437,7 @@ describe('IgxGrid Component Tests #grid', () => {
24372437
const paging = fix.debugElement.query(By.css('igx-page-nav'));
24382438
expect(headers.length).toBe(4);
24392439
expect(parseInt(window.getComputedStyle(gridBody.nativeElement).height, 10)).toBe(204);
2440-
expect(parseInt(window.getComputedStyle(paging.nativeElement).height, 10)).toBe(30);
2440+
expect(parseInt(window.getComputedStyle(paging.nativeElement).height, 10)).toBe(36);
24412441
});
24422442

24432443
it('IgxTabs: should initialize a grid with correct height height = 100% when parent has height', async () => {

src/app/navbar/navbar.sample.html

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,9 @@ <h4 class="sample-title">buttons (flat, outlined, contained)</h4>
111111
<h4 class="sample-title">Avatar and Progressbar</h4>
112112
<div class="navbar-sample">
113113
<igx-navbar actionButtonIcon="menu">
114+
<igx-input-group type="box">
115+
<input name="inputSearchTest" #input igxInput placeholder="Search"/>
116+
</igx-input-group>
114117
<igx-avatar initials="MP"></igx-avatar>
115118
<igx-circular-bar indeterminate></igx-circular-bar>
116119
</igx-navbar>

0 commit comments

Comments
 (0)