Skip to content

Commit d631979

Browse files
authored
Merge pull request #12925 from IgniteUI/bpenkov/migrations-fw
Do not add file & directory watchers in ServerHost
2 parents 129a59a + dd4d419 commit d631979

File tree

2 files changed

+85
-4
lines changed

2 files changed

+85
-4
lines changed

projects/igniteui-angular/migrations/common/ServerHost.ts

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,15 +38,24 @@ export class ServerHost implements ts.server.ServerHost {
3838
return ts.sys.getFileSize(path);
3939
}
4040

41-
public watchFile(path: string, callback: ts.FileWatcherCallback, pollingInterval?: number):
41+
//#region Watchers
42+
// Atm we do not need to have file or dir watchers that access the actual FS
43+
// as we are only working with NG's virtual FS
44+
// Prior to https://github.com/microsoft/TypeScript/pull/49990 we were more or less required
45+
// to add a watcher since it threw an error otherwise
46+
47+
public watchFile(_path: string, _callback: ts.FileWatcherCallback, _pollingInterval?: number):
4248
ts.FileWatcher {
43-
return ts.sys.watchFile(path, callback, pollingInterval);
49+
// return ts.sys.watchFile(path, callback, pollingInterval);
50+
return undefined;
4451
}
4552

46-
public watchDirectory(path: string, callback: ts.DirectoryWatcherCallback, recursive?: boolean):
53+
public watchDirectory(_path: string, _callback: ts.DirectoryWatcherCallback, _recursive?: boolean):
4754
ts.FileWatcher {
48-
return ts.sys.watchDirectory(path, callback, recursive);
55+
// return ts.sys.watchDirectory(path, callback, recursive);
56+
return undefined;
4957
}
58+
//#endregion
5059

5160
public resolvePath(path: string): string {
5261
return ts.sys.resolvePath(path);
Lines changed: 72 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,72 @@
1+
{
2+
"$schema": "../../common/schema/members-changes.schema.json",
3+
"changes": [
4+
{
5+
"member": "onGroupingDone",
6+
"replaceWith": "groupingDone",
7+
"definedIn": [
8+
"IgxGridComponent"
9+
]
10+
},
11+
{
12+
"member": "onDensityChanged",
13+
"replaceWith": "densityChanged",
14+
"definedIn": [
15+
"IgxActionStripComponent",
16+
"IgxButtonGroupComponent",
17+
"IgxChipComponent",
18+
"IgxComboComponent",
19+
"IgxDatePickerComponent",
20+
"IgxDateRangePickerComponent",
21+
"IgxTimePickerComponent",
22+
"IgxButtonDirective",
23+
"IgxDropDownComponent",
24+
"IgxGridComponent",
25+
"IgxGridToolbarComponent",
26+
"IgxTreeGridComponent",
27+
"IgxHierarchicalGridComponent",
28+
"IgxPivotGridComponent",
29+
"IgxInputGroupComponent",
30+
"IgxListComponent",
31+
"IgxPaginatorComponent",
32+
"IgxQueryBuilderComponent",
33+
"IgxTreeComponent"
34+
]
35+
},
36+
{
37+
"member": "onSlideChanged",
38+
"replaceWith": "slideChanged",
39+
"definedIn": [
40+
"IgxCarouselComponent"
41+
]
42+
},
43+
{
44+
"member": "onSlideAdded",
45+
"replaceWith": "slideAdded",
46+
"definedIn": [
47+
"IgxCarouselComponent"
48+
]
49+
},
50+
{
51+
"member": "onSlideRemoved",
52+
"replaceWith": "slideRemoved",
53+
"definedIn": [
54+
"IgxCarouselComponent"
55+
]
56+
},
57+
{
58+
"member": "onCarouselPaused",
59+
"replaceWith": "carouselPaused",
60+
"definedIn": [
61+
"IgxCarouselComponent"
62+
]
63+
},
64+
{
65+
"member": "onCarouselPlaying",
66+
"replaceWith": "carouselPlaying",
67+
"definedIn": [
68+
"IgxCarouselComponent"
69+
]
70+
}
71+
]
72+
}

0 commit comments

Comments
 (0)