Skip to content

Commit d63e432

Browse files
authored
Merge branch '9.1.x' into mkirova/fix-7954-9.1.x
2 parents bc08c92 + f7768ce commit d63e432

File tree

6 files changed

+35
-6
lines changed

6 files changed

+35
-6
lines changed

projects/igniteui-angular/src/lib/core/styles/components/column-hiding/_column-hiding-theme.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@
8484
display: flex;
8585
flex-flow: column nowrap;
8686
overflow-y: auto;
87+
outline-style: none;
8788
}
8889

8990
%column-hiding-item {

projects/igniteui-angular/src/lib/grids/hiding/column-hiding.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<div class="igx-column-hiding__header">
1+
<div class="igx-column-hiding__header" >
22
<h4 class="igx-column-hiding__header-title" *ngIf="title">{{ title }}</h4>
33

44
<igx-input-group class="igx-column-hiding__header-input" *ngIf="!disableFilter">
@@ -10,7 +10,7 @@ <h4 class="igx-column-hiding__header-title" *ngIf="title">{{ title }}</h4>
1010
</igx-input-group>
1111
</div>
1212

13-
<div class="igx-column-hiding__columns"
13+
<div class="igx-column-hiding__columns" tabindex="0"
1414
[style.max-height]="columnsAreaMaxHeight">
1515
<igx-checkbox
1616
*ngFor="let columnItem of hidableColumns"

projects/igniteui-angular/src/lib/grids/pinning/column-pinning.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ <h4 class="igx-column-hiding__header-title" *ngIf="title">{{ title }}</h4>
1111
</igx-input-group>
1212
</div>
1313

14-
<div class="igx-column-hiding__columns"
14+
<div class="igx-column-hiding__columns" tabindex="0"
1515
[style.max-height]="columnsAreaMaxHeight">
1616
<igx-checkbox igxColumnPinningItem
1717
*ngFor="let columnItem of pinnableColumns"

projects/igniteui-angular/src/lib/grids/toolbar/grid-toolbar.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
<span>{{ grid.hiddenColumnsText }}</span>
3232
</div>
3333
</button>
34-
<igx-drop-down #columnHidingDropdown>
34+
<igx-drop-down #columnHidingDropdown (onClosing)="onClosingColumnHiding($event)">
3535
<igx-column-hiding
3636
[columns]="grid.columns"
3737
[title]="grid.columnHidingTitle"
@@ -52,7 +52,7 @@
5252
<span></span>
5353
</div>
5454
</button>
55-
<igx-drop-down #columnPinningDropdown>
55+
<igx-drop-down #columnPinningDropdown (onClosing)="onClosingColumnPinning($event)">
5656
<igx-column-pinning
5757
[columns]="grid.columns"
5858
[title]="grid.columnPinningTitle"

projects/igniteui-angular/src/lib/grids/toolbar/grid-toolbar.component.ts

Lines changed: 25 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ export class IgxGridToolbarComponent extends DisplayDensityBase implements After
236236
@Optional() public csvExporter: IgxCsvExporterService,
237237
@Optional() @Inject(DisplayDensityToken) protected _displayDensityOptions: IDisplayDensityOptions,
238238
private iconService: IgxIconService) {
239-
super(_displayDensityOptions);
239+
super(_displayDensityOptions);
240240
}
241241

242242
private _positionSettings: PositionSettings = {
@@ -410,4 +410,28 @@ export class IgxGridToolbarComponent extends DisplayDensityBase implements After
410410
}
411411
}
412412
}
413+
414+
/**
415+
* @hidden @internal
416+
*/
417+
public onClosingColumnHiding(args) {
418+
const activeElem = document.activeElement;
419+
420+
if (!args.event && activeElem !== this.grid.nativeElement &&
421+
!this.columnHidingButton.nativeElement.contains(activeElem)) {
422+
args.cancel = true;
423+
}
424+
}
425+
426+
/**
427+
* @hidden @internal
428+
*/
429+
public onClosingColumnPinning(args) {
430+
const activeElem = document.activeElement;
431+
432+
if (!args.event && activeElem !== this.grid.nativeElement &&
433+
!this.columnPinningButton.nativeElement.contains(activeElem)) {
434+
args.cancel = true;
435+
}
436+
}
413437
}

projects/igniteui-angular/src/lib/navigation-drawer/navigation-drawer.component.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -495,6 +495,10 @@ export class IgxNavigationDrawerComponent implements
495495
this.setDrawerWidth(changes.width.currentValue);
496496
}
497497

498+
if (changes.isOpen) {
499+
this.setDrawerWidth(this.isOpen ? this.width : (this.miniTemplate ? this.miniWidth : ''));
500+
}
501+
498502
if (changes.miniWidth) {
499503
if (!this.isOpen) {
500504
this.setDrawerWidth(changes.miniWidth.currentValue);

0 commit comments

Comments
 (0)