Merge pull request #15824 from IgniteUI/dpetev/analyzer-updates-19.2

Analyzer updates and grid dataChanged typing adjust

Author: damyanpetev

projects/igniteui-angular/src/lib/directives/for-of/for_of.directive.ts

@@ -225,7 +225,7 @@ export class IgxForOfDirective<T, U extends T[] = T[]> extends IgxForOfToken<T,U
      * ```
      */
     @Output()
-    public dataChanged = new EventEmitter<any>();
+    public dataChanged = new EventEmitter<IForOfDataChangeEventArgs>();
 
     @Output()
     public beforeViewDestroyed = new EventEmitter<EmbeddedViewRef<any>>();
@@ -1512,11 +1512,16 @@ export interface IForOfState extends IBaseEventArgs {
     chunkSize?: number;
 }
 
+/**
+ * @deprecated in 19.2.7. Use `IForOfDataChangeEventArgs` instead.
+ */
 export interface IForOfDataChangingEventArgs extends IBaseEventArgs {
     containerSize: number;
     state: IForOfState;
 }
 
+export interface IForOfDataChangeEventArgs extends IForOfDataChangingEventArgs {}
+
 export class IgxGridForOfContext<T, U extends T[] = T[]> extends IgxForOfContext<T, U> {
     constructor(
         $implicit: T,
@@ -1585,7 +1590,7 @@ export class IgxGridForOfDirective<T, U extends T[] = T[]> extends IgxForOfDirec
      * An event that is emitted after data has been changed but before the view is refreshed
      */
     @Output()
-    public dataChanging = new EventEmitter<IForOfDataChangingEventArgs>();
+    public dataChanging = new EventEmitter<IForOfDataChangeEventArgs>();
 
     constructor(
         _viewContainer: ViewContainerRef,

projects/igniteui-angular/src/lib/grids/grid-base.directive.ts

@@ -40,7 +40,7 @@ import { cloneArray, mergeObjects, compareMaps, resolveNestedPath, isObject, Pla
 import { GridColumnDataType } from '../data-operations/data-util';
 import { FilteringLogic } from '../data-operations/filtering-expression.interface';
 import { IGroupByRecord } from '../data-operations/groupby-record.interface';
-import { IForOfDataChangingEventArgs, IgxGridForOfDirective } from '../directives/for-of/for_of.directive';
+import { IForOfDataChangeEventArgs, IgxGridForOfDirective } from '../directives/for-of/for_of.directive';
 import { IgxTextHighlightService } from '../directives/text-highlight/text-highlight.service';
 import { ISummaryExpression } from './summaries/grid-summary';
 import { IgxGridBodyDirective, RowEditPositionStrategy } from './grid.common';
@@ -993,6 +993,7 @@ export abstract class IgxGridBaseDirective implements GridType,
     @Output()
     public gridCopy = new EventEmitter<IGridClipboardEvent>();
 
+    /* blazorCSSuppress */
     /**
      * Emitted when the rows are expanded or collapsed.
      *
@@ -1117,7 +1118,7 @@ export abstract class IgxGridBaseDirective implements GridType,
      * ```
      */
     @Output()
-    public dataChanging = new EventEmitter<IForOfDataChangingEventArgs>();
+    public dataChanging = new EventEmitter<IForOfDataChangeEventArgs>();
 
     /**
      * Emitted after the grid's data view is changed because of a data operation, rebinding, etc.
@@ -1128,7 +1129,7 @@ export abstract class IgxGridBaseDirective implements GridType,
      * ```
      */
     @Output()
-    public dataChanged = new EventEmitter<any>();
+    public dataChanged = new EventEmitter<IForOfDataChangeEventArgs>();
 
 
     /**
@@ -3920,7 +3921,7 @@ export abstract class IgxGridBaseDirective implements GridType,
     /**
      * @hidden @internal
      */
-    public dataRebinding(event: IForOfDataChangingEventArgs) {
+    public dataRebinding(event: IForOfDataChangeEventArgs) {
         if (event.state.chunkSize == 0) {
             this._shouldRecalcRowHeight = true;
         }
@@ -3930,7 +3931,7 @@ export abstract class IgxGridBaseDirective implements GridType,
     /**
      * @hidden @internal
      */
-    public dataRebound(event) {
+    public dataRebound(event: IForOfDataChangeEventArgs) {
         this.selectionService.clearHeaderCBState();
         if (this._shouldRecalcRowHeight) {
             this._shouldRecalcRowHeight = false;
@@ -4194,7 +4195,7 @@ export abstract class IgxGridBaseDirective implements GridType,
         col.toggleVisibility(args.newValue);
     }
 
-    /* blazorSuppress */
+    /* blazorCSSuppress */
     /**
      * Gets/Sets a list of key-value pairs [row ID, expansion state].
      *
@@ -4212,7 +4213,7 @@ export abstract class IgxGridBaseDirective implements GridType,
         return this._expansionStates;
     }
 
-    /* blazorSuppress */
+    /* blazorCSSuppress */
     public set expansionStates(value) {
         this._expansionStates = new Map<any, boolean>(value);
         this.expansionStatesChange.emit(this._expansionStates);

projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-grid.component.ts

@@ -574,6 +574,7 @@ export class IgxHierarchicalGridComponent extends IgxHierarchicalGridBaseDirecti
         return this._defaultExpandState;
     }
 
+    /* blazorSuppress */
     /**
      * Gets/Sets the schema for the hierarchical grid.
      * This schema defines the structure and properties of the data displayed in the grid.
@@ -592,6 +593,7 @@ export class IgxHierarchicalGridComponent extends IgxHierarchicalGridBaseDirecti
         this._hGridSchema = entities;
     }
 
+    /* blazorSuppress */
     public get schema() {
         if (!this._hGridSchema) {
             this._hGridSchema = this.generateSchema();
@@ -1233,8 +1235,8 @@ export class IgxHierarchicalGridComponent extends IgxHierarchicalGridBaseDirecti
 
     private generateSchema() {
         const filterableFields = this.columns.filter((column) => !column.columnGroup && column.filterable);
-        let entities: EntityType[];  
-      
+        let entities: EntityType[];
+
         if(filterableFields.length !== 0) {
             entities = [
                 {
@@ -1292,7 +1294,7 @@ export class IgxHierarchicalGridComponent extends IgxHierarchicalGridBaseDirecti
 
         if (rowIslandChildEntities?.length > 0) {
             childEntities = rowIslandChildEntities;
-        } 
+        }
 
         return {
             name: entityName,

projects/igniteui-angular/src/public_api.ts

@@ -20,7 +20,13 @@ export * from './lib/directives/filter/filter.directive';
 export * from './lib/directives/focus/focus.directive';
 export * from './lib/directives/focus-trap/focus-trap.directive';
 export {
-    IgxForOfContext, IgxForOfDirective, IForOfState, IgxGridForOfContext, IgxGridForOfDirective
+    IForOfDataChangeEventArgs,
+    IForOfDataChangingEventArgs,
+    IForOfState,
+    IgxForOfContext,
+    IgxForOfDirective,
+    IgxGridForOfContext,
+    IgxGridForOfDirective,
 } from './lib/directives/for-of/for_of.directive';
 export * from './lib/directives/button/icon-button.directive';
 export * from './lib/directives/layout/layout.directive';