Skip to content

Commit dad528c

Browse files
authored
Merge pull request #7559 from IgniteUI/nrobakova/fix-issue-7055-82
Fix not ending while in generateDateRange method
2 parents e5ba973 + 02c1768 commit dad528c

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

projects/igniteui-angular/src/lib/calendar/calendar-base.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -375,7 +375,7 @@ export class IgxCalendarBase implements ControlValueAccessor {
375375
const result = [];
376376
start = this.getDateOnly(start);
377377
end = this.getDateOnly(end);
378-
while (start.getTime() !== end.getTime()) {
378+
while (start.getTime() < end.getTime()) {
379379
start = this.calendarModel.timedelta(start, 'day', 1);
380380
result.push(start);
381381
}

projects/igniteui-angular/src/lib/calendar/calendar.component.spec.ts

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1056,8 +1056,9 @@ describe('IgxCalendar', () => {
10561056
const fixture = TestBed.createComponent(IgxCalendarDisabledSpecialDatesComponent);
10571057
fixture.detectChanges();
10581058
const calendar = fixture.componentInstance.calendar;
1059-
expect(calendar.specialDates).toEqual([{type: DateRangeType.Between, dateRange: [new Date(2017, 5, 1), new Date(2017, 5, 6)]}]);
1060-
expect(calendar.disabledDates).toEqual([{type: DateRangeType.Between, dateRange: [new Date(2017, 5, 23), new Date(2017, 5, 29)]}]);
1059+
expect(calendar.specialDates).toEqual([{ type: DateRangeType.Between, dateRange: [new Date(2017, 5, 1), new Date(2017, 5, 6)] }]);
1060+
expect(calendar.disabledDates)
1061+
.toEqual([{ type: DateRangeType.Between, dateRange: [new Date(2017, 5, 23), new Date(2017, 5, 29)] }]);
10611062
let specialDates = calendar.daysView.dates.toArray().filter(d => {
10621063
const dateTime = getDate(d).getTime();
10631064
return (dateTime >= new Date(2017, 5, 1).getTime() &&
@@ -1080,13 +1081,13 @@ describe('IgxCalendar', () => {
10801081
});
10811082

10821083
// change Inputs
1083-
fixture.componentInstance.disabledDates = [{type: DateRangeType.Before, dateRange: [new Date(2017, 5, 10)]}];
1084-
fixture.componentInstance.specialDates = [{type: DateRangeType.After, dateRange: [new Date(2017, 5, 19)]}];
1084+
fixture.componentInstance.disabledDates = [{ type: DateRangeType.Before, dateRange: [new Date(2017, 5, 10)] }];
1085+
fixture.componentInstance.specialDates = [{ type: DateRangeType.After, dateRange: [new Date(2017, 5, 19)] }];
10851086
fixture.detectChanges();
10861087

1087-
expect(calendar.disabledDates).toEqual([{type: DateRangeType.Before, dateRange: [new Date(2017, 5, 10)]}]);
1088-
expect(calendar.specialDates).toEqual([{type: DateRangeType.After, dateRange: [new Date(2017, 5, 19)]}]);
1089-
specialDates = calendar.daysView.dates.toArray().filter(d => {
1088+
expect(calendar.disabledDates).toEqual([{ type: DateRangeType.Before, dateRange: [new Date(2017, 5, 10)] }]);
1089+
expect(calendar.specialDates).toEqual([{ type: DateRangeType.After, dateRange: [new Date(2017, 5, 19)] }]);
1090+
specialDates = calendar.daysView.dates.toArray().filter(d => {
10901091
const dateTime = getDate(d).getTime();
10911092
return (dateTime >= new Date(2017, 5, 20).getTime());
10921093
});
@@ -2068,8 +2069,8 @@ export class IgxCalendaRangeComponent {
20682069
export class IgxCalendarDisabledSpecialDatesComponent {
20692070
public model: Date | Date[] = new Date(2017, 5, 23);
20702071
public viewDate = new Date(2017, 5, 13);
2071-
public specialDates = [{type: DateRangeType.Between, dateRange: [new Date(2017, 5, 1), new Date(2017, 5, 6)]}];
2072-
public disabledDates = [{type: DateRangeType.Between, dateRange: [new Date(2017, 5, 23), new Date(2017, 5, 29)]}];
2072+
public specialDates = [{ type: DateRangeType.Between, dateRange: [new Date(2017, 5, 1), new Date(2017, 5, 6)] }];
2073+
public disabledDates = [{ type: DateRangeType.Between, dateRange: [new Date(2017, 5, 23), new Date(2017, 5, 29)] }];
20732074
@ViewChild(IgxCalendarComponent, { static: true }) public calendar: IgxCalendarComponent;
20742075
}
20752076

0 commit comments

Comments
 (0)