chore(combo): Moving the disableFiltering property to combo.common

Author: Ivan Kitanov

CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes for each version of this project will be documented in this
 
 ## 19.2.0
 
+### New Features
+- `IgxSimpleCombo`
+    - Added `disableFiltering` to the `IgxSimpleCombo`, which enables/disables the filtering in the list. The default is `false`.
+
 ### General
 - `IgxCarousel`
     - Removed deprecated property `keyboardSupport`.

projects/igniteui-angular/src/lib/combo/combo.common.ts

@@ -123,6 +123,18 @@ export abstract class IgxComboBaseDirective implements IgxComboBase, AfterViewCh
     @Input({ transform: booleanAttribute })
     public showSearchCaseIcon = false;
 
+     /**
+     * Enables/disables filtering in the list. The default is `false`.
+     */
+    @Input({ transform: booleanAttribute })
+    public get disableFiltering(): boolean {
+        return this._disableFiltering;
+    }
+    public set disableFiltering(value: boolean) {
+        this._disableFiltering = value;
+    }
+
+
     /**
      * Set custom overlay settings that control how the combo's list of items is displayed.
      * Set:
@@ -945,6 +957,7 @@ export abstract class IgxComboBaseDirective implements IgxComboBase, AfterViewCh
     protected computedStyles;
 
     private _id: string = `igx-combo-${NEXT_ID++}`;
+    private _disableFiltering = false;
     private _type = null;
     private _dataType = '';
     private _itemHeight = undefined;

projects/igniteui-angular/src/lib/combo/combo.component.ts

@@ -128,17 +128,6 @@ export class IgxComboComponent extends IgxComboBaseDirective implements AfterVie
     @Input({ transform: booleanAttribute })
     public autoFocusSearch = true;
 
-    /**
-     * Enables/disables filtering in the list. The default is `false`.
-     */
-    @Input({ transform: booleanAttribute })
-    public get disableFiltering(): boolean {
-        return this._disableFiltering || this.filteringOptions.filterable === false;
-    }
-    public set disableFiltering(value: boolean) {
-        this._disableFiltering = value;
-    }
-
     /**
      * Defines the placeholder value for the combo dropdown search field
      *
@@ -184,7 +173,6 @@ export class IgxComboComponent extends IgxComboBaseDirective implements AfterVie
     protected _prevInputValue = '';
 
     private _displayText: string;
-    private _disableFiltering = false;
 
     constructor(
         elementRef: ElementRef,

projects/igniteui-angular/src/lib/simple-combo/simple-combo.component.html

@@ -68,7 +68,7 @@
         (focus)="dropdown.onFocus()" (keydown)="handleItemKeyDown($event)">
         <igx-combo-item [role]="item?.isHeader? 'group' : 'option'" [singleMode]="true"
             [itemHeight]="itemHeight" (click)="handleItemClick()" *igxFor="let item of data
-                | comboFiltering:filterValue:displayKey:filteringOptions:filterFunction
+                | comboFiltering:filterValue:displayKey:filteringOptions:filterFunction:disableFiltering
                 | comboGrouping:groupKey:valueKey:groupSortingDirection:compareCollator;
                 index as rowIndex; initialChunkSize: 10; containerSize: itemsMaxHeight || containerSize; itemSize: itemHeight || itemSize; scrollOrientation: 'vertical';"
                 [value]="item" [isHeader]="item?.isHeader" [index]="rowIndex">

projects/igniteui-angular/src/lib/simple-combo/simple-combo.component.ts

@@ -115,19 +115,6 @@ export class IgxSimpleComboComponent extends IgxComboBaseDirective implements Co
 
     private _collapsing = false;
 
-    private _disableFiltering = false;
-
-    /**
-     * Enables/disables filtering in the list. The default is `false`.
-     */
-    @Input({ transform: booleanAttribute })
-    public get disableFiltering(): boolean {
-        return this._disableFiltering;
-    }
-    public set disableFiltering(value: boolean) {
-        this._disableFiltering = value;
-    }
-
     /** @hidden @internal */
     public get filteredData(): any[] | null {
         return this._filteredData;