refactor(grids): initial cleanup of ctor props left as public (#12998)

Author: damyanpetev

projects/igniteui-angular/src/lib/grids/common/grid.interface.ts

@@ -331,7 +331,7 @@ export interface GridType extends IGridDataBindable {
     isLoading: boolean;
     dataCloneStrategy: IDataCloneStrategy;
 
-    gridAPI: GridServiceType;
+    readonly gridAPI: GridServiceType;
 
     filterMode: FilterMode;
 
@@ -357,14 +357,17 @@ export interface GridType extends IGridDataBindable {
     paginatorList?: QueryList<IgxPaginatorComponent>;
     /** @hidden @internal */
     crudService: any;
+    /** @hidden @internal */
     summaryService: any;
 
 
 
     virtualizationState: IForOfState;
     // TYPE
+    /** @hidden @internal */
     selectionService: any;
     navigation: any;
+    /** @hidden @internal */
     filteringService: any;
     outlet: any;
     /** @hidden @internal */
@@ -452,8 +455,8 @@ export interface GridType extends IGridDataBindable {
     _filteredSortedUnpinnedData: any[];
     filteredSortedData: any[];
     dataWithAddedInTransactionRows: any[];
-    transactions: TransactionService<Transaction, State>;
-    validation: IgxGridValidationService;
+    readonly transactions: TransactionService<Transaction, State>;
+    readonly validation: IgxGridValidationService;
     defaultSummaryHeight: number;
     summaryRowHeight: number;
     rowEditingOverlay: IgxToggleDirective;
@@ -486,7 +489,8 @@ export interface GridType extends IGridDataBindable {
     uniqueColumnValuesStrategy: (column: ColumnType, tree: FilteringExpressionsTree, done: (values: any[]) => void) => void;
     getHeaderCellWidth: (element: HTMLElement) => ISizeInfo;
 
-    cdr: ChangeDetectorRef;
+    readonly cdr: ChangeDetectorRef;
+    /** @hidden @internal */
     document: Document;
     rowExpandedIndicatorTemplate: TemplateRef<IgxGridRowTemplateContext>;
     rowCollapsedIndicatorTemplate: TemplateRef<IgxGridRowTemplateContext>;

projects/igniteui-angular/src/lib/grids/grid-base.directive.ts

@@ -3420,23 +3420,27 @@ export abstract class IgxGridBaseDirective extends DisplayDensityBase implements
     }
 
     constructor(
-        public validation: IgxGridValidationService,
-        public selectionService: IgxGridSelectionService,
-        public colResizingService: IgxColumnResizingService,
-        @Inject(IGX_GRID_SERVICE_BASE) public gridAPI: GridServiceType,
+        public readonly validation: IgxGridValidationService,
+        /** @hidden @internal */
+        public readonly selectionService: IgxGridSelectionService,
+        protected colResizingService: IgxColumnResizingService,
+        @Inject(IGX_GRID_SERVICE_BASE) public readonly gridAPI: GridServiceType,
         protected transactionFactory: IgxFlatTransactionFactory,
         private elementRef: ElementRef<HTMLElement>,
         protected zone: NgZone,
+        /** @hidden @internal */
         @Inject(DOCUMENT) public document: any,
-        public cdr: ChangeDetectorRef,
+        public readonly cdr: ChangeDetectorRef,
         protected differs: IterableDiffers,
         protected viewRef: ViewContainerRef,
         private appRef: ApplicationRef,
         protected injector: Injector,
         protected envInjector: EnvironmentInjector,
         public navigation: IgxGridNavigationService,
+        /** @hidden @internal */
         public filteringService: IgxFilteringService,
         @Inject(IgxOverlayService) protected overlayService: IgxOverlayService,
+        /** @hidden @internal */
         public summaryService: IgxGridSummaryService,
         @Optional() @Inject(DisplayDensityToken) protected _displayDensityOptions: IDisplayDensityOptions,
         @Inject(LOCALE_ID) private localeId: string,

projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-grid.component.ts

@@ -172,7 +172,7 @@ export class IgxChildGridRowComponent implements AfterViewInit, OnInit {
     public expanded = false;
 
     constructor(
-        @Inject(IGX_GRID_SERVICE_BASE) public gridAPI: IgxHierarchicalGridAPIService,
+        @Inject(IGX_GRID_SERVICE_BASE) public readonly gridAPI: IgxHierarchicalGridAPIService,
         public element: ElementRef<HTMLElement>,
         public cdr: ChangeDetectorRef) { }