Merge branch 'master' into dkamburov/fix-5598

Author: ChronosSF

.github/CONTRIBUTING.md

@@ -56,7 +56,11 @@ When logging issue you should assign `severity:` label. If you cannot determine
 
 ### Triaging
 
-Before release a triaging is done. Issues that need to be fixed for the release are marked with `triage: blocking` status.
+Issues that block other issues completion are marked with `triage: blocking` status.
+
+### Priority
+
+Issues that need to be addressed immediately are marked with `priority: high` status.
 
 ## Testing - applicable to pull requests
 1. `status: awaiting-test` this is the initial status of pull requests. If you're performing the pull request, please place this status on it. Pull requests are accepted if and only if all status checks pass, review is performed, and the pull request has been tested and contains `status: verified`.

CHANGELOG.md

@@ -2,6 +2,35 @@
 
 All notable changes for each version of this project will be documented in this file.
 
+## 8.2.0
+
+### New Features
+- `IgxGrid`, `IgxTreeGrid`, `IgxHierarchicalGrid`
+    - `uniqueColumnValuesStrategy` input is added. This property provides a callback for loading unique column values on demand. If this property is provided, the unique values it generates will be used by the Excel Style Filtering (instead of using the unique values from the data that is bound to the grid).
+    - `igxExcelStyleLoading` directive is added, which can be used to provide a custom loading template for the Excel Style Filtering. If this property is not provided, a default loading template will be used instead.
+### General
+- `IgxGrid`, `IgxTreeGrid`, `IgxHierarchicalGrid`
+    - **Breaking Change** `igxExcelStyleSortingTemplate` directive is renamed to `igxExcelStyleSorting`.
+    - **Breaking Change** `igxExcelStyleMovingTemplate` directive is renamed to `igxExcelStyleMoving`.
+    - **Breaking Change** `igxExcelStyleHidingTemplate` directive is renamed to `igxExcelStyleHiding`.
+    - **Breaking Change** `igxExcelStylePinningTemplate` directive is renamed to `igxExcelStylePinning`.
+
+## 8.1.3
+- `IgxCombo`
+    - Combo `onSelectionChange` events now emits the item(s) that were added to or removed from the collection:
+    ```html
+    <igx-combo (onSelectionChange)="handleChange($event)">
+    ```
+    ```typescript
+        export class Example {
+            ...
+            handleChange(event: IComboSelectionChangeEventArgs) {
+            console.log("Items added: ", [...event.added]); // the items added to the selection in this change
+            console.log("Items removed: ", [...event.removed]); // the items removed from the selection in this change
+            }
+        }
+    ```
+
 ## 8.1.2
 
 ### New Features

projects/igniteui-angular/migrations/migration-collection.json

@@ -45,6 +45,11 @@
             "version": "7.3.4",
             "description": "Updates Ignite UI for Angular from v7.2.0 to v7.3.4",
             "factory": "./update-7_3_4"
+        },
+        "migration-10": {
+            "version": "8.2.0",
+            "description": "Updates Ignite UI for Angular from v8.1.x to v8.2.0",
+            "factory": "./update-8_2_0"
         }
     }
 }

projects/igniteui-angular/migrations/update-8_2_0/changes/selectors.json

@@ -0,0 +1,25 @@
+{
+    "$schema": "../../common/schema/selector.schema.json",
+    "changes": [
+        {
+            "type": "directive",
+            "selector": "igxExcelStyleSortingTemplate",
+            "replaceWith": "igxExcelStyleSorting"
+        },
+        {
+            "type": "directive",
+            "selector": "igxExcelStyleMovingTemplate",
+            "replaceWith": "igxExcelStyleMoving"
+        },
+        {
+            "type": "directive",
+            "selector": "igxExcelStyleHidingTemplate",
+            "replaceWith": "igxExcelStyleHiding"
+        },
+        {
+            "type": "directive",
+            "selector": "igxExcelStylePinningTemplate",
+            "replaceWith": "igxExcelStylePinning"
+        }
+    ]
+}

projects/igniteui-angular/migrations/update-8_2_0/index.spec.ts

@@ -0,0 +1,53 @@
+import * as path from 'path';
+
+// tslint:disable:no-implicit-dependencies
+import { virtualFs } from '@angular-devkit/core';
+import { EmptyTree } from '@angular-devkit/schematics';
+// tslint:disable-next-line:no-submodule-imports
+import { SchematicTestRunner, UnitTestTree } from '@angular-devkit/schematics/testing';
+
+describe('Update 8.2.0', () => {
+    let appTree: UnitTestTree;
+    const schematicRunner = new SchematicTestRunner('ig-migrate', path.join(__dirname, '../migration-collection.json'));
+    const configJson = {
+        defaultProject: 'testProj',
+        projects: {
+            testProj: {
+                sourceRoot: '/testSrc'
+            }
+        },
+        schematics: {
+            '@schematics/angular:component': {
+                prefix: 'appPrefix'
+            }
+        }
+      };
+
+    beforeEach(() => {
+        appTree = new UnitTestTree(new EmptyTree());
+        appTree.create('/angular.json', JSON.stringify(configJson));
+    });
+
+    it('should update Excel Style Filtering template selectors', done => {
+        appTree.create(
+            '/testSrc/appPrefix/component/custom.component.html',
+            `<igx-grid [data]="data" height="500px" [autoGenerate]="true" [allowFiltering]='true' [filterMode]="'excelStyleFilter'">
+                <ng-template igxExcelStyleSortingTemplate><div class="esf-custom-sorting">Sorting Template</div></ng-template>
+                <ng-template igxExcelStyleHidingTemplate><div class="esf-custom-hiding">Hiding Template</div></ng-template>
+                <ng-template igxExcelStyleMovingTemplate><div class="esf-custom-moving">Moving Template</div></ng-template>
+                <ng-template igxExcelStylePinningTemplate><div class="esf-custom-pinning">Pinning Template</div></ng-template>
+            </igx-grid>`);
+
+        const tree = schematicRunner.runSchematic('migration-10', {}, appTree);
+        expect(tree.readContent('/testSrc/appPrefix/component/custom.component.html'))
+            .toEqual(
+            `<igx-grid [data]="data" height="500px" [autoGenerate]="true" [allowFiltering]='true' [filterMode]="'excelStyleFilter'">
+                <ng-template igxExcelStyleSorting><div class="esf-custom-sorting">Sorting Template</div></ng-template>
+                <ng-template igxExcelStyleHiding><div class="esf-custom-hiding">Hiding Template</div></ng-template>
+                <ng-template igxExcelStyleMoving><div class="esf-custom-moving">Moving Template</div></ng-template>
+                <ng-template igxExcelStylePinning><div class="esf-custom-pinning">Pinning Template</div></ng-template>
+            </igx-grid>`);
+
+        done();
+    });
+});

projects/igniteui-angular/migrations/update-8_2_0/index.ts

@@ -0,0 +1,17 @@
+import {
+    Rule,
+    SchematicContext,    
+    Tree
+} from '@angular-devkit/schematics';
+import { UpdateChanges } from '../common/UpdateChanges';
+
+const version = '8.2.0';
+
+export default function(): Rule {
+    return (host: Tree, context: SchematicContext) => {
+        context.logger.info(`Applying migration for Ignite UI for Angular to version ${version}`);
+
+        const update = new UpdateChanges(__dirname, host, context);
+        update.applyChanges();
+    };
+}

projects/igniteui-angular/src/lib/banner/banner.component.ts

@@ -47,13 +47,13 @@ export class IgxBannerComponent implements IToggleView {
     @ViewChild('expansionPanel', { static: true })
     private _expansionPanel: IgxExpansionPanelComponent;
 
-    @ContentChild(IgxBannerActionsDirective, { static: true })
+    @ContentChild(IgxBannerActionsDirective, { static: false })
     private _bannerActionTemplate: IgxBannerActionsDirective;
 
     /**
      * @hidden
      */
-    @ContentChild(IgxIconComponent, { static: true })
+    @ContentChild(IgxIconComponent, { static: false })
     public bannerIcon: IgxIconComponent;
 
     /**

projects/igniteui-angular/src/lib/chips/chip.component.ts

@@ -19,7 +19,7 @@ import {
     IDragStartEventArgs,
     IgxDropEnterEventArgs,
     IgxDropEventArgs
-} from '../directives/dragdrop/dragdrop.directive';
+} from '../directives/drag-drop/drag-drop.directive';
 
 
 export interface IBaseChipEventArgs {

projects/igniteui-angular/src/lib/chips/chips-area.component.ts

@@ -23,7 +23,7 @@ import {
 } from './chip.component';
 import {
     IgxDropEnterEventArgs
-} from '../directives/dragdrop/dragdrop.directive';
+} from '../directives/drag-drop/drag-drop.directive';
 import { takeUntil } from 'rxjs/operators';
 import { Subject } from 'rxjs/internal/Subject';
 

projects/igniteui-angular/src/lib/chips/chips.module.ts

@@ -6,7 +6,7 @@ import { IgxAvatarModule } from '../avatar/avatar.component';
 import { IgxIconModule } from '../icon/index';
 import { IgxChipComponent } from './chip.component';
 import { IgxChipsAreaComponent } from './chips-area.component';
-import { IgxDragDropModule } from '../directives/dragdrop/dragdrop.directive';
+import { IgxDragDropModule } from '../directives/drag-drop/drag-drop.directive';
 import { IgxPrefixModule, IgxPrefixDirective} from '../directives/prefix/prefix.directive';
 import { IgxSuffixModule, IgxSuffixDirective } from '../directives/suffix/suffix.directive';