Skip to content

Commit e474a16

Browse files
committed
fix(slider): emit onchange callback correctly
Closes #7523
1 parent 1d495d4 commit e474a16

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

projects/igniteui-angular/src/lib/slider/slider.component.ts

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -625,8 +625,6 @@ export class IgxSliderComponent implements
625625
} else {
626626
this._value = value;
627627
}
628-
629-
this._onChangeCallback(value);
630628
}
631629

632630
/**
@@ -1420,13 +1418,24 @@ export class IgxSliderComponent implements
14201418
public setValue(value: number | IRangeSliderValue) {
14211419
if (!this.isRange) {
14221420
this.upperValue = value as number - (value as number % this.step);
1421+
this._onChangeCallback(this.upperValue);
14231422
} else {
14241423
value = this.validateInitialValue(value as IRangeSliderValue);
14251424
this.upperValue = (value as IRangeSliderValue).upper;
14261425
this.lowerValue = (value as IRangeSliderValue).lower;
1426+
this._onChangeCallback({lower: this.lowerValue, upper: this.upperValue});
14271427
}
1428+
1429+
// this.executeOnChange();
14281430
}
14291431

1432+
// private executeOnChange() {
1433+
// if (this.isRange) {
1434+
// } else {
1435+
1436+
// }
1437+
// }
1438+
14301439
private emitValueChanged(oldValue: number | IRangeSliderValue) {
14311440
this.onValueChange.emit({ oldValue, value: this.value });
14321441
}

0 commit comments

Comments
 (0)