Skip to content

Commit e564acb

Browse files
committed
fix(combo): add owner to event args #7282
1 parent a71a892 commit e564acb

File tree

3 files changed

+3
-1
lines changed

3 files changed

+3
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ All notable changes for each version of this project will be documented in this
77
### General
88
- `igxCombo`
99
- **Behavioral Change** - Change default positioning strategy from `ConnectedPositioningStrategy` to `AutoPositionStrategy`. The [`Auto`](https://www.infragistics.com/products/ignite-ui-angular/angular/components/overlay_position.html#auto) strategy will initially try to show the element like the Connected strategy does. If the element goes out of the viewport Auto will flip the starting point and the direction, i.e. if the direction is 'bottom', it will switch it to 'top' and so on. If after flipping direction the content goes out of the view, auto strategy will revert to initial start point and direction and will push the content into the view. Note after pushing the content it may hide the combo's input.
10-
- Make `onSearchInput` event cancellable. The event args type has been changed to `IComboSearchInputEventArgs`, which have the following properties: `searchText` - holds the text typed into the search input and `cancel` - indicates whether the event should be canceled.
10+
- Make `onSearchInput` event cancellable. The event args type has been changed to `IComboSearchInputEventArgs`, which have the following properties: `searchText` - holds the text typed into the search input, `owner` - holds a reference to the combo component and `cancel` - indicates whether the event should be canceled.
1111
- `IgxOverlay`
1212
- Added new property - `closeOnEsc` - in `OverlaySettings`. The overlay can now be prevented from closing, on escape keypress, by setting the property to `false`, by default it's `true`.
1313
- `igxDialog`

projects/igniteui-angular/src/lib/combo/combo.component.spec.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -533,6 +533,7 @@ describe('igxCombo', () => {
533533

534534
const args = {
535535
searchText: 'Fake',
536+
owner: combo,
536537
cancel: false
537538
};
538539
combo.handleInputChange('Fake');

projects/igniteui-angular/src/lib/combo/combo.component.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -989,6 +989,7 @@ export class IgxComboComponent extends DisplayDensityBase implements IgxComboBas
989989
if (event !== undefined) {
990990
const args: IComboSearchInputEventArgs = {
991991
searchText: event,
992+
owner: this,
992993
cancel: false
993994
};
994995
this.onSearchInput.emit(args);

0 commit comments

Comments
 (0)