Skip to content

Commit e6cfdf0

Browse files
committed
fix(date-time-editor): reverting a .toString() change by copilot
1 parent fab4e57 commit e6cfdf0

File tree

3 files changed

+7
-17
lines changed

3 files changed

+7
-17
lines changed

projects/igniteui-angular/directives/src/directives/date-time-editor/date-time-editor.directive.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -403,8 +403,8 @@ export class IgxDateTimeEditorDirective extends IgxMaskDirective implements OnCh
403403

404404
let errors = {};
405405
const value = DateTimeUtil.isValidDate(control.value) ? control.value : DateTimeUtil.parseIsoDate(control.value);
406-
const minValueDate = DateTimeUtil.isValidDate(this.minValue) ? this.minValue : this.parseDate(this.minValue.toString());
407-
const maxValueDate = DateTimeUtil.isValidDate(this.maxValue) ? this.maxValue : this.parseDate(this.maxValue.toString());
406+
const minValueDate = DateTimeUtil.isValidDate(this.minValue) ? this.minValue : this.parseDate(this.minValue);
407+
const maxValueDate = DateTimeUtil.isValidDate(this.maxValue) ? this.maxValue : this.parseDate(this.maxValue);
408408
if (minValueDate || maxValueDate) {
409409
errors = DateTimeUtil.validateMinMax(value,
410410
minValueDate, maxValueDate,
@@ -600,8 +600,8 @@ export class IgxDateTimeEditorDirective extends IgxMaskDirective implements OnCh
600600
}
601601

602602
let errors = {};
603-
const minValueDate = DateTimeUtil.isValidDate(this.minValue) ? this.minValue : this.parseDate(this.minValue.toString());
604-
const maxValueDate = DateTimeUtil.isValidDate(this.maxValue) ? this.maxValue : this.parseDate(this.maxValue.toString());
603+
const minValueDate = DateTimeUtil.isValidDate(this.minValue) ? this.minValue : this.parseDate(this.minValue);
604+
const maxValueDate = DateTimeUtil.isValidDate(this.maxValue) ? this.maxValue : this.parseDate(this.maxValue);
605605
if (minValueDate || maxValueDate) {
606606
errors = DateTimeUtil.validateMinMax(value,
607607
this.minValue, this.maxValue,

projects/igniteui-angular/test-utils/controls-functions.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { By } from '@angular/platform-browser';
22
import { DebugElement } from '@angular/core';
33
import { ComponentFixture } from '@angular/core/testing';
44
import { UIInteractions } from './ui-interactions.spec';
5-
import { IgxCheckboxComponent } from '../checkbox/src/checkbox/checkbox.component';
5+
import { IgxCheckboxComponent } from 'igniteui-angular/checkbox';
66

77
const CHIP_REMOVE_BUTTON = '.igx-chip__remove';
88
const DROP_DOWN_SELECTED_ITEM_CLASS = '.igx-drop-down__item--selected';

projects/igniteui-angular/test-utils/grid-base-components.spec.ts

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,8 @@
11
import { Component, OnInit, ViewChild, AfterViewInit, ChangeDetectorRef } from '@angular/core';
22
import { SampleTestData } from './sample-test-data.spec';
33
import { ColumnDefinitions, GridTemplateStrings } from './template-strings.spec';
4-
import { IgxGridComponent } from '../grids/src/grids/grid/grid.component';
5-
import { IgxColumnActionsComponent } from '../grids/src/grids/column-actions/column-actions.component';
6-
import { IgxColumnComponent } from '../grids/src/grids/columns/column.component';
7-
import { IgxGridToolbarComponent } from '../grids/src/grids/toolbar/grid-toolbar.component';
8-
import { IgxGridToolbarHidingComponent } from '../grids/src/grids/toolbar/grid-toolbar-hiding.component';
9-
import { IgxGridToolbarActionsComponent } from '../grids/src/grids/toolbar/common';
10-
import { IgxPaginatorComponent } from '../paginator/src/paginator/paginator.component';
11-
import { IgxColumnGroupComponent } from '../grids/src/grids/columns/column-group.component';
12-
import { IgxGridToolbarPinningComponent } from '../grids/src/grids/toolbar/grid-toolbar-pinning.component';
13-
import { IgxCellTemplateDirective } from '../grids/src/grids/columns/templates.directive';
14-
import { IgxColumnHidingDirective } from '../grids/src/grids/column-actions/column-hiding.directive';
15-
import { IgxColumnPinningDirective } from '../grids/src/grids/column-actions/column-pinning.directive';
4+
import { IgxCellTemplateDirective, IgxColumnActionsComponent, IgxColumnComponent, IgxColumnGroupComponent, IgxColumnHidingDirective, IgxColumnPinningDirective, IgxGridComponent, IgxGridToolbarActionsComponent, IgxGridToolbarComponent, IgxGridToolbarHidingComponent, IgxGridToolbarPinningComponent } from 'igniteui-angular/grids';
5+
import { IgxPaginatorComponent } from 'igniteui-angular/paginator';
166

177
@Component({
188
template: `

0 commit comments

Comments
 (0)