Merge pull request #10427 from IgniteUI/mevtimov/fix-10365-master

Remove deprecateDecorators

Author: Lipata

.github/CONTRIBUTING.md

@@ -170,17 +170,27 @@ Write migrations.
 
 ## Deprecating methods
 When a method is deprecated a few steps have to be done:
-1. Add deprecation warning message by decorating the method with `@DeprecateMethod` decorator from `deprecateDecorators.ts` file.
+1. Add the `@deprecated` tag at the begging of the method description followed by the version in which the method has been deprecated and what can be used instead. Example:
+```ts
+/**
+ * @deprecated in version 12.1.0. Use 'data' instead
+ *
+ * The data record that populates the row
+ */
+public getRowData(): any {
+    return this.data;
+}
+```
 2. Ensure that the deprecated method is no longer used in IgniteUI for Angular codebase, samples and documentation snippets.
 3. Write migrations.
 
 ## Deprecating class properties
 When a class property is deprecated a few steps have to be done:
-1. Add deprecation warning message by decorating the property with `@DeprecateProperty` decorator from `deprecateDecorators.ts` file.
+1. Add the `@deprecated` tag at the begging of the property description followed by the version in which the property has been deprecated and what can be used instead.
 2. Ensure that the deprecated property is no longer used in IgniteUI for Angular codebase, samples and documentation snippets.
 3. Write migrations.
 
-NOTE: TypeScript disallows decorating both the get and set accessor for a single member. Instead, all decorators for the member must be applied to the first accessor specified in document order. This is because decorators apply to a Property Descriptor, which combines both the get and set accessor, not each declaration separately.
+NOTE: TypeScript disallows adding descriptions to both the get and set accessor for a single member. Instead, the description for the member must be applied to the first accessor specified in document order. Having this in mind the `@deprecated` tag is applied only once.
 
 # Testing a PR
 In order to test a pull request that is awaiting test, perform the following actions.

projects/igniteui-angular/migrations/common/filterSourceDirs.ts

@@ -2,9 +2,9 @@ import { filter, Rule, SchematicContext, Tree } from '@angular-devkit/schematics
 import { getWorkspace, getWorkspacePath, getProjectPaths } from './util';
 
 /**
- * Filter tree to project source dirs
- *
  * @deprecated Temporary
+ *
+ * Filter tree to project source dirs
  */
 export const filterSourceDirs = (host: Tree, context: SchematicContext): Rule => {
     const configPath = getWorkspacePath(host);

projects/igniteui-angular/src/lib/action-strip/grid-actions/grid-editing-actions.component.ts

@@ -1,6 +1,6 @@
 import { Component, HostBinding, Input } from '@angular/core';
 import { IgxGridActionsBaseDirective } from './grid-actions-base.directive';
-import { showMessage } from '../../core/deprecateDecorators';
+import { showMessage } from '../../core/utils';
 import { addRow, addChild  } from '@igniteui/material-icons-extended';
 
 @Component({

projects/igniteui-angular/src/lib/banner/banner.component.ts

@@ -13,8 +13,7 @@ import { ToggleAnimationSettings } from '../expansion-panel/toggle-animation-com
 
 export interface BannerEventArgs extends IBaseEventArgs {
     /**
-     * @deprecated
-     * To get a reference to the banner, use `owner` instead.
+     * @deprecated in 12.1.0. To get a reference to the banner, use `owner` instead
      */
     banner: IgxBannerComponent;
     event?: Event;

projects/igniteui-angular/src/lib/core/deprecateDecorators.ts

@@ -25,6 +25,18 @@ import {
     swingOutLefttFwd, swingOutRightBck, swingOutRightFwd, swingOutTopBck, swingOutTopFwd
 } from '../animations/main';
 import { setImmediate } from './setImmediate';
+import { isDevMode } from '@angular/core';
+
+/**
+ * @hidden
+ */
+export const showMessage = (message: string, isMessageShown: boolean): boolean => {
+    if (!isMessageShown && isDevMode()) {
+        console.warn(message);
+    }
+
+    return true;
+};
 
 export const mkenum = <T extends { [index: string]: U }, U extends string>(x: T) => x;
 

projects/igniteui-angular/src/lib/core/utils.ts

@@ -16,7 +16,6 @@ import { IgxRippleModule } from '../ripple/ripple.directive';
 import { takeUntil } from 'rxjs/operators';
 import { noop, Subject } from 'rxjs';
 import { mkenum } from '../../core/utils';
-import { DeprecateProperty } from '../../core/deprecateDecorators';
 
 /**
  * Determines the Radio Group alignment
@@ -129,16 +128,15 @@ export class IgxRadioGroupDirective implements AfterContentInit, ControlValueAcc
     }
 
     /**
-     * An @Input property that allows you to disable the radio group. By default it's false.
-     *
      * @deprecated in version 12.2.0
      *
+     * An input property that allows you to disable the radio group. By default it's false.
+     *
      * @example
      *  ```html
      * <igx-radio-group disabled></igx-radio-group>
      * ```
      */
-    @DeprecateProperty('`disabled` is deprecated.')
     @Input()
     public get disabled(): boolean {
         return this._disabled;
@@ -149,10 +147,10 @@ export class IgxRadioGroupDirective implements AfterContentInit, ControlValueAcc
     }
 
     /**
-     * Sets/gets the position of the `label` in the child radio buttons.
-     *
      * @deprecated in version 12.2.0
      *
+     * Sets/gets the position of the `label` in the child radio buttons.
+     *
      * @remarks
      * If not set, `labelPosition` will have value `"after"`.
      *
@@ -161,7 +159,6 @@ export class IgxRadioGroupDirective implements AfterContentInit, ControlValueAcc
      * <igx-radio-group labelPosition = "before"></igx-radio-group>
      * ```
      */
-    @DeprecateProperty('`labelPosition` is deprecated.')
     @Input()
     public get labelPosition(): RadioLabelPosition | string {
         return this._labelPosition;

projects/igniteui-angular/src/lib/directives/radio/radio-group.directive.ts

@@ -1,11 +1,9 @@
 import { IDropDownBase, IGX_DROPDOWN_BASE } from './drop-down.common';
 import { Directive, Input, HostBinding, HostListener, ElementRef, Optional, Inject, DoCheck, Output, EventEmitter } from '@angular/core';
 import { IgxSelectionAPIService } from '../core/selection';
-import { showMessage } from '../core/deprecateDecorators';
 import { IgxDropDownGroupComponent } from './drop-down-group.component';
 
 let NEXT_ID = 0;
-let warningShown = false;
 
 /**
  * An abstract class defining a drop-down item:
@@ -57,10 +55,6 @@ export class IgxDropDownItemBaseDirective implements DoCheck {
     @Input()
     public get index(): number {
         if (this._index === null) {
-            warningShown = showMessage(
-                'IgxDropDownItemBaseDirective: Automatic index is deprecated.' +
-                'Bind in the template instead using `<igx-drop-down-item [index]="i"` instead.`',
-                warningShown);
             return this.itemIndex;
         }
         return this._index;

projects/igniteui-angular/src/lib/drop-down/drop-down-item.base.ts

@@ -19,7 +19,6 @@ import { GridBaseAPIService } from './api.service';
 import { PlatformUtil } from '../core/utils';
 import { IgxGridBaseDirective } from './grid-base.directive';
 import { IgxGridSelectionService, ISelectionNode } from './selection/selection.service';
-import { DeprecateMethod } from '../core/deprecateDecorators';
 import { HammerGesturesManager } from '../core/touch';
 import { ColumnType } from './common/column.interface';
 import { RowType } from './common/row.interface';
@@ -662,19 +661,6 @@ export class IgxGridCellComponent implements OnInit, OnChanges, OnDestroy {
         private touchManager: HammerGesturesManager,
         protected platformUtil: PlatformUtil) { }
 
-    /**
-     * @deprecated
-     * Gets whether the cell is selected.
-     * ```typescript
-     * let isCellSelected = thid.cell.isCellSelected();
-     * ```
-     * @memberof IgxGridCellComponent
-     */
-    @DeprecateMethod(`'isCellSelected' is deprecated. Use 'selected' property instead.`)
-    public isCellSelected() {
-        return this.selectionService.selected(this.selectionNode);
-    }
-
     /**
      * @hidden
      * @internal