Skip to content

Commit e832bc3

Browse files
simeonoffChronosSF
andauthored
themes(*): improve compatibility with WC (#12203)
* deps(theming): bump version * refactor(scrollbar): rename .igx-scrollbar to .ig-scrollbar * refactor(demo): revert back to material theme * feat(themes): config removal of global CSS variables * themes(scrollbar): bring in line with webc Co-authored-by: Stamen Stoychev <[email protected]>
1 parent bb9019c commit e832bc3

File tree

11 files changed

+46
-30
lines changed

11 files changed

+46
-30
lines changed

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@
115115
"hammer-simulator": "0.0.1",
116116
"ig-typedoc-theme": "^4.1.0",
117117
"igniteui-sassdoc-theme": "^1.1.4",
118-
"igniteui-theming": "^1.0.0-release",
118+
"igniteui-theming": "^1.0.2",
119119
"igniteui-webcomponents": "^3.3.0",
120120
"jasmine": "^4.4.0",
121121
"jasmine-core": "~4.4.0",

projects/igniteui-angular/src/lib/core/styles/base/_variables.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
/// The global component registry map.
88
/// @type List
9-
$components: () !default;
9+
$components: (palette: 'palette', elevations: 'elevations') !default;
1010

1111
/// Stores a list of dropped component themes.
1212
$dropped-themes: () !default;

projects/igniteui-angular/src/lib/core/styles/components/scrollbar/scrollbar-component.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
////
1111

1212
@mixin component {
13-
@include b(igx-scrollbar) {
13+
@include b(ig-scrollbar) {
1414
// Register the component in the component registry
1515
$this: bem--selector-to-string(&);
1616
@include register-component(

projects/igniteui-angular/src/lib/core/styles/components/scrollbar/scrollbar-theme.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@
2828
$thumb-background: null,
2929
$track-background: null,
3030
) {
31-
$name: 'igx-scrollbar';
32-
$selector: '.igx-scrollbar';
31+
$name: 'ig-scrollbar';
32+
$selector: '.ig-scrollbar';
3333
$scrollbar-schema: ();
3434

3535
@if map.has-key($schema, $name) {

projects/igniteui-angular/src/lib/core/styles/themes/generators/_base.scss

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,14 @@
3131
$excluded: ();
3232
$scope: if(is-root(), ':root', '&');
3333

34-
@include palette($palette);
35-
@include elevations($elevations);
34+
35+
@if not(list.index($exclude, 'palette')) {
36+
@include palette($palette);
37+
}
38+
39+
@if not(list.index($exclude, 'elevations')) {
40+
@include elevations($elevations);
41+
}
3642

3743
@if $elevation == false {
3844
#{$scope} {
@@ -362,7 +368,7 @@
362368
));
363369
}
364370

365-
@if is-used('igx-scrollbar', $exclude) {
371+
@if is-used('ig-scrollbar', $exclude) {
366372
@include scrollbar(scrollbar-theme(
367373
$schema: $schema
368374
));

projects/igniteui-angular/src/lib/core/styles/themes/schemas/dark/_index.scss

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@
118118
/// @property {Map} igx-radio [$dark-radio]
119119
/// @property {Map} igx-ripple [$dark-ripple]
120120
/// @property {Map} igx-query-builder [$dark-query-builder]
121-
/// @property {Map} igx-scrollbar [$dark-scrollbar]
121+
/// @property {Map} ig-scrollbar [$dark-scrollbar]
122122
/// @property {Map} shape-chart [$dark-shape-chart]
123123
/// @property {Map} igx-slider [$dark-slider]
124124
/// @property {Map} igx-snackbar [$dark-snackbar]
@@ -181,7 +181,7 @@ $dark-schema: (
181181
igx-radio: $dark-radio,
182182
igx-ripple: $dark-ripple,
183183
igx-query-builder: $dark-query-builder,
184-
igx-scrollbar: $dark-scrollbar,
184+
ig-scrollbar: $dark-scrollbar,
185185
shape-chart: $dark-shape-chart,
186186
igx-slider: $dark-slider,
187187
igx-snackbar: $dark-snackbar,
@@ -254,7 +254,7 @@ $dark-material-schema: $dark-schema;
254254
/// @property {Map} igx-radio [$dark-fluent-radio],
255255
/// @property {Map} igx-ripple [$dark-fluent-ripple],
256256
/// @property {Map} igx-query-builder [$dark-fluent-query-builder],
257-
/// @property {Map} igx-scrollbar [$dark-fluent-scrollbar],
257+
/// @property {Map} ig-scrollbar [$dark-fluent-scrollbar],
258258
/// @property {Map} shape-chart [$dark-fluent-shape-chart],
259259
/// @property {Map} igx-slider [$dark-fluent-slider],
260260
/// @property {Map} igx-snackbar [$dark-fluent-snackbar],
@@ -317,7 +317,7 @@ $dark-fluent-schema: (
317317
igx-radio: $dark-fluent-radio,
318318
igx-ripple: $dark-fluent-ripple,
319319
igx-query-builder: $dark-fluent-query-builder,
320-
igx-scrollbar: $dark-fluent-scrollbar,
320+
ig-scrollbar: $dark-fluent-scrollbar,
321321
shape-chart: $dark-fluent-shape-chart,
322322
igx-slider: $dark-fluent-slider,
323323
igx-snackbar: $dark-fluent-snackbar,
@@ -385,7 +385,7 @@ $dark-fluent-schema: (
385385
/// @property {Map} igx-radio [$dark-bootstrap-radio],
386386
/// @property {Map} igx-ripple [$dark-bootstrap-ripple],
387387
/// @property {Map} igx-query-builder [$dark-bootstrap-query-builder],
388-
/// @property {Map} igx-scrollbar [$dark-bootstrap-scrollbar],
388+
/// @property {Map} ig-scrollbar [$dark-bootstrap-scrollbar],
389389
/// @property {Map} shape-chart [$dark-bootstrap-shape-chart],
390390
/// @property {Map} igx-slider [$dark-bootstrap-slider],
391391
/// @property {Map} igx-snackbar [$dark-bootstrap-snackbar],
@@ -448,7 +448,7 @@ $dark-bootstrap-schema: (
448448
igx-radio: $dark-bootstrap-radio,
449449
igx-ripple: $dark-bootstrap-ripple,
450450
igx-query-builder: $dark-bootstrap-query-builder,
451-
igx-scrollbar: $dark-bootstrap-scrollbar,
451+
ig-scrollbar: $dark-bootstrap-scrollbar,
452452
shape-chart: $dark-bootstrap-shape-chart,
453453
igx-slider: $dark-bootstrap-slider,
454454
igx-snackbar: $dark-bootstrap-snackbar,
@@ -516,7 +516,7 @@ $dark-bootstrap-schema: (
516516
/// @property {Map} igx-radio [$dark-indigo-radio]
517517
/// @property {Map} igx-ripple [$dark-indigo-ripple]
518518
/// @property {Map} igx-query-builder [$dark-indigo-query-builder]
519-
/// @property {Map} igx-scrollbar [$dark-indigo-scrollbar]
519+
/// @property {Map} ig-scrollbar [$dark-indigo-scrollbar]
520520
/// @property {Map} shape-chart [$dark-indigo-shape-chart]
521521
/// @property {Map} igx-slider [$dark-indigo-slider]
522522
/// @property {Map} igx-snackbar [$dark-indigo-snackbar]
@@ -579,7 +579,7 @@ $dark-indigo-schema: (
579579
igx-radio: $dark-indigo-radio,
580580
igx-ripple: $dark-indigo-ripple,
581581
igx-query-builder: $dark-indigo-query-builder,
582-
igx-scrollbar: $dark-indigo-scrollbar,
582+
ig-scrollbar: $dark-indigo-scrollbar,
583583
shape-chart: $dark-indigo-shape-chart,
584584
igx-slider: $dark-indigo-slider,
585585
igx-snackbar: $dark-indigo-snackbar,

projects/igniteui-angular/src/lib/core/styles/themes/schemas/light/_index.scss

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@
118118
/// @property {Map} igx-query-builder [$light-query-builder]
119119
/// @property {Map} igx-radio [$light-radio]
120120
/// @property {Map} igx-ripple [$light-ripple]
121-
/// @property {Map} igx-scrollbar [$light-scrollbar]
121+
/// @property {Map} ig-scrollbar [$light-scrollbar]
122122
/// @property {Map} shape-chart [$light-shape-chart]
123123
/// @property {Map} igx-slider [$light-slider]
124124
/// @property {Map} igx-snackbar [$light-snackbar]
@@ -182,7 +182,7 @@ $light-schema: (
182182
igx-radio: $light-radio,
183183
igx-ripple: $light-ripple,
184184
shape-chart: $light-shape-chart,
185-
igx-scrollbar: $light-scrollbar,
185+
ig-scrollbar: $light-scrollbar,
186186
igx-slider: $light-slider,
187187
igx-snackbar: $light-snackbar,
188188
sparkline: $light-sparkline,
@@ -256,7 +256,7 @@ $light-fluent-schema: (
256256
igx-ripple: $fluent-ripple,
257257
shape-chart: $fluent-shape-chart,
258258
igx-query-builder: $fluent-query-builder,
259-
igx-scrollbar: $fluent-scrollbar,
259+
ig-scrollbar: $fluent-scrollbar,
260260
igx-slider: $fluent-slider,
261261
igx-snackbar: $fluent-snackbar,
262262
sparkline: $fluent-sparkline,
@@ -325,7 +325,7 @@ $light-bootstrap-schema: (
325325
igx-ripple: $bootstrap-ripple,
326326
igx-query-builder: $bootstrap-query-builder,
327327
shape-chart: $bootstrap-shape-chart,
328-
igx-scrollbar: $bootstrap-scrollbar,
328+
ig-scrollbar: $bootstrap-scrollbar,
329329
igx-slider: $bootstrap-slider,
330330
igx-snackbar: $bootstrap-snackbar,
331331
sparkline: $bootstrap-sparkline,
@@ -394,7 +394,7 @@ $light-indigo-schema: (
394394
shape-chart: $indigo-shape-chart,
395395
igx-ripple: $indigo-ripple,
396396
igx-query-builder: $indigo-query-builder,
397-
igx-scrollbar: $indigo-scrollbar,
397+
ig-scrollbar: $indigo-scrollbar,
398398
igx-slider: $indigo-slider,
399399
igx-snackbar: $indigo-snackbar,
400400
sparkline: $indigo-sparkline,

projects/igniteui-angular/src/lib/core/styles/typography/_typography.scss

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
////
55

66
@use 'sass:map';
7+
@use 'sass:list';
78
@use 'material';
89
@use 'bootstrap';
910
@use 'fluent';
@@ -19,7 +20,12 @@
1920
/// @access public
2021
/// @param {String} $font-family [$material-typeface] - The font family to be used across all typographic elements.
2122
/// @param {Map} $type-scale [$material-type-scale] - A type scale map as produced by type-scale.
22-
@mixin typography($font-family: presets.$material-typeface, $type-scale: presets.$material-type-scale) {
23+
/// @param {Map} $exclude [null] - A list of typography styles to be excluded.
24+
@mixin typography(
25+
$font-family: presets.$material-typeface,
26+
$type-scale: presets.$material-type-scale,
27+
$exclude: null
28+
) {
2329
$variant: map.get(map.get($type-scale, '_meta'), 'variant');
2430

2531
@if is-root() {
@@ -28,7 +34,9 @@
2834
font-size: theming.$browser-context;
2935
line-height: theming.rem(27px);
3036

31-
@include charts.typography($type-scale);
37+
@if not(list.index($exclude, 'charts')) {
38+
@include charts.typography($type-scale);
39+
}
3240

3341
@if ($variant == 'material' or $variant == null) {
3442
@include material.typography();
@@ -48,5 +56,7 @@
4856
}
4957
}
5058

51-
@include theming.typography($font-family, $type-scale);
59+
@if not(list.index($exclude, 'global')) {
60+
@include theming.typography($font-family, $type-scale);
61+
}
5262
}

src/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
<meta name="viewport" content="width=device-width, initial-scale=1">
99
<link rel="icon" type="image/x-icon" href="favicon.ico">
1010
<link rel="stylesheet" href="https://use.fontawesome.com/releases/v5.3.1/css/all.css" integrity="sha384-mzrmE5qonljUremFsqc01SB46JvROS7bZs3IO2EmfFsd15uHvIt+Y8vEf7N7fWAU" crossorigin="anonymous"></head>
11-
<body class="ig-typography igx-scrollbar default-theme">
11+
<body class="ig-typography ig-scrollbar">
1212
<app-root></app-root>
1313
</body>
1414
</html>

0 commit comments

Comments
 (0)