Skip to content

Commit e8985b2

Browse files
chore(overlay): update changelog
1 parent 72505af commit e8985b2

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ All notable changes for each version of this project will be documented in this
77
### General
88
- `igxCombo`
99
- **Behavioral Change** - Change default positioning strategy from `ConnectedPositioningStrategy` to `AutoPositionStrategy`. The [`Auto`](https://www.infragistics.com/products/ignite-ui-angular/angular/components/overlay_position.html#auto) strategy will initially try to show the element like the Connected strategy does. If the element goes out of the viewport Auto will flip the starting point and the direction, i.e. if the direction is 'bottom', it will switch it to 'top' and so on. If after flipping direction the content goes out of the view, auto strategy will revert to initial start point and direction and will push the content into the view. Note after pushing the content it may hide the combo's input.
10-
10+
- `IgxOverlay`
11+
- Added new property - `closeOnEsc` - in `OverlaySettings`. The overlay can now be prevented from closing, on escape keypress, by setting the property to `false`, by default it's `true`.
1112
### New Features
1213
- `IgxGridState` directive
1314
- Added support for expansion states, column selection and row pinning.

projects/igniteui-angular/src/lib/services/overlay/overlay.spec.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -399,7 +399,7 @@ describe('igxOverlay', () => {
399399
expect(overlayInstance.onClosed.emit).toHaveBeenCalledWith({ componentRef: undefined, id: secondCallId });
400400
}));
401401

402-
xit('Should properly set style on position method call - GlobalPosition.', () => {
402+
it('Should properly set style on position method call - GlobalPosition.', () => {
403403
const mockParent = document.createElement('div');
404404
const mockItem = document.createElement('div');
405405
mockParent.appendChild(mockItem);
@@ -1602,7 +1602,7 @@ describe('igxOverlay', () => {
16021602
document.body.removeChild(wrapperElement);
16031603
});
16041604

1605-
xit('Should position component based on element and start point when connected position strategy is used.', () => {
1605+
it('Should position component based on element and start point when connected position strategy is used.', () => {
16061606
const fixture = TestBed.createComponent(TopLeftOffsetComponent);
16071607
fixture.detectChanges();
16081608

@@ -1781,7 +1781,7 @@ describe('igxOverlay', () => {
17811781
expect(wrapperLeft).toEqual(expectedLeft);
17821782
}));
17831783

1784-
xit('Should display each shown component based on the options specified if the component fits into the visible window.',
1784+
it('Should display each shown component based on the options specified if the component fits into the visible window.',
17851785
fakeAsync(() => {
17861786
const fix = TestBed.createComponent(EmptyPageComponent);
17871787
fix.detectChanges();
@@ -1846,7 +1846,7 @@ describe('igxOverlay', () => {
18461846
});
18471847
}));
18481848

1849-
xit(`Should reposition the component and render it correctly in the window, even when the rendering options passed
1849+
it(`Should reposition the component and render it correctly in the window, even when the rendering options passed
18501850
should result in otherwise a partially hidden component. No scrollbars should appear.`,
18511851
fakeAsync(() => {
18521852
const fix = TestBed.createComponent(EmptyPageComponent);
@@ -2252,7 +2252,7 @@ describe('igxOverlay', () => {
22522252
expect(rect.left).toEqual(expectedLeft);
22532253
}));
22542254

2255-
xit('Should display each shown component based on the options specified if the component fits into the visible window.',
2255+
it('Should display each shown component based on the options specified if the component fits into the visible window.',
22562256
fakeAsync(() => {
22572257
const fix = TestBed.createComponent(EmptyPageComponent);
22582258
fix.detectChanges();
@@ -2332,7 +2332,7 @@ describe('igxOverlay', () => {
23322332
});
23332333
}));
23342334

2335-
xit(`Should reposition the component and render it correctly in the window, even when the rendering options passed
2335+
it(`Should reposition the component and render it correctly in the window, even when the rendering options passed
23362336
should result in otherwise a partially hidden component.No scrollbars should appear.`,
23372337
fakeAsync(() => {
23382338
const fix = TestBed.createComponent(EmptyPageComponent);

0 commit comments

Comments
 (0)