Merge branch '19.2.x' into mkirkova/fix-16219-19.2.x

Author: kacheshmarova

.github/workflows/nodejs.yml

@@ -16,7 +16,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [20.x, 22.17.1]
+        node-version: [20.x, 22.x]
 
     steps:
       - name: Checkout
@@ -51,7 +51,7 @@ jobs:
             npm run test:schematics
             npm run test:i18n
         env:
-            NODE_OPTIONS: --max_old_space_size=4096
+            NODE_OPTIONS: --max_old_space_size=4096 ${{ matrix.node-version == '22.x' && '--no-experimental-strip-types' || '' }}
             TZ: America/New_York
       - name: Build i18n & validate output
         run: |

projects/igniteui-angular/src/lib/core/styles/components/grid/_grid-theme.scss

@@ -1253,6 +1253,9 @@
     %grid-display-container-tr {
         width: 100%;
         overflow: visible;
+        flex: 1;
+        // needed to override the min-width of the column headers
+        min-width: 0;
     }
 
     %grid-mrl-block {
@@ -1450,7 +1453,7 @@
         }
 
         padding-block: 0;
-        flex: 1 0 auto;
+        flex: 0 0 auto;
         background: inherit;
         z-index: 4;
         cursor: move;

projects/igniteui-angular/src/lib/directives/focus-trap/focus-trap.directive.spec.ts

@@ -5,6 +5,7 @@ import { IgxFocusTrapDirective } from './focus-trap.directive';
 
 import { NoopAnimationsModule } from '@angular/platform-browser/animations';
 import { UIInteractions } from '../../test-utils/ui-interactions.spec';
+import { IgxTimePickerComponent } from '../../time-picker/time-picker.component';
 
 describe('igxFocusTrap', () => {
     beforeEach(waitForAsync(() => {
@@ -161,6 +162,39 @@ describe('igxFocusTrap', () => {
         fix.detectChanges();
         expect(document.activeElement).toEqual(button.nativeElement);
     }));
+
+    it('should focus only visible focusable elements on Tab key pressed', () => {
+        const fix = TestBed.createComponent(TrapFocusTestComponent);
+        fix.detectChanges();
+
+        fix.componentInstance.showTimePicker = true;
+        fix.detectChanges();
+
+        const focusTrap = fix.debugElement.query(By.directive(IgxFocusTrapDirective));
+        const buttons = fix.debugElement.queryAll(By.css('button'));
+        const inputs = fix.debugElement.queryAll(By.css('input'));
+        const timePickerInput = fix.debugElement.query(By.css('.igx-input-group__input'));
+
+        UIInteractions.triggerEventHandlerKeyDown('Tab', focusTrap);
+        fix.detectChanges();
+        expect(document.activeElement).toEqual(inputs[0].nativeElement);
+
+        UIInteractions.triggerEventHandlerKeyDown('Tab', focusTrap);
+        fix.detectChanges();
+        expect(document.activeElement).toEqual(inputs[1].nativeElement);
+
+        UIInteractions.triggerEventHandlerKeyDown('Tab', focusTrap);
+        fix.detectChanges();
+        expect(document.activeElement).toEqual(timePickerInput.nativeElement);
+
+        UIInteractions.triggerEventHandlerKeyDown('Tab', focusTrap);
+        fix.detectChanges();
+        expect(document.activeElement).toEqual(buttons[buttons.length - 1].nativeElement);
+
+        UIInteractions.triggerEventHandlerKeyDown('Tab', focusTrap);
+        fix.detectChanges();
+        expect(document.activeElement).toEqual(inputs[0].nativeElement);
+    });
 });
 
 
@@ -177,14 +211,19 @@ describe('igxFocusTrap', () => {
             <input type="password" placeholder="Enter Password" name="psw">
         }
         <br>
+        @if (showTimePicker) {
+            <igx-time-picker> </igx-time-picker>
+        }
+        <br>
         @if (showButton) {
             <button>SIGN IN</button>
         }
     </div>`,
-    imports: [IgxFocusTrapDirective]
+    imports: [IgxFocusTrapDirective, IgxTimePickerComponent]
 })
 class TrapFocusTestComponent {
     public showInput = true;
     public showButton = true;
     public focusTrap = true;
+    public showTimePicker = false;
 }

projects/igniteui-angular/src/lib/directives/focus-trap/focus-trap.directive.ts

@@ -80,7 +80,7 @@ export class IgxFocusTrapDirective implements AfterViewInit, OnDestroy {
     private getFocusableElements(element: Element) {
         return Array.from(element.querySelectorAll(
             'a[href], button, input, textarea, select, details,[tabindex]:not([tabindex="-1"])'
-        )).filter(el => !el.hasAttribute('disabled') && !el.getAttribute('aria-hidden'));
+        )).filter(el => !el.hasAttribute('disabled') && !el.closest('[aria-hidden="true"]'));
     }
 
     private getFocusedElement(): HTMLElement | null {

projects/igniteui-angular/src/lib/directives/input/input.directive.spec.ts

@@ -908,6 +908,22 @@ describe('IgxInput', () => {
 
         expect(formControl.touched).toBe(true);
     }));
+
+    it('should update validity when control is marked as touched', fakeAsync(() => {
+        const fixture = TestBed.createComponent(ReactiveFormComponent);
+        fixture.detectChanges();
+
+        const component = fixture.componentInstance;
+        const igxInput = component.strIgxInput;
+
+        expect(igxInput.valid).toBe(IgxInputState.INITIAL);
+
+        component.markAllAsTouched();
+        tick();
+        fixture.detectChanges();
+
+        expect(igxInput.valid).toBe(IgxInputState.INVALID);
+    }));
 });
 
 @Component({
@@ -1201,6 +1217,12 @@ class ReactiveFormComponent {
         this.textareaControl.markAsTouched();
         this.textareaControl.updateValueAndValidity();
     }
+
+    public markAllAsTouched() {
+        if (!this.form.valid) {
+            this.form.markAllAsTouched();
+        }
+    }
 }
 
 @Component({

projects/igniteui-angular/src/lib/directives/input/input.directive.ts

@@ -16,9 +16,10 @@ import {
 import {
     AbstractControl,
     NgControl,
-    NgModel
+    NgModel,
+    TouchedChangeEvent
 } from '@angular/forms';
-import { Subscription } from 'rxjs';
+import { filter, Subscription } from 'rxjs';
 import { IgxInputGroupBase } from '../../input-group/input-group.common';
 
 const nativeValidationAttributes = [
@@ -100,6 +101,7 @@ export class IgxInputDirective implements AfterViewInit, OnDestroy {
     private _valid = IgxInputState.INITIAL;
     private _statusChanges$: Subscription;
     private _valueChanges$: Subscription;
+    private _touchedChanges$: Subscription;
     private _fileNames: string;
     private _disabled = false;
 
@@ -313,6 +315,14 @@ export class IgxInputDirective implements AfterViewInit, OnDestroy {
             this._valueChanges$ = this.ngControl.valueChanges.subscribe(
                 this.onValueChanged.bind(this)
             );
+
+            if (this.ngControl.control) {
+                this._touchedChanges$ = this.ngControl.control.events
+                    .pipe(filter(e => e instanceof TouchedChangeEvent))
+                    .subscribe(
+                        this.updateValidityState.bind(this)
+                    );
+            }
         }
 
         this.cdr.detectChanges();
@@ -326,6 +336,10 @@ export class IgxInputDirective implements AfterViewInit, OnDestroy {
         if (this._valueChanges$) {
             this._valueChanges$.unsubscribe();
         }
+
+        if (this._touchedChanges$) {
+            this._touchedChanges$.unsubscribe();
+        }
     }
     /**
      * Sets a focus on the igxInput.

projects/igniteui-angular/src/lib/grids/columns/column.component.ts

@@ -1597,13 +1597,6 @@ export class IgxColumnComponent implements AfterContentInit, OnDestroy, ColumnTy
         return !this.grid.isPinningToStart && pinnedCols[0] === this;
     }
 
-    /** @hidden @internal **/
-    public get rightPinnedOffset(): string {
-        return this.pinned && !this.grid.isPinningToStart ?
-            - this.grid.pinnedWidth - this.grid.headerFeaturesWidth + 'px' :
-            null;
-    }
-
     /** @hidden @internal **/
     public get gridRowSpan(): number {
         return this.rowEnd && this.rowStart ? this.rowEnd - this.rowStart : 1;

projects/igniteui-angular/src/lib/grids/filtering/excel-style/excel-style-conditional-filter.component.html

@@ -7,8 +7,8 @@
         [igxDropDownItemNavigation]="subMenu"
         role="menuitem"
         aria-haspopup="true"
-        [attr.aria-controls]="this.subMenu?.listId"
-        [attr.aria-activedescendant]="!this.subMenu?.collapsed ? this.subMenu?.focusedItem?.id : null">
+        [attr.aria-controls]="subMenu?.listId"
+        [attr.aria-activedescendant]="!subMenu?.collapsed ? subMenu?.focusedItem?.id : null">
         <span class="igx-excel-filter__filter-number">
             {{ subMenuText }}
             @if (filterNumber > 0) { ({{filterNumber}}) }

projects/igniteui-angular/src/lib/grids/filtering/grid-filtering.service.ts

@@ -321,10 +321,10 @@ export class IgxFilteringService implements OnDestroy {
     public registerSVGIcons(): void {
         const editorIcons = editor as any[];
         editorIcons.forEach(icon => {
-            this.iconService.addSvgIconFromText(icon.name, icon.value, 'imx-icons');
+            this.iconService.addSvgIconFromText(icon.name, icon.value, 'imx-icons', true);
         });
-        this.iconService.addSvgIconFromText(pinLeft.name, pinLeft.value, 'imx-icons');
-        this.iconService.addSvgIconFromText(unpinLeft.name, unpinLeft.value, 'imx-icons');
+        this.iconService.addSvgIconFromText(pinLeft.name, pinLeft.value, 'imx-icons', true);
+        this.iconService.addSvgIconFromText(unpinLeft.name, unpinLeft.value, 'imx-icons', true);
     }
 
     /**

projects/igniteui-angular/src/lib/grids/grid-navigation.service.ts

@@ -1,5 +1,5 @@
 import { Injectable } from '@angular/core';
-import { first } from 'rxjs/operators';
+import { first, throttleTime } from 'rxjs/operators';
 import { IgxForOfDirective } from '../directives/for-of/for_of.directive';
 import { GridType } from './common/grid.interface';
 import {
@@ -17,6 +17,7 @@ import { IActiveNodeChangeEventArgs } from './common/events';
 import { IgxGridGroupByRowComponent } from './grid/groupby-row.component';
 import { IMultiRowLayoutNode } from './common/types';
 import { SortingDirection } from '../data-operations/sorting-strategy';
+import { animationFrameScheduler, Subject } from 'rxjs';
 export interface ColumnGroupsCache {
     level: number;
     visibleIndex: number;
@@ -37,6 +38,7 @@ export class IgxGridNavigationService {
     public _activeNode: IActiveNode = {} as IActiveNode;
     public lastActiveNode: IActiveNode = {} as IActiveNode;
     protected pendingNavigation = false;
+    protected keydownNotify = new Subject<KeyboardEvent>();
 
     public get activeNode() {
         return this._activeNode;
@@ -46,7 +48,15 @@ export class IgxGridNavigationService {
         this._activeNode = value;
     }
 
-    constructor(protected platform: PlatformUtil) { }
+    constructor(protected platform: PlatformUtil) {
+        this.keydownNotify.pipe(
+            throttleTime(30, animationFrameScheduler),
+        )
+        .subscribe((event: KeyboardEvent) => {
+            this.dispatchEvent(event);
+        });
+
+     }
 
     public handleNavigation(event: KeyboardEvent) {
         const key = event.key.toLowerCase();
@@ -60,7 +70,7 @@ export class IgxGridNavigationService {
             event.preventDefault();
         }
         if (event.repeat) {
-            setTimeout(() => this.dispatchEvent(event), 1);
+            this.keydownNotify.next(event);
         } else {
             this.dispatchEvent(event);
         }
@@ -96,10 +106,8 @@ export class IgxGridNavigationService {
             event.preventDefault();
             this.navigateInBody(position.rowIndex, position.colIndex, (obj) => {
                 obj.target.activate(event);
-                this.grid.cdr.detectChanges();
             });
         }
-        this.grid.cdr.detectChanges();
     }
 
     public summaryNav(event: KeyboardEvent) {
@@ -145,7 +153,6 @@ export class IgxGridNavigationService {
                 this.grid.clearCellSelection();
                 this.grid.navigateTo(this.activeNode.row, this.activeNode.column, (obj) => {
                     obj.target?.activate(event);
-                    this.grid.cdr.detectChanges();
                 });
             } else {
                 if (hasLastActiveNode && !this.grid.selectionService.selected(this.lastActiveNode)) {
@@ -598,7 +605,6 @@ export class IgxGridNavigationService {
 
         this.navigateInBody(next.rowIndex, next.visibleColumnIndex, (obj) => {
             obj.target.activate(event);
-            this.grid.cdr.detectChanges();
         });
     }