Skip to content

Commit eb7bae7

Browse files
committed
fix(column): removing elementRef injection #6940
1 parent 7aff8c8 commit eb7bae7

File tree

5 files changed

+20
-6
lines changed

5 files changed

+20
-6
lines changed

projects/igniteui-angular/src/lib/grids/columns/column.component.ts

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,21 @@ export class IgxColumnComponent implements AfterContentInit {
8787
@WatchColumnChanges()
8888
@Input()
8989
public header = '';
90+
/**
91+
* Sets/gets the `title` value.
92+
* ```typescript
93+
* let title = this.column.title;
94+
* ```
95+
* ```html
96+
* <igx-column [title] = "'Some column tooltip'"></igx-column>
97+
* ```
98+
*
99+
* @memberof IgxColumnComponent
100+
*/
101+
@notifyChanges()
102+
@WatchColumnChanges()
103+
@Input()
104+
public title = '';
90105
/**
91106
* Sets/gets whether the column is sortable.
92107
* Default value is `false`.
@@ -1344,7 +1359,7 @@ export class IgxColumnComponent implements AfterContentInit {
13441359
protected collapseIndicatorTemplate: IgxCollapsibleIndicatorTemplateDirective;
13451360

13461361
constructor(public gridAPI: GridBaseAPIService<IgxGridBaseDirective & GridType>, public cdr: ChangeDetectorRef,
1347-
public rowIslandAPI: IgxRowIslandAPIService, public elementRef: ElementRef) { }
1362+
public rowIslandAPI: IgxRowIslandAPIService) { }
13481363

13491364
/**
13501365
* @hidden

projects/igniteui-angular/src/lib/grids/grid/column-group.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1679,7 +1679,7 @@ describe('IgxGrid - multi-column headers #grid', () => {
16791679

16801680
const grid = fixture.componentInstance.grid;
16811681
const generalGroup = grid.columnList.find(c => c.header === 'General Information');
1682-
generalGroup.elementRef.nativeElement.title = 'General Information Title';
1682+
generalGroup.title = 'General Information Title';
16831683
fixture.detectChanges();
16841684

16851685
const headers = fixture.debugElement.queryAll(By.css('.' + GRID_COL_GROUP_THEAD_TITLE_CLASS));

projects/igniteui-angular/src/lib/grids/grid/column.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -384,7 +384,7 @@ describe('IgxGrid - Column properties #grid', () => {
384384
const nameColumn = grid.getColumnByName('Name');
385385

386386
idColumn.header = 'ID Header';
387-
idColumn.elementRef.nativeElement.title = 'ID Title';
387+
idColumn.title = 'ID Title';
388388
nameColumn.header = 'Name Header';
389389
fix.detectChanges();
390390

projects/igniteui-angular/src/lib/grids/headers/grid-header-group.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ export class IgxGridHeaderGroupComponent implements DoCheck {
254254
* @hidden
255255
*/
256256
get columnTitle() {
257-
return this.column.elementRef.nativeElement.getAttribute('title') || this.column.header;
257+
return this.column.title || this.column.header;
258258
}
259259

260260
/**

projects/igniteui-angular/src/lib/grids/headers/grid-header.component.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,7 @@ export class IgxGridHeaderComponent implements DoCheck, OnInit, OnDestroy {
122122
}
123123

124124
get columnTitle() {
125-
return this.column.elementRef.nativeElement.getAttribute('title') ||
126-
this.column.header || this.column.field;
125+
return this.column.title || this.column.header || this.column.field;
127126
}
128127

129128
@HostBinding('attr.role')

0 commit comments

Comments
 (0)