Skip to content

Commit ec66407

Browse files
authored
fix(card): removing card header role #12792 (#12793)
1 parent ad0a6aa commit ec66407

File tree

3 files changed

+3
-14
lines changed

3 files changed

+3
-14
lines changed

projects/igniteui-angular/src/lib/card/README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ Supporting directives and components:
4747
## igx-card-header
4848
| Name | Type | Description |
4949
|:----------|:-------------:|:------|
50-
| `role` | string | The role attribute of the card header. By default it's set to `header`. |
5150
| `vertical` | boolean | Sets the header layout direction. When set to `true` the card content is vertically layed out. |
5251

5352
## igx-card-media

projects/igniteui-angular/src/lib/card/card.component.ts

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -88,18 +88,6 @@ export class IgxCardHeaderComponent {
8888
@HostBinding('class.igx-card-header--vertical')
8989
@Input()
9090
public vertical = false;
91-
92-
/**
93-
* An @Input property that sets the value of the `role` attribute of the card header.
94-
* By default the value is set to `header`.
95-
*
96-
* @example
97-
* ```html
98-
* <igx-card-header role="header"></igx-card-header>
99-
* ```
100-
*/
101-
@HostBinding('attr.role')
102-
public role = 'header';
10391
}
10492

10593
/**

projects/igniteui-angular/src/lib/card/card.spec.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,9 @@ describe('Card', () => {
124124
const header = fixture.debugElement.query(By.css('igx-card-header')).nativeElement;
125125

126126
expect(header).toBeDefined();
127-
expect(header.getAttribute('role')).toEqual('header');
127+
// K.D. March 20th, 2023 #12792 Card header should have no role
128+
// expect(header.getAttribute('role')).toEqual('header');
129+
expect(header.getAttribute('role')).toBeNull();
128130

129131
expect(header).toHaveClass(classes.header.base);
130132
expect(header).not.toHaveClass(classes.header.vertical);

0 commit comments

Comments
 (0)