Merge remote-tracking branch 'origin/master' into dpetev/control-flow

Author: damyanpetev

projects/igniteui-angular-elements/src/themes/light/fluent.scss

@@ -7,7 +7,6 @@ $palette: igx.$light-fluent-palette;
 
 @include igx.core();
 @include igx.typography($font-family: igx.$fluent-typeface, $type-scale: igx.$fluent-type-scale);
-@include igx.fluent-light-theme($palette: $palette, $exclude: vars.$unused-themes);
 
 @include util.elements-theme(
     $palette: $palette,

projects/igniteui-angular/migrations/update-19_1_0/changes/theme-changes.json

@@ -114,6 +114,12 @@
         "owner": "time-picker-theme",
         "remove": true,
         "type": "property"
+      },
+      {
+        "name": "$palette",
+        "owner": "color-classes",
+        "remove": true,
+        "type": "property"
       }
     ]
   }

projects/igniteui-angular/migrations/update-19_1_0/index.spec.ts

@@ -36,4 +36,26 @@ describe(`Update to ${version}`, () => {
             );
         });
     });
+
+    it('should remove the $palette property from the color-classes mixin', async () => {
+            const testFilePath = `/testSrc/appPrefix/component/test.component.scss`;
+
+            appTree.create(
+                testFilePath,
+                `@include color-classes(
+                    $palette: $some-palette,
+                    $prop: 'color',
+                    $prefix: 'bg'
+                );`
+            );
+
+            const tree = await schematicRunner.runSchematic(migrationName, {}, appTree);
+
+            expect(tree.readContent(testFilePath)).toEqual(
+                `@include color-classes(
+                    $prop: 'color',
+                    $prefix: 'bg'
+                );`
+            );
+    });
 });

projects/igniteui-angular/src/lib/checkbox/checkbox.component.ts

@@ -7,14 +7,9 @@ import {
 } from '@angular/core';
 import { IgxRippleDirective } from '../directives/ripple/ripple.directive';
 import { CheckboxBaseDirective } from './checkbox-base.directive';
-import { IBaseEventArgs } from '../core/utils';
 import { ControlValueAccessor } from '@angular/forms';
 import { EditorProvider, EDITOR_PROVIDER } from '../core/edit-provider';
 
-export interface IChangeCheckboxEventArgs extends IBaseEventArgs {
-    checked: boolean;
-    value?: any;
-}
 /**
  * Allows users to make a binary choice for a certain condition.
  *

projects/igniteui-angular/src/lib/checkbox/public_api.ts

@@ -0,0 +1,2 @@
+export { type LabelPosition, IChangeCheckboxEventArgs } from "./checkbox-base.directive";
+export * from "./checkbox.component";

projects/igniteui-angular/src/lib/combo/combo.component.html

@@ -43,7 +43,7 @@
     (opened)="handleOpened()" (closed)="handleClosed()">
     @if (displaySearchInput) {
         <div class="igx-combo__search">
-            <igx-input-group>
+            <igx-input-group type="line">
                 <input igxInput #searchInput name="searchInput" autocomplete="off" type="text"
                     [(ngModel)]="searchValue" (ngModelChange)="handleInputChange($event)" (keyup)="handleKeyUp($event)"
                     (keydown)="handleKeyDown($event)" (focus)="dropdown.onBlur($event)" [attr.placeholder]="getSearchPlaceholderText()"

projects/igniteui-angular/src/lib/core/styles/components/icon-button/_icon-button-theme.scss

@@ -369,7 +369,6 @@
                 content: '';
                 inset: 0;
                 box-shadow: inset 0 0 0 rem(1px) var-get($outlined-theme, 'border-color');
-                z-index: -1;
                 border-radius: inherit;
             }
 

projects/igniteui-angular/src/lib/directives/button/button.directive.ts

@@ -7,7 +7,8 @@ import {
     Output,
     Renderer2,
     booleanAttribute,
-    AfterContentInit
+    AfterContentInit,
+    OnDestroy
 } from '@angular/core';
 import { mkenum } from '../../core/utils';
 import { IBaseEventArgs } from '../../core/utils';
@@ -46,7 +47,7 @@ export type IgxButtonType = typeof IgxButtonType[keyof typeof IgxButtonType];
     selector: '[igxButton]',
     standalone: true
 })
-export class IgxButtonDirective extends IgxButtonBaseDirective implements AfterContentInit {
+export class IgxButtonDirective extends IgxButtonBaseDirective implements AfterContentInit, OnDestroy {
     private static ngAcceptInputType_type: IgxButtonType | '';
 
     /**
@@ -92,6 +93,12 @@ export class IgxButtonDirective extends IgxButtonBaseDirective implements AfterC
      */
     private _selected = false;
 
+    private emitSelected() {
+        this.buttonSelected.emit({
+            button: this
+        });
+    }
+
     /**
      * Gets or sets whether the button is selected.
      * Mainly used in the IgxButtonGroup component and it will have no effect if set separately.
@@ -121,11 +128,11 @@ export class IgxButtonDirective extends IgxButtonBaseDirective implements AfterC
     }
 
     public ngAfterContentInit() {
-        this.nativeElement.addEventListener('click', () => {
-            this.buttonSelected.emit({
-                button: this
-            });
-        });
+        this.nativeElement.addEventListener('click', this.emitSelected.bind(this));
+    }
+
+    public ngOnDestroy(): void {
+        this.nativeElement.removeEventListener('click', this.emitSelected);
     }
 
     /**

projects/igniteui-angular/src/lib/directives/radio/radio-group.directive.ts

@@ -10,7 +10,7 @@ import { startWith, takeUntil } from 'rxjs/operators';
 import { mkenum } from '../../core/utils';
 import { IgxRadioComponent } from '../../radio/radio.component';
 import { IgxDirectionality } from '../../services/direction/directionality';
-import { IChangeCheckboxEventArgs } from '../../checkbox/checkbox.component';
+import { IChangeCheckboxEventArgs } from '../../checkbox/public_api';
 
 /**
  * Determines the Radio Group alignment

projects/igniteui-angular/src/lib/grids/common/crud.service.ts

@@ -684,12 +684,13 @@ export class IgxGridCRUDService extends IgxRowAddCrudState {
             return;
         }
         this.endEdit(true, event);
-
-        if (parentRow != null && this.grid.expansionStates.get(parentRow.key)) {
-            this.grid.collapseRow(parentRow.key);
+        // work with copy of original row, since context may change on collapse.
+        const parentRowCopy = parentRow ? Object.assign(copyDescriptors(parentRow), parentRow) : null;
+        if (parentRowCopy != null && this.grid.expansionStates.get(parentRowCopy.key)) {
+            this.grid.collapseRow(parentRowCopy.key);
         }
 
-        this.createAddRow(parentRow, asChild);
+        this.createAddRow(parentRowCopy, asChild);
 
         this.grid.transactions.startPending();
         if (this.addRowParent.isPinned) {