fix(query-builder): improve isAdvancedFiltering check - 20.0.x (#16020)

* fix(query-builder): improve isAdvancedFiltering check and add checks when entities is not set

Author: igdmdimitrov

projects/igniteui-angular/src/lib/query-builder/query-builder-tree.component.html

@@ -75,7 +75,7 @@
                     (selectionChanging)="onReturnFieldSelectChanging($event)"
                     [overlaySettings]="returnFieldSelectOverlaySettings"
                     [disabled]="!selectedEntity"
-                    [ngModel]="selectedReturnFields[0]"
+                    [ngModel]="selectedReturnFields ? selectedReturnFields[0] : null"
                     [placeholder]="this.resourceStrings.igx_query_builder_select_return_field_single"
                     [style.display]="isInEditMode() ? 'block' : 'none'"
                     (opening)="exitEditAddMode()"
@@ -466,7 +466,7 @@
                 <ng-container>
                     <igx-query-builder-tree
                         [style.display]="expressionItem.inEditMode || expressionItem.expanded ? 'block' : 'none'"
-                        [entities]="(this.selectedEntity ? this.selectedEntity.childEntities : entities[0].childEntities) ?? entities"
+                        [entities]="(this.selectedEntity ? this.selectedEntity.childEntities : entities?.[0]?.childEntities) ?? (entities ?? [])"
                         [queryBuilder]="this.queryBuilder"
                         [parentExpression]="expressionItem"
                         [expectedReturnField]="this.selectedField?.field"

projects/igniteui-angular/src/lib/query-builder/query-builder-tree.component.ts

@@ -523,7 +523,7 @@ export class IgxQueryBuilderTreeComponent implements AfterViewInit, OnDestroy {
     protected isAdvancedFiltering(): boolean {
         return (this.entities?.length === 1 && !this.entities[0]?.name) ||
             this.entities?.find(e => e.childEntities?.length > 0) !== undefined ||
-            this.entities !== this.queryBuilder?.entities;
+            (this.entities?.length > 0 && this.queryBuilder?.entities?.length > 0 && this.entities !== this.queryBuilder?.entities);
     }
 
     /** @hidden */

projects/igniteui-angular/src/lib/query-builder/query-builder.component.spec.ts

@@ -127,6 +127,13 @@ describe('IgxQueryBuilder', () => {
         expect(field.pipeArgs).toBeUndefined();
       });
     }));
+
+    it('Should not throw error when entities are empty and expressionTree is set.', fakeAsync(() => {
+      expect(() => {
+        fix = TestBed.createComponent(IgxQueryBuilderInvalidSampleTestComponent);
+        fix.detectChanges();
+      }).not.toThrow();
+    }));
   });
 
   describe('Interactions', () => {
@@ -3234,6 +3241,27 @@ export class IgxQueryBuilderSampleTestComponent implements OnInit {
   }
 }
 
+@Component({
+  template: `
+     <igx-query-builder #queryBuilder [entities]="this.entities" [expressionTree]="this.expressionTree">
+     </igx-query-builder>
+    `,
+  standalone: true,
+  imports: [
+    IgxQueryBuilderComponent
+  ]
+})
+export class IgxQueryBuilderInvalidSampleTestComponent implements OnInit {
+  @ViewChild(IgxQueryBuilderComponent) public queryBuilder: IgxQueryBuilderComponent;
+  public entities: Array<any>;
+  public expressionTree: IExpressionTree;
+
+  public ngOnInit(): void {
+    this.entities = [];
+    this.expressionTree = QueryBuilderFunctions.generateExpressionTree();
+  }
+}
+
 @Component({
   template: `
      <igx-query-builder #queryBuilder [entities]="this.entities" [expressionTree]="this.expressionTree">