Skip to content

Commit edcb401

Browse files
committed
fix(query-builder): commit expressions properly in hgrid
1 parent a9f8e33 commit edcb401

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

projects/igniteui-angular/src/lib/grids/grid/grid-filtering-advanced.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1608,8 +1608,8 @@ describe('IgxGrid - Advanced Filtering #grid - ', () => {
16081608
fix.detectChanges();
16091609

16101610
// Veify grid data
1611-
expect(hgrid.filteredData.length).toEqual(2);
1612-
expect(hgrid.rowList.length).toBe(2);
1611+
expect(hgrid.filteredData.length).toEqual(5);
1612+
expect(hgrid.rowList.length).toBe(5);
16131613
}));
16141614
});
16151615
});

projects/igniteui-angular/src/lib/query-builder/query-builder-tree.component.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -938,7 +938,8 @@ export class IgxQueryBuilderTreeComponent implements AfterViewInit, OnDestroy {
938938
!(this.selectedField?.filters?.condition(this.selectedCondition)?.isNestedQuery)
939939
) ||
940940
(
941-
this.selectedField?.filters?.condition(this.selectedCondition)?.isNestedQuery && innerQuery && !!innerQuery.expressionTree && innerQuery.selectedReturnFields?.length > 0
941+
this.selectedField?.filters?.condition(this.selectedCondition)?.isNestedQuery && innerQuery && !!innerQuery.expressionTree &&
942+
(innerQuery.selectedReturnFields?.length > 0 || (innerQuery.selectedReturnFields?.length === 0 && this.isAdvancedFiltering()))
942943
) ||
943944
this.selectedField.filters.condition(this.selectedCondition)?.isUnary
944945
);

0 commit comments

Comments
 (0)