Merge branch 'master' into nalipiev/packages

Author: Lipata

CHANGELOG.md

@@ -223,23 +223,39 @@ export function createProjectService(serverHost: tss.server.ServerHost): tss.ser
 export function getTypeDefinitionAtPosition(langServ: tss.LanguageService, entryPath: string, position: number): tss.DefinitionInfo | null {
     const definition = langServ.getDefinitionAndBoundSpan(entryPath, position)?.definitions[0];
     if (!definition) { return null; }
+
+    // if the definition's kind is a reference, the identifier is a template variable referred in an internal/external template
     if (definition.kind.toString() === 'reference') {
-        // template variable in an internal/external template
         return langServ.getDefinitionAndBoundSpan(entryPath, definition.textSpan.start).definitions[0];
     }
     let typeDefs = langServ.getTypeDefinitionAtPosition(entryPath, definition.textSpan.start);
+    // if there are no type definitions found, the identifier is a ts property, referred in an internal/external template
+    // or is a reference in a decorator
     if (!typeDefs) {
-        // ts property referred in an internal/external template
-        const classDeclaration = langServ
-            .getProgram()
-            .getSourceFile(definition.fileName)
+        /*
+         normally, the tsserver will consider non .ts files as external to the project
+         however, we load .html files which we can handle with the Angular language service
+         here we're only looking for definitions in a .ts source file
+         we call the getSourceFile function which accesses a map of files, previously loaded by the tsserver
+         at this point the map contains all .html files that we've included
+         we have to ignore them, since the language service will attempt to parse them as .ts files
+        */
+        if (!definition.fileName.endsWith('.ts')) { return null; }
+
+        const sourceFile = langServ.getProgram().getSourceFile(definition.fileName);
+        if (!sourceFile) { return null; }
+
+        const classDeclaration = sourceFile
             .statements
             .filter(<(a: tss.Statement) => a is tss.ClassDeclaration>(m => m.kind === tss.SyntaxKind.ClassDeclaration))
             .find(m => m.name.getText() === definition.containerName);
-        const member: ts.ClassElement = classDeclaration
-            ?.members
-            .find(m => m.name.getText() === definition.name);
-        if (!member || !member.name) { return null; }
+
+        // there must be at least one class declaration in the .ts file and the property must belong to it
+        if (!classDeclaration) { return null; }
+
+        const member: ts.ClassElement = classDeclaration.members.find(m => m.name.getText() === definition.name);
+        if (!member?.name) { return null; }
+
         typeDefs = langServ.getTypeDefinitionAtPosition(definition.fileName, member.name.getStart() + 1);
     }
     if (typeDefs?.length) {

README.md

@@ -1,7 +1,7 @@
 # IgxToggle Directive
 
 The **IgxToggle** provides a way for user to make a given content togglable.  
-A walkthrough of how to get started can be found [here](https://www.infragistics.com/products/ignite-ui-angular/angular/components/toggle.html)
+A walkthrough of how to get started can be found [here](https://www.infragistics.com/products/ignite-ui-angular/angular/components/toggle)
 
 #Usage
 ```typescript
@@ -60,7 +60,7 @@ handlers when the toggle is opened and respectively closed.
 
 The **IgxToggleAction** provides a way for user to Open/Close(toggle) every Component/Directive which implements **IToggleView** interface by providing the reference to this particular Component/Directive or ID which is registered into **IgxNavigationService**. It is also applicable upon **IgxToggle**. When applied **IgxToggleAction** will set its host element as the position strategy target.
 
-You can see it in action [here](https://www.infragistics.com/products/ignite-ui-angular/angular/components/toggle.html)
+You can see it in action [here](https://www.infragistics.com/products/ignite-ui-angular/angular/components/toggle)
 
 ## Usage
 ```typescript

projects/igniteui-angular/migrations/common/tsUtils.ts

@@ -5,7 +5,7 @@ _Directives_
 
 ## Description
 The **IgxTooltip** directive provides us a way to make a given element a tooltip. Then we can assign it to be a tooltip for another element (for example a button) by using the **IgxTooltipTarget** directive.
-A walkthrough of how to get started can be found [here](https://www.infragistics.com/products/ignite-ui-angular/angular/components/tooltip.html).
+A walkthrough of how to get started can be found [here](https://www.infragistics.com/products/ignite-ui-angular/angular/components/tooltip).
 
 ## Usage
 First we will have to import the IgxTooltipModule.

projects/igniteui-angular/src/lib/directives/toggle/README.md

@@ -27,7 +27,7 @@ export interface ITooltipHideEventArgs extends IBaseEventArgs {
 
 /**
  * **Ignite UI for Angular Tooltip Target** -
- * [Documentation](https://www.infragistics.com/products/ignite-ui-angular/angular/components/tooltip.html)
+ * [Documentation](https://www.infragistics.com/products/ignite-ui-angular/angular/components/tooltip)
  *
  * The Ignite UI for Angular Tooltip Target directive is used to mark an HTML element in the markup as one that has a tooltip.
  * The tooltip target is used in combination with the Ignite UI for Angular Tooltip by assigning the exported tooltip reference to the
@@ -411,7 +411,7 @@ export class IgxTooltipTargetDirective extends IgxToggleActionDirective implemen
 let NEXT_ID = 0;
 /**
  * **Ignite UI for Angular Tooltip** -
- * [Documentation](https://www.infragistics.com/products/ignite-ui-angular/angular/components/tooltip.html)
+ * [Documentation](https://www.infragistics.com/products/ignite-ui-angular/angular/components/tooltip)
  *
  * The Ignite UI for Angular Tooltip directive is used to mark an HTML element in the markup as one that should behave as a tooltip.
  * The tooltip is used in combination with the Ignite UI for Angular Tooltip Target by assigning the exported tooltip reference to the

projects/igniteui-angular/src/lib/directives/tooltip/README.md

@@ -3,7 +3,7 @@
 
 **igxDropDown** displays a scrollable list of items which may be visually grouped and supports selection of a single item. Clicking or tapping an item selects it and closes the Drop Down.
 
-A walkthrough of how to get started can be found [here](https://www.infragistics.com/products/ignite-ui-angular/angular/components/drop_down.html)
+A walkthrough of how to get started can be found [here](https://www.infragistics.com/products/ignite-ui-angular/angular/components/drop-down)
 
 # Usage
 ## Drop downs are done by adding **igxDropDownListItems** to **igxDropDown** component

projects/igniteui-angular/src/lib/directives/tooltip/tooltip.directive.ts

@@ -34,7 +34,7 @@ import { DisplayDensityToken, IDisplayDensityOptions } from '../core/density';
 
 /**
  * **Ignite UI for Angular DropDown** -
- * [Documentation](https://www.infragistics.com/products/ignite-ui-angular/angular/components/drop_down.html)
+ * [Documentation](https://www.infragistics.com/products/ignite-ui-angular/angular/components/drop-down)
  *
  * The Ignite UI for Angular Drop Down displays a scrollable list of items which may be visually grouped and
  * supports selection of a single item. Clicking or tapping an item selects it and closes the Drop Down

projects/igniteui-angular/src/lib/drop-down/README.md

@@ -3,7 +3,7 @@
 
 **IgxExpansionPanel** is a light and highly templateable component that allows you to dynamically display content.
 
-A walkthrough of how to get started can be found [here](https://www.infragistics.com/products/ignite-ui-angular/angular/components/expansion_panel.html)
+A walkthrough of how to get started can be found [here](https://www.infragistics.com/products/ignite-ui-angular/angular/components/expansion-panel)
 
 # Usage
 

projects/igniteui-angular/src/lib/drop-down/drop-down.component.ts

@@ -1,6 +1,6 @@
 # igx-grid
 **igx-grid** component provides the capability to manipulate and represent tabular data.
-A walkthrough of how to get started can be found [here](https://www.infragistics.com/products/ignite-ui-angular/angular/components/grid.html)
+A walkthrough of how to get started can be found [here](https://www.infragistics.com/products/ignite-ui-angular/angular/components/grid/grid)
 
 ## Usage
 ```html