Skip to content

Commit f05c318

Browse files
committed
test(filtering): reset expression when condition is unary
1 parent 93d2280 commit f05c318

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

projects/igniteui-angular/src/lib/grids/filtering/base/grid-filtering-row.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ export class IgxGridFilteringRowComponent implements AfterViewInit, OnDestroy {
7373
const index = this.expressionsList.findIndex(item => item.expression === this.expression);
7474
if (index === 0 && this.expressionsList.length === 1) {
7575
this.filteringService.clearFilter(this.column.field);
76-
76+
7777
if (this.expression.condition.isUnary) {
7878
this.resetExpression();
7979
}

projects/igniteui-angular/src/lib/grids/grid/grid-filtering-ui.spec.ts

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2073,11 +2073,24 @@ describe('IgxGrid - Filtering Row UI actions #grid', () => {
20732073
grid.filteringRow.onClearClick();
20742074
tick(100);
20752075
fix.detectChanges();
2076-
console.log(grid.filteringRow.expression.condition.name);
20772076

20782077
expect(grid.filteringRow.expression.condition.name).toEqual('startsWith');
20792078
}));
20802079

2080+
it('should reset expression when the condition is unary', fakeAsync(() => {
2081+
GridFunctions.clickFilterCellChip(fix, 'ProductName');
2082+
2083+
// iterate over unary conditions
2084+
// empty
2085+
GridFunctions.openFilterDDAndSelectCondition(fix, 6);
2086+
2087+
grid.filteringRow.onClearClick();
2088+
tick(100);
2089+
fix.detectChanges();
2090+
2091+
expect(grid.filteringRow.expression.condition.name).toEqual('contains');
2092+
}));
2093+
20812094
it('Should filter by cells formatted data when using FormattedValuesFilteringStrategy', fakeAsync(() => {
20822095
const formattedStrategy = new FormattedValuesFilteringStrategy(['Downloads']);
20832096
grid.filterStrategy = formattedStrategy;

0 commit comments

Comments
 (0)