Merge pull request #10281 from IgniteUI/vkombov/fix-10276-master

fix(grid): set correct indexes of rows with selected data in the extractDataFromSelection method

Author: kdinev

projects/igniteui-angular/src/lib/grids/grid-base.directive.ts

@@ -6942,7 +6942,7 @@ export abstract class IgxGridBaseDirective extends DisplayDensityBase implements
 
         // eslint-disable-next-line prefer-const
         for (let [row, set] of selectionMap) {
-            row = this.paginator ? row + (this.paginator.perPage * this.paginator.page) : row;
+            row = this.paginator && source === this.filteredSortedData ? row + (this.paginator.perPage * this.paginator.page) : row;
             row = isRemote ? row - this.virtualizationState.startIndex : row;
             if (!source[row] || source[row].detailsData !== undefined) {
                 continue;

projects/igniteui-angular/src/lib/grids/grid/grid.master-detail.spec.ts

@@ -3,7 +3,7 @@ import { TestBed, ComponentFixture, fakeAsync, tick } from '@angular/core/testin
 import { configureTestSuite } from '../../test-utils/configure-suite';
 import { NoopAnimationsModule } from '@angular/platform-browser/animations';
 import { By } from '@angular/platform-browser';
-import { UIInteractions, wait, waitForActiveNodeChange} from '../../test-utils/ui-interactions.spec';
+import { UIInteractions, wait, waitForActiveNodeChange } from '../../test-utils/ui-interactions.spec';
 import { IgxGridModule } from './public_api';
 import { IgxGridComponent } from './grid.component';
 import { IgxGridRowComponent } from './grid-row.component';
@@ -42,7 +42,7 @@ describe('IgxGrid Master Detail #grid', () => {
     }));
 
     describe('Basic', () => {
-        beforeEach( fakeAsync(() => {
+        beforeEach(fakeAsync(() => {
             fix = TestBed.createComponent(DefaultGridMasterDetailComponent);
             fix.detectChanges();
             grid = fix.componentInstance.grid;
@@ -689,7 +689,7 @@ describe('IgxGrid Master Detail #grid', () => {
 
     describe('Integration', () => {
         describe('Paging', () => {
-             it('Should not take into account expanded detail views as additional records.', fakeAsync(() => {
+            it('Should not take into account expanded detail views as additional records.', fakeAsync(() => {
                 fix = TestBed.createComponent(DefaultGridMasterDetailComponent);
                 grid = fix.componentInstance.grid;
                 fix.detectChanges();
@@ -859,6 +859,48 @@ describe('IgxGrid Master Detail #grid', () => {
                 fix.detectChanges();
                 expect(grid.getSelectedData()).toEqual(expectedData);
             }));
+
+            it('getSelectedData should return correct values when there are master details and paging is enabled', fakeAsync(() => {
+                const range = { rowStart: 0, rowEnd: 5, columnStart: 'ContactName', columnEnd: 'ContactName' };
+                const expectedDataFromSecondPage = [
+                    { ContactName: 'Hanna Moos' },
+                    { ContactName: 'Frédérique Citeaux' },
+                    { ContactName: 'Martín Sommer' }
+                ];
+                fix.componentInstance.paging = true;
+                fix.detectChanges();
+                grid.paginator.perPage = 5;
+                fix.detectChanges();
+                tick(16);
+                grid.paginator.paginate(1);
+                fix.detectChanges();
+                tick(16);
+
+                grid.expandAll();
+                tick(100);
+                fix.detectChanges();
+
+                grid.selectRange(range);
+                fix.detectChanges();
+                expect(grid.getSelectedData()).toEqual(expectedDataFromSecondPage);
+
+                const expectedDataFromThirdPage = [
+                    { ContactName: 'Victoria Ashworth' },
+                    { ContactName: 'Patricio Simpson' },
+                    { ContactName: 'Francisco Chang' }
+                ];
+                grid.paginator.paginate(2);
+                fix.detectChanges();
+                tick(16);
+
+                grid.expandAll();
+                tick(100);
+                fix.detectChanges();
+
+                grid.selectRange(range);
+                fix.detectChanges();
+                expect(grid.getSelectedData()).toEqual(expectedDataFromThirdPage);
+            }));
         });
 
         describe('Row Selection', () => {