Skip to content

Commit f7ba2fb

Browse files
committed
chore(*): Set a single grid icon service for all grid instances.
1 parent b7e3392 commit f7ba2fb

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

projects/igniteui-angular/src/lib/grids/common/grid-icon.service.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@ import { GridSVGIcon } from './grid.interface';
66
/**
77
* @hidden
88
*/
9-
@Injectable()
9+
@Injectable({
10+
providedIn: 'root'
11+
})
1012
export class IgxGridIconService {
1113

1214
private iconsMap = new Map<GridIconsFeature, GridSVGIcon[]>();

projects/igniteui-angular/src/lib/grids/common/shared.module.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import { IgxProgressBarModule } from '../../progressbar/progressbar.component';
2121
import { IgxSelectModule } from '../../select/select.module';
2222
import { IgxDropDownModule } from '../../drop-down/public_api';
2323
import { IgxGridStateModule } from '../state.directive';
24+
import { IgxGridIconService } from './grid-icon.service';
2425

2526

2627
@NgModule({
@@ -71,6 +72,9 @@ import { IgxGridStateModule } from '../state.directive';
7172
IgxButtonGroupModule,
7273
IgxProgressBarModule,
7374
IgxSelectModule
75+
],
76+
providers: [
77+
IgxGridIconService
7478
]
7579
})
7680
export class IgxGridSharedModules {}

projects/igniteui-angular/src/lib/grids/grid/grid.component.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ import { IgxGridMRLNavigationService } from '../grid-mrl-navigation.service';
2626
import { IgxRowIslandAPIService } from '../hierarchical-grid/row-island-api.service';
2727
import { FilterMode } from '../common/enums';
2828
import { GridType } from '../common/grid.interface';
29-
import { IgxGridIconService } from '../common/grid-icon.service';
3029

3130
let NEXT_ID = 0;
3231

@@ -68,8 +67,7 @@ export interface IGroupingDoneEventArgs extends IBaseEventArgs {
6867
IgxColumnResizingService,
6968
IgxForOfSyncService,
7069
IgxForOfScrollSyncService,
71-
IgxRowIslandAPIService,
72-
IgxGridIconService
70+
IgxRowIslandAPIService
7371
],
7472
selector: 'igx-grid',
7573
templateUrl: './grid.component.html'

projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-grid.component.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ import { IgxTransactionService } from '../../services/public_api';
3636
import { IgxForOfSyncService, IgxForOfScrollSyncService } from '../../directives/for-of/for_of.sync.service';
3737
import { GridType } from '../common/grid.interface';
3838
import { IgxRowIslandAPIService } from './row-island-api.service';
39-
import { IgxGridIconService } from '../common/grid-icon.service';
4039

4140
let NEXT_ID = 0;
4241

@@ -59,8 +58,7 @@ export interface HierarchicalStateRecord {
5958
IgxHierarchicalGridNavigationService,
6059
IgxForOfSyncService,
6160
IgxForOfScrollSyncService,
62-
IgxRowIslandAPIService,
63-
IgxGridIconService
61+
IgxRowIslandAPIService
6462
]
6563
})
6664
export class IgxHierarchicalGridComponent extends IgxHierarchicalGridBaseDirective

projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid.component.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ import { GridType } from '../common/grid.interface';
3737
import { IgxColumnComponent } from '../columns/column.component';
3838
import { IgxRowIslandAPIService } from '../hierarchical-grid/row-island-api.service';
3939
import { IgxTreeGridRowComponent } from './tree-grid-row.component';
40-
import { IgxGridIconService } from '../common/grid-icon.service';
4140

4241
let NEXT_ID = 0;
4342

@@ -72,8 +71,7 @@ let NEXT_ID = 0;
7271
IgxFilteringService,
7372
IgxForOfSyncService,
7473
IgxForOfScrollSyncService,
75-
IgxRowIslandAPIService,
76-
IgxGridIconService
74+
IgxRowIslandAPIService
7775
]
7876
})
7977
export class IgxTreeGridComponent extends IgxGridBaseDirective implements GridType, OnInit, DoCheck, AfterContentInit {

0 commit comments

Comments
 (0)