Skip to content

Commit f7cb983

Browse files
committed
fix(query-builder): fix edti/add button event handlers shifted up on parent span
1 parent 528923c commit f7cb983

File tree

2 files changed

+12
-14
lines changed

2 files changed

+12
-14
lines changed

projects/igniteui-angular/src/lib/query-builder/query-builder-functions.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -689,11 +689,11 @@ export class QueryBuilderFunctions {
689689
let i = 0;
690690
tabElements.forEach((element: HTMLElement) => {
691691
switch (i) {
692-
case 0: expect(element).toHaveClass('igx-icon');
693-
expect(element.innerText).toContain('edit');
692+
case 0: expect(element.firstChild).toHaveClass('igx-icon');
693+
expect(element.firstChild.textContent).toContain('edit');
694694
break;
695-
case 1: expect(element).toHaveClass('igx-icon');
696-
expect(element.innerText).toContain('add');
695+
case 1: expect(element.firstChild).toHaveClass('igx-icon');
696+
expect(element.firstChild.textContent).toContain('add');
697697
break;
698698
}
699699
i++;

projects/igniteui-angular/src/lib/query-builder/query-builder-tree.component.html

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -147,23 +147,21 @@ <h6 class="igx-filter-empty__title">
147147
expressionItem.hovered
148148
"
149149
>
150-
<span tabindex="-1">
150+
<span tabindex="0"
151+
(keydown)="invokeClick($event)"
152+
(click)="enterExpressionEdit(expressionItem)">
151153
<igx-icon
152-
tabindex="0"
153154
family="default"
154-
name="edit"
155-
(keydown)="invokeClick($event)"
156-
(click)="enterExpressionEdit(expressionItem)"
155+
name="edit"
157156
>
158157
</igx-icon>
159158
</span>
160-
<span tabindex="-1">
159+
<span tabindex="0"
160+
(keydown)="invokeClick($event)"
161+
(click)="enterExpressionAdd(expressionItem)">
161162
<igx-icon
162-
tabindex="0"
163163
family="default"
164-
name="add"
165-
(keydown)="invokeClick($event)"
166-
(click)="enterExpressionAdd(expressionItem)"
164+
name="add"
167165
*ngIf="
168166
!expressionItem.inAddMode &&
169167
(expressionItem.parent !== currentGroup ||

0 commit comments

Comments
 (0)