Merge pull request #12399 from IgniteUI/tree-grid-tests

test(tree-grid): refactoring selection tests

Author: dkamburov

.gitignore

@@ -38,6 +38,7 @@ npm-debug.log
 yarn-error.log
 testem.log
 /typings
+TESTS-**.xml
 
 # System Files
 .DS_Store

azure-pipelines.yml

@@ -58,8 +58,8 @@ steps:
     testRunner: 'JUnit'
     testResultsFiles: '**/TESTS-*.xml'
 
-# - task: PublishCodeCoverageResults@1
-#   inputs:
-#     codeCoverageTool: Cobertura
-#     summaryFileLocation: '$(System.DefaultWorkingDirectory)/coverage/cobertura-coverage.xml'
-#     reportDirectory: '$(System.DefaultWorkingDirectory)/coverage'
+- task: PublishCodeCoverageResults@1
+  inputs:
+    codeCoverageTool: Cobertura
+    summaryFileLocation: '$(System.DefaultWorkingDirectory)/coverage/cobertura-coverage.xml'
+    reportDirectory: '$(System.DefaultWorkingDirectory)/coverage'

package-lock.json

@@ -10,7 +10,7 @@
     "e2e": "ng e2e",
     "test:lib": "ng test igniteui-angular --watch=false --no-progress --code-coverage",
     "test:lib:perf": "ng test igniteui-angular --watch=false --no-progress --karma-config=./projects/igniteui-angular/karma.test-perf.conf.js",
-    "test:lib:azure": "ng test igniteui-angular --watch=false --no-progress",
+    "test:lib:azure": "ng test igniteui-angular --watch=false --no-progress --code-coverage --karma-config=./projects/igniteui-angular/karma.azure.conf.js",
     "test:lib:grid": "ng test igniteui-angular --watch=false --no-progress --code-coverage --karma-config=./projects/igniteui-angular/karma.grid.conf.js",
     "test:lib:tgrid": "ng test igniteui-angular --watch=false --no-progress --code-coverage --karma-config=./projects/igniteui-angular/karma.tree-grid.conf.js",
     "test:lib:hgrid": "ng test igniteui-angular --watch=false --no-progress --code-coverage --karma-config=./projects/igniteui-angular/karma.hierarchical-grid.conf.js",
@@ -69,6 +69,7 @@
     "hammerjs": "^2.0.8",
     "igniteui-theming": "^1.2.0",
     "igniteui-trial-watermark": "^1.0.3",
+    "karma-junit-reporter": "^2.0.1",
     "lodash-es": "^4.17.21",
     "rxjs": "^6.6.7",
     "tslib": "^2.3.0",

package.json

@@ -0,0 +1,59 @@
+// Karma configuration file, see link for more information
+// https://karma-runner.github.io/1.0/config/configuration-file.html
+
+module.exports = function (config) {
+  config.set({
+    basePath: '',
+    frameworks: ['parallel', 'jasmine', '@angular-devkit/build-angular'],
+    files: [
+      { pattern: '../../node_modules/hammerjs/hammer.min.js', watched: false },
+      { pattern: '../../node_modules/hammer-simulator/index.js', watched: false },
+      { pattern: './test.css', watched: false },
+      { pattern: '../../dist/igniteui-angular/styles/igniteui-angular.css', watched: false }
+    ],
+    plugins: [
+      'karma-parallel',
+      'karma-jasmine',
+      'karma-coverage',
+      'karma-chrome-launcher',
+      'karma-spec-reporter',
+      'karma-junit-reporter',
+      '@angular-devkit/build-angular/plugins/karma'
+    ],
+    parallelOptions: {
+      executors: 2,
+      shardStrategy: 'round-robin'
+    },
+    client: {
+      //clearContext: false, // leave Jasmine Spec Runner output visible in browser
+      jasmine: {
+        random: false
+      },
+      tagPrefix: '#',
+      skipTags: 'perf'
+    },
+    coverageReporter: {
+      dir: require('path').join(__dirname, '../../coverage'),
+      subdir: '.',
+      reporters: [
+        // reporters not supporting the `file` property
+        { type: 'cobertura' },
+      ]
+    },
+    reporters: ['spec', 'junit'],
+    port: 9876,
+    colors: true,
+    logLevel: config.LOG_INFO,
+    autoWatch: true,
+    browsers: ['ChromeHeadlessNoSandbox'],
+    browserDisconnectTimeout: 4000,
+    customLaunchers: {
+      ChromeHeadlessNoSandbox: {
+        base: 'ChromeHeadless',
+        flags: ['--no-sandbox', '--disable-gpu'],
+        debug: false
+      }
+    },
+    singleRun: false
+  });
+};

projects/igniteui-angular/karma.azure.conf.js

@@ -4,7 +4,7 @@
 module.exports = function (config) {
   config.set({
     basePath: '',
-    frameworks: ['parallel','jasmine', 'jasmine-spec-tags', '@angular-devkit/build-angular'],
+    frameworks: ['parallel', 'jasmine', 'jasmine-spec-tags', '@angular-devkit/build-angular'],
     files: [
       { pattern: '../../node_modules/hammerjs/hammer.min.js', watched: false },
       { pattern: '../../node_modules/hammer-simulator/index.js', watched: false },

projects/igniteui-angular/karma.azure.non-grid.conf.js

@@ -12,19 +12,19 @@ module.exports = function (config) {
       { pattern: '../../dist/igniteui-angular/styles/igniteui-angular.css', watched: false }
     ],
     plugins: [
-        'karma-parallel',
-        'karma-jasmine',
-        'karma-coverage',
-        'karma-chrome-launcher',
-        'karma-spec-reporter',
-        '@angular-devkit/build-angular/plugins/karma'
+      'karma-parallel',
+      'karma-jasmine',
+      'karma-coverage',
+      'karma-chrome-launcher',
+      'karma-spec-reporter',
+      '@angular-devkit/build-angular/plugins/karma'
     ],
     parallelOptions: {
       executors: 2,
       shardStrategy: 'round-robin'
     },
     client: {
-      clearContext: false, // leave Jasmine Spec Runner output visible in browser
+      //clearContext: false, // leave Jasmine Spec Runner output visible in browser
       jasmine: {
         random: false
       },

projects/igniteui-angular/karma.conf.js

@@ -1,7 +1,7 @@
 import { Component, ViewChild, OnInit } from '@angular/core';
 import { IgxActionStripComponent } from '../action-strip.component';
 import { configureTestSuite } from '../../test-utils/configure-suite';
-import { TestBed, fakeAsync, waitForAsync } from '@angular/core/testing';
+import { TestBed, waitForAsync } from '@angular/core/testing';
 import { IgxIconModule } from '../../icon/public_api';
 import { IgxGridModule, IgxGridComponent } from '../../grids/grid/public_api';
 import { NoopAnimationsModule } from '@angular/platform-browser/animations';
@@ -44,15 +44,13 @@ describe('igxGridEditingActions #grid ', () => {
         }).compileComponents();
     }));
 
-
-
     describe('Base ', () => {
-        beforeEach(fakeAsync(/** height/width setter rAF */() => {
+        beforeEach(() => {
             fixture = TestBed.createComponent(IgxActionStripTestingComponent);
             fixture.detectChanges();
             actionStrip = fixture.componentInstance.actionStrip;
             grid = fixture.componentInstance.grid;
-        }));
+        });
 
         it('should allow editing and deleting row', () => {
             let deleteIcon;
@@ -121,12 +119,12 @@ describe('igxGridEditingActions #grid ', () => {
     });
 
     describe('Menu ', () => {
-        beforeEach(fakeAsync(/** height/width setter rAF */() => {
+        beforeEach(() => {
             fixture = TestBed.createComponent(IgxActionStripEditMenuComponent);
             fixture.detectChanges();
             actionStrip = fixture.componentInstance.actionStrip;
             grid = fixture.componentInstance.grid;
-        }));
+        });
         it('should allow editing and deleting row via menu', async () => {
             const row = grid.rowList.toArray()[0];
             actionStrip.show(row);
@@ -180,12 +178,12 @@ describe('igxGridEditingActions #grid ', () => {
     });
 
     describe('integration with pinning actions ', () => {
-        beforeEach(fakeAsync(/** height/width setter rAF */() => {
+        beforeEach(() => {
             fixture = TestBed.createComponent(IgxActionStripPinEditComponent);
             fixture.detectChanges();
             actionStrip = fixture.componentInstance.actionStrip;
             grid = fixture.componentInstance.grid;
-        }));
+        });
         it('should remove editing actions on disabled rows', () => {
             grid.rowList.first.pin();
             fixture.detectChanges();
@@ -200,12 +198,12 @@ describe('igxGridEditingActions #grid ', () => {
     });
 
     describe('auto show/hide', () => {
-        beforeEach(fakeAsync(/** height/width setter rAF */() => {
+        beforeEach(() => {
             fixture = TestBed.createComponent(IgxActionStripPinEditComponent);
             fixture.detectChanges();
             actionStrip = fixture.componentInstance.actionStrip;
             grid = fixture.componentInstance.grid;
-        }));
+        });
         it('should auto-show on mouse enter of row.', () => {
             const row = grid.gridAPI.get_row_by_index(0);
             const rowElem = row.nativeElement;
@@ -249,13 +247,13 @@ describe('igxGridEditingActions #grid ', () => {
 
     describe('auto show/hide in HierarchicalGrid', () => {
         let actionStripRoot; let actionStripChild; let hierarchicalGrid: IgxHierarchicalGridComponent;
-        beforeEach(fakeAsync(/** height/width setter rAF */() => {
+        beforeEach(() => {
             fixture = TestBed.createComponent(IgxHierarchicalGridActionStripComponent);
             fixture.detectChanges();
             actionStripRoot = fixture.componentInstance.actionStripRoot;
             actionStripChild = fixture.componentInstance.actionStripChild;
             hierarchicalGrid = fixture.componentInstance.hgrid;
-        }));
+        });
 
         it('should auto-show root actionStrip on mouse enter of root row.', () => {
             const row = hierarchicalGrid.gridAPI.get_row_by_index(0);

projects/igniteui-angular/src/lib/action-strip/grid-actions/grid-editing-actions.component.spec.ts

@@ -1,7 +1,7 @@
 import { Component, ViewChild, OnInit } from '@angular/core';
 import { IgxActionStripComponent } from '../action-strip.component';
 import { configureTestSuite } from '../../test-utils/configure-suite';
-import { TestBed, fakeAsync, waitForAsync } from '@angular/core/testing';
+import { TestBed, waitForAsync } from '@angular/core/testing';
 import { IgxIconModule } from '../../icon/public_api';
 import { IgxGridModule, IgxGridComponent } from '../../grids/grid/public_api';
 import { NoopAnimationsModule } from '@angular/platform-browser/animations';
@@ -31,12 +31,12 @@ describe('igxGridPinningActions #grid ', () => {
     }));
 
     describe('Base ', () => {
-        beforeEach(fakeAsync(/** height/width setter rAF */() => {
+        beforeEach(() => {
             fixture = TestBed.createComponent(IgxActionStripTestingComponent);
             fixture.detectChanges();
             actionStrip = fixture.componentInstance.actionStrip;
             grid = fixture.componentInstance.grid;
-        }));
+        });
 
         it('should allow pinning and unpinning rows in a grid', () => {
             actionStrip.show(grid.rowList.first);
@@ -80,12 +80,12 @@ describe('igxGridPinningActions #grid ', () => {
     });
 
     describe('Menu ', () => {
-        beforeEach(fakeAsync(/** height/width setter rAF */() => {
+        beforeEach(() => {
             fixture = TestBed.createComponent(IgxActionStripPinMenuComponent);
             fixture.detectChanges();
             actionStrip = fixture.componentInstance.actionStrip;
             grid = fixture.componentInstance.grid;
-        }));
+        });
         it('should allow pinning row via menu', async () => {
             const row = grid.rowList.toArray()[0];
             actionStrip.show(row);

projects/igniteui-angular/src/lib/action-strip/grid-actions/grid-pinning-actions.component.spec.ts

@@ -8,7 +8,7 @@ import { IgxCalendarView } from './month-picker-base';
 import { CurrentResourceStrings } from '../core/i18n/resources';
 import { ICalendarResourceStrings } from '../core/i18n/calendar-resources';
 import { DateTimeUtil } from '../date-common/util/date-time.util';
-import { getLocaleFirstDayOfWeek, getLocaleId } from "@angular/common";
+import { getLocaleFirstDayOfWeek } from "@angular/common";
 
 /**
  * Sets the selection type - single, multi or range.