Skip to content

Commit fddcc63

Browse files
authored
Merge pull request #8280 from IgniteUI/mkirova/add-row-summaries
fix(igxGrid): Fix issue with summary cache clearing when row is added…
2 parents b95934d + d809f3c commit fddcc63

File tree

3 files changed

+20
-2
lines changed

3 files changed

+20
-2
lines changed

projects/igniteui-angular/src/lib/grids/grid-base.directive.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4378,7 +4378,7 @@ export abstract class IgxGridBaseDirective extends DisplayDensityBase implements
43784378
public refreshGridState(args?) {
43794379
this.endEdit(true);
43804380
this.selectionService.clearHeaderCBState();
4381-
this.summaryService.clearSummaryCache(args);
4381+
this.summaryService.clearSummaryCache();
43824382
}
43834383

43844384
// TODO: We have return values here. Move them to event args ??

projects/igniteui-angular/src/lib/grids/grid/grid-add-row.spec.ts

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { NoopAnimationsModule } from '@angular/platform-browser/animations';
33
import { async, TestBed, fakeAsync } from '@angular/core/testing';
44
import { configureTestSuite } from '../../test-utils/configure-suite';
55
import { DebugElement } from '@angular/core';
6-
import { GridFunctions } from '../../test-utils/grid-functions.spec';
6+
import { GridFunctions, GridSummaryFunctions } from '../../test-utils/grid-functions.spec';
77
import {
88
IgxAddRowComponent
99
} from '../../test-utils/grid-samples.spec';
@@ -14,6 +14,7 @@ import { IgxActionStripModule } from '../../action-strip/action-strip.module';
1414
import { UIInteractions, wait } from '../../test-utils/ui-interactions.spec';
1515

1616
describe('IgxGrid - Row Adding #grid', () => {
17+
const SUMMARY_ROW = 'igx-grid-summary-row';
1718
let fixture;
1819
let grid: IgxGridComponent;
1920
let gridContent: DebugElement;
@@ -196,5 +197,21 @@ describe('IgxGrid - Row Adding #grid', () => {
196197
expect(rowOffsets.top >= gridOffsets.top && rowOffsets.bottom <= gridOffsets.bottom).toBeTruthy();
197198
});
198199

200+
it('should update summaries after row is added via the UI.', () => {
201+
grid.getColumnByName('ID').hasSummary = true;
202+
fixture.detectChanges();
203+
let summaryRow = fixture.debugElement.query(By.css(SUMMARY_ROW));
204+
GridSummaryFunctions.verifyColumnSummaries(summaryRow, 0, ['Count'], ['27']);
205+
206+
grid.rowList.first.beginAddRow();
207+
fixture.detectChanges();
208+
209+
grid.endEdit(true);
210+
fixture.detectChanges();
211+
212+
summaryRow = fixture.debugElement.query(By.css(SUMMARY_ROW));
213+
GridSummaryFunctions.verifyColumnSummaries(summaryRow, 0, ['Count'], ['28']);
214+
});
215+
199216
});
200217
});

src/app/grid-add-row/grid-add-row.sample.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
[pinned]="c.pinned"
2020
[hidden]="c.hidden"
2121
[groupable]='true'
22+
[hasSummary]="true"
2223
>
2324
</igx-column>
2425

0 commit comments

Comments
 (0)