Skip to content

Commit ff04f49

Browse files
committed
fix(dropdown): fix typography for boostrap and fluent themes,
- fix unused typography for selected item for all themes
1 parent bc6338a commit ff04f49

File tree

3 files changed

+18
-8
lines changed

3 files changed

+18
-8
lines changed

projects/igniteui-angular/src/lib/core/styles/components/drop-down/_drop-down-theme.scss

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -327,16 +327,16 @@
327327
}
328328
}
329329

330-
/// Adds typography styles for the igx-list component.
331-
/// Uses the 'caption' and 'subtitle-2'
330+
/// Adds typography styles for the igx-drop-down component.
331+
/// Uses the 'overline', 'body-2', 'subtitle-1'
332332
/// categories from the typographic scale.
333333
/// @group typography
334-
/// @param {Map} $categories [(header: 'overline', item: 'body-2', select-item: 'subtitle-1')] - The categories from the typographic scale used for type styles.
334+
/// @param {Map} $categories [(header: 'overline', item: 'body-2', select-item: 'body-2')] - The categories from the typographic scale used for type styles.
335335
@mixin drop-down-typography(
336336
$categories: (
337337
header: 'overline',
338338
item: 'body-2',
339-
select-item: 'subtitle-1'
339+
select-item: 'body-2'
340340
)
341341
) {
342342
$header: map.get($categories, 'header');
@@ -355,4 +355,10 @@
355355
margin: 0;
356356
}
357357
}
358+
359+
%igx-drop-down__item--selected {
360+
@include type-style($select-item) {
361+
margin: 0;
362+
}
363+
}
358364
}

projects/igniteui-angular/src/lib/core/styles/typography/_bootstrap.scss

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,9 @@
6363
));
6464
@include dock-manager-typography();
6565
@include drop-down-typography($categories: (
66-
header: 'body-1',
67-
item: 'body-1',
68-
select-item: 'body-1'
66+
header: 'overline',
67+
item: 'body-2',
68+
select-item: 'body-2'
6969
));
7070
@include expansion-panel-typography($categories: (
7171
title: 'h5',

projects/igniteui-angular/src/lib/core/styles/typography/_fluent.scss

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,11 @@
6262
@include date-range-typography();
6363
@include dialog-typography();
6464
@include dock-manager-typography();
65-
@include drop-down-typography();
65+
@include drop-down-typography($categories: (
66+
header: 'subtitle-2',
67+
item: 'body-2',
68+
select-item: 'body-2'
69+
));
6670
@include expansion-panel-typography($categories: (
6771
title: 'subtitle-1',
6872
description: 'body-2',

0 commit comments

Comments
 (0)