Skip to content

fix(column): use minWidth when sizing columns - 20.0.x #16135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 21, 2025
Merged

fix(column): use minWidth when sizing columns - 20.0.x #16135

merged 7 commits into from
Aug 21, 2025

Conversation

RivaIvanova
Copy link
Member

Closes #16057

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@RivaIvanova RivaIvanova linked an issue Aug 13, 2025 that may be closed by this pull request
minWidth doesn't override the default 136px min width when autosizing columns without width #16057
Closed
@RivaIvanova RivaIvanova requested a review from MayaKirova August 13, 2025 05:43
@ChronosSF ChronosSF self-requested a review August 19, 2025 08:28
ChronosSF
ChronosSF requested changes Aug 19, 2025
View reviewed changes
Copy link
Member

@ChronosSF ChronosSF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just trim the unnecessary minWidthSetByUser property. Since you are not doing anything in the getter or setter, the whole functionality can be handled by the (then) public member behind it.

@ddaribo ddaribo added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Aug 20, 2025
@ddaribo ddaribo added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Aug 20, 2025
@ChronosSF ChronosSF self-requested a review August 21, 2025 12:32
@ChronosSF ChronosSF merged commit bb7916f into 20.0.x Aug 21, 2025
5 checks passed
@ChronosSF ChronosSF deleted the rivanova/fix-16057-20.0.x branch August 21, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChronosSF ChronosSF ChronosSF approved these changes

@MayaKirova MayaKirova MayaKirova approved these changes

Assignees

@ddaribo ddaribo

Labels
grid: column-resizing version: 20.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

minWidth doesn't override the default 136px min width when autosizing columns without width
5 participants
@RivaIvanova @ChronosSF @MayaKirova @ddaribo @Lipata