Skip to content

Commit 085bf44

Browse files
Hristo313Hristo313
authored
update node version in yml files and fix build logic for angular templates (#1330)
1 parent af04fe6 commit 085bf44

File tree

12 files changed

+36
-30
lines changed

12 files changed

+36
-30
lines changed

‎packages/cli/templates/react/igr-ts/projects/_base/files/__dot__github/workflows/github.io.yml‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ on:
88

99
jobs:
1010
build-and-deploy:
11-
11+
# Deactivate the workflow. Will be changed when AB is ready
12+
if: false
1213
runs-on: ubuntu-latest
1314

1415
permissions:
@@ -17,7 +18,7 @@ jobs:
1718

1819
strategy:
1920
matrix:
20-
node-version: [18.x, 20.x]
21+
node-version: [22.x]
2122

2223
steps:
2324
- uses: actions/checkout@v3

‎packages/cli/templates/react/igr-ts/projects/_base/files/__dot__github/workflows/node.js.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616

1717
strategy:
1818
matrix:
19-
node-version: [18.x, 20.x]
19+
node-version: [22.x]
2020
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/
2121

2222
steps:

‎packages/cli/templates/webcomponents/igc-ts/projects/_base/files/__dot__github/workflows/github.io.yml‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ on:
88

99
jobs:
1010
build-and-deploy:
11-
11+
# Deactivate the workflow. Will be changed when AB is ready
12+
if: false
1213
runs-on: ubuntu-latest
1314

1415
permissions:
@@ -17,7 +18,7 @@ jobs:
1718

1819
strategy:
1920
matrix:
20-
node-version: [18.x, 20.x]
21+
node-version: [22.x]
2122

2223
steps:
2324
- uses: actions/checkout@v3

‎packages/cli/templates/webcomponents/igc-ts/projects/_base/files/__dot__github/workflows/node.js.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616

1717
strategy:
1818
matrix:
19-
node-version: [18.x, 20.x]
19+
node-version: [22.x]
2020
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/
2121

2222
steps:

‎packages/igx-templates/igx-ts-legacy/projects/_base/files/__dot__github/workflows/github.io.yml‎

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ on:
88

99
jobs:
1010
build-and-deploy:
11-
11+
# Deactivate the workflow. Will be changed when AB is ready
12+
if: false
1213
runs-on: ubuntu-latest
1314

1415
permissions:
@@ -17,7 +18,7 @@ jobs:
1718

1819
strategy:
1920
matrix:
20-
node-version: [18.x, 20.x]
21+
node-version: [22.x]
2122

2223
steps:
2324
- uses: actions/checkout@v3
@@ -31,10 +32,10 @@ jobs:
3132
run: echo "PROJECT_NAME=$(jq -r '.name' package.json)" >> $GITHUB_ENV
3233
- name: Determine if project is standalone and set build path
3334
run: |
34-
if jq -e ".projects[\"${{ env.PROJECT_NAME }}\"].schematics[\"@schematics/angular:application\"].standalone == false" angular.json > /dev/null; then
35-
echo "BUILD_PATH=./dist/${{ env.PROJECT_NAME }}" >> $GITHUB_ENV
36-
else
35+
if jq -e ".projects[\"${{ env.PROJECT_NAME }}\"].architect.build.builder == \"@angular-devkit/build-angular:application\"" angular.json > /dev/null; then
3736
echo "BUILD_PATH=./dist/${{ env.PROJECT_NAME }}/browser" >> $GITHUB_ENV
37+
else
38+
echo "BUILD_PATH=./dist/${{ env.PROJECT_NAME }}" >> $GITHUB_ENV
3839
fi
3940
- name: Build project with dynamic base-href
4041
run: npm run build -- --base-href "/${{ github.event.repository.name }}/"

‎packages/igx-templates/igx-ts-legacy/projects/_base/files/__dot__github/workflows/node.js.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919

2020
strategy:
2121
matrix:
22-
node-version: [18.x, 20.x]
22+
node-version: [22.x]
2323
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/
2424

2525
steps:

‎packages/igx-templates/igx-ts-legacy/projects/_base_with_home/files/__dot__github/workflows/github.io.yml‎

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ on:
88

99
jobs:
1010
build-and-deploy:
11-
11+
# Deactivate the workflow. Will be changed when AB is ready
12+
if: false
1213
runs-on: ubuntu-latest
1314

1415
permissions:
@@ -17,7 +18,7 @@ jobs:
1718

1819
strategy:
1920
matrix:
20-
node-version: [18.x, 20.x]
21+
node-version: [22.x]
2122

2223
steps:
2324
- uses: actions/checkout@v3
@@ -31,10 +32,10 @@ jobs:
3132
run: echo "PROJECT_NAME=$(jq -r '.name' package.json)" >> $GITHUB_ENV
3233
- name: Determine if project is standalone and set build path
3334
run: |
34-
if jq -e ".projects[\"${{ env.PROJECT_NAME }}\"].schematics[\"@schematics/angular:application\"].standalone == false" angular.json > /dev/null; then
35-
echo "BUILD_PATH=./dist/${{ env.PROJECT_NAME }}" >> $GITHUB_ENV
36-
else
35+
if jq -e ".projects[\"${{ env.PROJECT_NAME }}\"].architect.build.builder == \"@angular-devkit/build-angular:application\"" angular.json > /dev/null; then
3736
echo "BUILD_PATH=./dist/${{ env.PROJECT_NAME }}/browser" >> $GITHUB_ENV
37+
else
38+
echo "BUILD_PATH=./dist/${{ env.PROJECT_NAME }}" >> $GITHUB_ENV
3839
fi
3940
- name: Build project with dynamic base-href
4041
run: npm run build -- --base-href "/${{ github.event.repository.name }}/"

‎packages/igx-templates/igx-ts-legacy/projects/_base_with_home/files/__dot__github/workflows/node.js.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919

2020
strategy:
2121
matrix:
22-
node-version: [18.x, 20.x]
22+
node-version: [22.x]
2323
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/
2424

2525
steps:

‎packages/igx-templates/igx-ts/projects/_base/files/__dot__github/workflows/github.io.yml‎

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ on:
88

99
jobs:
1010
build-and-deploy:
11-
11+
# Deactivate the workflow. Will be changed when AB is ready
12+
if: false
1213
runs-on: ubuntu-latest
1314

1415
permissions:
@@ -17,7 +18,7 @@ jobs:
1718

1819
strategy:
1920
matrix:
20-
node-version: [18.x, 20.x]
21+
node-version: [22.x]
2122

2223
steps:
2324
- uses: actions/checkout@v3
@@ -31,10 +32,10 @@ jobs:
3132
run: echo "PROJECT_NAME=$(jq -r '.name' package.json)" >> $GITHUB_ENV
3233
- name: Determine if project is standalone and set build path
3334
run: |
34-
if jq -e ".projects[\"${{ env.PROJECT_NAME }}\"].schematics[\"@schematics/angular:application\"].standalone == false" angular.json > /dev/null; then
35-
echo "BUILD_PATH=./dist/${{ env.PROJECT_NAME }}" >> $GITHUB_ENV
36-
else
35+
if jq -e ".projects[\"${{ env.PROJECT_NAME }}\"].architect.build.builder == \"@angular-devkit/build-angular:application\"" angular.json > /dev/null; then
3736
echo "BUILD_PATH=./dist/${{ env.PROJECT_NAME }}/browser" >> $GITHUB_ENV
37+
else
38+
echo "BUILD_PATH=./dist/${{ env.PROJECT_NAME }}" >> $GITHUB_ENV
3839
fi
3940
- name: Build project with dynamic base-href
4041
run: npm run build -- --base-href "/${{ github.event.repository.name }}/"

‎packages/igx-templates/igx-ts/projects/_base/files/__dot__github/workflows/node.js.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919

2020
strategy:
2121
matrix:
22-
node-version: [18.x, 20.x]
22+
node-version: [22.x]
2323
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/
2424

2525
steps:

0 commit comments

Comments
 (0)