remove deployment script flag and if condition in github pages workflow (#1351)

Hristo313 · web-flow · commit cdf8f4b875eb · 2024-11-28T15:37:47.000+02:00
diff --git a/packages/cli/package.json b/packages/cli/package.json
@@ -1,6 +1,6 @@
 {
   "name": "igniteui-cli",
-  "version": "14.3.1",
+  "version": "14.3.2-beta.0",
   "description": "CLI tool for creating Ignite UI projects",
   "keywords": [
     "CLI",
@@ -78,8 +78,8 @@
     "all": true
   },
   "dependencies": {
-    "@igniteui/angular-templates": "~19.0.1431",
-    "@igniteui/cli-core": "~14.3.1",
+    "@igniteui/angular-templates": "~19.0.1432-beta.0",
+    "@igniteui/cli-core": "~14.3.2-beta.0",
     "@inquirer/prompts": "^5.4.0",
     "@types/yargs": "^17.0.33",
     "chalk": "^5.3.0",
diff --git a/packages/cli/templates/react/igr-ts/projects/_base/files/__dot__github/workflows/github-pages.yml b/packages/cli/templates/react/igr-ts/projects/_base/files/__dot__github/workflows/github-pages.yml
@@ -7,7 +7,7 @@ on:
 
 jobs:
   build-and-deploy:
-    if: $(yamlGenerateDeploymentScript) == true
+
     runs-on: ubuntu-latest
 
     permissions:
@@ -38,7 +38,7 @@ jobs:
     - name: Copy Resources to dist
       run: mkdir -p ./dist/assets && cp -R ./src/assets/* ./dist/assets/
     - name: SPA routing handling
-      run: cp .dist/index.html .dist/404.html
+      run: cp ./dist/index.html ./dist/404.html
     - name: Upload build artifact to GitHub Pages
       uses: actions/upload-pages-artifact@v1
       with:
diff --git a/packages/cli/templates/react/igr-ts/projects/_base/index.ts b/packages/cli/templates/react/igr-ts/projects/_base/index.ts
@@ -42,8 +42,7 @@ export class BaseIgrTsProject implements ProjectTemplate {
 			"dot": ".",
 			"path": name,
 			"projectTemplate": this.id,
-			"yamlDefaultBranch": this.id === "base" ? "<%=yaml-default-branch%>" : "main",
-			"yamlGenerateDeploymentScript": "<%=yaml-generate-deployment-script%>"
+			"yamlDefaultBranch": this.id === "base" ? "<%=yaml-default-branch%>" : "main"
 		};
 	}
 }
diff --git a/packages/cli/templates/webcomponents/igc-ts/projects/_base/files/__dot__github/workflows/github-pages.yml b/packages/cli/templates/webcomponents/igc-ts/projects/_base/files/__dot__github/workflows/github-pages.yml
@@ -7,7 +7,7 @@ on:
 
 jobs:
   build-and-deploy:
-    if: $(yamlGenerateDeploymentScript) == true
+
     runs-on: ubuntu-latest
 
     permissions:
@@ -40,7 +40,7 @@ jobs:
     - name: Update href Paths for ig-theme.css
       run: find ./dist -type f -exec sed -i "s|href=\"../../ig-theme.css\"|href=\"../../${{ github.event.repository.name }}/ig-theme.css\"|g" {} +
     - name: SPA routing handling
-      run: cp .dist/index.html .dist/404.html
+      run: cp ./dist/index.html ./dist/404.html
     - name: Upload build artifact to GitHub Pages
       uses: actions/upload-pages-artifact@v1
       with:
diff --git a/packages/cli/templates/webcomponents/igc-ts/projects/_base/index.ts b/packages/cli/templates/webcomponents/igc-ts/projects/_base/index.ts
@@ -37,8 +37,7 @@ export class BaseIgcProject implements ProjectTemplate {
 			dot: ".",
 			path: name,
 			projectTemplate: this.id,
-			yamlDefaultBranch: this.id === "base" ? "<%=yaml-default-branch%>" : "main",
-			yamlGenerateDeploymentScript: "<%=yaml-generate-deployment-script%>"
+			yamlDefaultBranch: this.id === "base" ? "<%=yaml-default-branch%>" : "main"
 		};
 
 		return config;
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@igniteui/cli-core",
-  "version": "14.3.1",
+  "version": "14.3.2-beta.0",
   "description": "Base types and functionality for Ignite UI CLI",
   "repository": {
     "type": "git",
diff --git a/packages/igx-templates/igx-ts-legacy/projects/_base/files/__dot__github/workflows/github-pages.yml b/packages/igx-templates/igx-ts-legacy/projects/_base/files/__dot__github/workflows/github-pages.yml
@@ -7,7 +7,7 @@ on:
 
 jobs:
   build-and-deploy:
-    if: <%=yamlGenerateDeploymentScript%> == true
+
     runs-on: ubuntu-latest
 
     permissions:
diff --git a/packages/igx-templates/igx-ts-legacy/projects/_base/index.ts b/packages/igx-templates/igx-ts-legacy/projects/_base/index.ts
@@ -66,8 +66,7 @@ $app-palette: palette($primary, $secondary, $surface);
 			path: name,
 			projectTemplate: this.id,
 			yamlDefaultBranch: "<%=yaml-default-branch%>", // the placeholder will be evaluated by CodeGen
-			ApplicationTitle: "<%=ApplicationTitle%>", // the placeholder will be evaluated by CodeGen
-			yamlGenerateDeploymentScript: "<%=yaml-generate-deployment-script%>" // the placeholder will be evaluated by CodeGen
+			ApplicationTitle: "<%=ApplicationTitle%>" // the placeholder will be evaluated by CodeGen
 		};
 
 		switch (theme) {
diff --git a/packages/igx-templates/igx-ts-legacy/projects/_base_with_home/files/__dot__github/workflows/github-pages.yml b/packages/igx-templates/igx-ts-legacy/projects/_base_with_home/files/__dot__github/workflows/github-pages.yml
@@ -7,7 +7,7 @@ on:
 
 jobs:
   build-and-deploy:
-    if: <%=yamlGenerateDeploymentScript%> == true
+
     runs-on: ubuntu-latest
 
     permissions:
diff --git a/packages/igx-templates/igx-ts/projects/_base/files/__dot__github/workflows/github-pages.yml b/packages/igx-templates/igx-ts/projects/_base/files/__dot__github/workflows/github-pages.yml
@@ -7,7 +7,7 @@ on:
 
 jobs:
   build-and-deploy:
-    if: <%=yamlGenerateDeploymentScript%> == true
+
     runs-on: ubuntu-latest
 
     permissions:
diff --git a/packages/igx-templates/igx-ts/projects/_base/index.ts b/packages/igx-templates/igx-ts/projects/_base/index.ts
@@ -67,8 +67,7 @@ $app-palette: palette($primary, $secondary, $surface);
 			projectTemplate: this.id,
 			igxPackage: NPM_ANGULAR,
 			yamlDefaultBranch: "<%=yaml-default-branch%>", // the placeholder will be evaluated by CodeGen
-			ApplicationTitle: "<%=ApplicationTitle%>", // the placeholder will be evaluated by CodeGen
-			yamlGenerateDeploymentScript: "<%=yaml-generate-deployment-script%>" // the placeholder will be evaluated by CodeGen
+			ApplicationTitle: "<%=ApplicationTitle%>" // the placeholder will be evaluated by CodeGen
 		};
 
 		switch (theme) {
diff --git a/packages/igx-templates/igx-ts/projects/_base_with_home/files/__dot__github/workflows/github-pages.yml b/packages/igx-templates/igx-ts/projects/_base_with_home/files/__dot__github/workflows/github-pages.yml
@@ -7,7 +7,7 @@ on:
 
 jobs:
   build-and-deploy:
-    if: <%=yamlGenerateDeploymentScript%> == true
+
     runs-on: ubuntu-latest
 
     permissions:
diff --git a/packages/igx-templates/package.json b/packages/igx-templates/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@igniteui/angular-templates",
-  "version": "19.0.1431",
+  "version": "19.0.1432-beta.0",
   "description": "Templates for Ignite UI for Angular projects and components",
   "repository": {
     "type": "git",
@@ -12,7 +12,7 @@
   "author": "Infragistics",
   "license": "MIT",
   "dependencies": {
-    "@igniteui/cli-core": "~14.3.1",
+    "@igniteui/cli-core": "~14.3.2-beta.0",
     "typescript": "~5.5.4"
   }
 }
diff --git a/packages/ng-schematics/package.json b/packages/ng-schematics/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@igniteui/angular-schematics",
-  "version": "19.0.1431",
+  "version": "19.0.1432-beta.0",
   "description": "Ignite UI for Angular Schematics for ng new and ng generate",
   "repository": {
     "type": "git",
@@ -20,8 +20,8 @@
   "dependencies": {
     "@angular-devkit/core": "^19.0.0",
     "@angular-devkit/schematics": "^19.0.0",
-    "@igniteui/angular-templates": "~19.0.1431",
-    "@igniteui/cli-core": "~14.3.1",
+    "@igniteui/angular-templates": "~19.0.1432-beta.0",
+    "@igniteui/cli-core": "~14.3.2-beta.0",
     "@schematics/angular": "~19.0.0",
     "rxjs": "^7.8.1",
     "minimatch": "^10.0.1"

Original file line number	Diff line number	Diff line change
`@@ -42,8 +42,7 @@ export class BaseIgrTsProject implements ProjectTemplate {`
`42`	`42`	`"dot": ".",`
`43`	`43`	`"path": name,`
`44`	`44`	`"projectTemplate": this.id,`
`45`		`- "yamlDefaultBranch": this.id === "base" ? "<%=yaml-default-branch%>" : "main",`
`46`		`- "yamlGenerateDeploymentScript": "<%=yaml-generate-deployment-script%>"`
	`45`	`+ "yamlDefaultBranch": this.id === "base" ? "<%=yaml-default-branch%>" : "main"`
`47`	`46`	`};`
`48`	`47`	`}`
`49`	`48`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@igniteui/cli-core",`
`3`		`- "version": "14.3.1",`
	`3`	`+ "version": "14.3.2-beta.0",`
`4`	`4`	`"description": "Base types and functionality for Ignite UI CLI",`
`5`	`5`	`"repository": {`
`6`	`6`	`"type": "git",`