feat(ng): use ng lint schematic (#1439)

* feat: use ng lint schematic to configure project

* fix: lint according to new config

* fix: resolve lint errors in template

* chore: release 14.6.5-beta.0

* chore: disable eqeqeq

Author: Lipata

packages/cli/package.json

@@ -1,6 +1,6 @@
 {
   "name": "igniteui-cli",
-  "version": "14.6.4",
+  "version": "14.6.5-beta.0",
   "description": "CLI tool for creating Ignite UI projects",
   "keywords": [
     "CLI",
@@ -76,8 +76,8 @@
     "all": true
   },
   "dependencies": {
-    "@igniteui/angular-templates": "~20.1.1464",
-    "@igniteui/cli-core": "~14.6.4",
+    "@igniteui/angular-templates": "~20.1.1465-beta.0",
+    "@igniteui/cli-core": "~14.6.5-beta.0",
     "@inquirer/prompts": "^5.4.0",
     "@types/yargs": "^17.0.33",
     "chalk": "^5.3.0",

packages/core/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@igniteui/cli-core",
-  "version": "14.6.4",
+  "version": "14.6.5-beta.0",
   "description": "Base types and functionality for Ignite UI CLI",
   "repository": {
     "type": "git",

packages/igx-templates/igx-ts/carousel/default/files/src/app/__path__/__filePrefix__.component.ts

@@ -14,7 +14,6 @@ export class <%=ClassName%>Component implements OnInit {
   public interval = 3000;
   public pause = true;
   public loop = true;
-  constructor() { }
 
   public ngOnInit() {
     this.addNewSlide();

packages/igx-templates/igx-ts/custom-templates/awesome-grid/files/src/app/__path__/__filePrefix__.component.ts

@@ -17,7 +17,6 @@ import {
   IgxOverlayService,
   IgxStringFilteringOperand,
   IgxSummaryResult,
-  OverlayClosingEventArgs,
   OverlaySettings,
   IgxSwitchComponent,
   IgxInputGroupComponent,
@@ -86,10 +85,10 @@ export class <%=ClassName%>Component implements OnInit, OnDestroy, AfterViewInit
   public overlaySettings!: OverlaySettings;
   public winner: Athlete = { Avatar: '', Name: '' } as Athlete;
   public top3: Athlete[] = [];
-  private _live: boolean = true;
+  private _live = true;
   private _timer: any;
   private windowWidth: any;
-  private _overlayId: string = '';
+  private _overlayId = '';
 
   get live(): boolean {
     return this._live;
@@ -127,7 +126,7 @@ export class <%=ClassName%>Component implements OnInit, OnDestroy, AfterViewInit
     this.localData.forEach(rec => this.getSpeed(rec));
     this.windowWidth = window.innerWidth;
     this._timer = setInterval(() => this.ticker(), 1500);
-    this.overlayService.closing.subscribe((event: OverlayClosingEventArgs) => {
+    this.overlayService.closing.subscribe(() => {
       this.showOverlay = false;
     });
   }

packages/igx-templates/igx-ts/custom-templates/crm-grid/files/src/app/__path__/__filePrefix__.component.ts

@@ -94,8 +94,8 @@ export class <%=ClassName%>Component implements OnInit, AfterViewInit {
   public soonSummary = SoonSummary;
 
   public cols!: QueryList<ColumnType>;
-  public hiddenColsLength: number = 0;
-  public pinnedColsLength: number = 0;
+  public hiddenColsLength = 0;
+  public pinnedColsLength = 0;
 
   public searchText = '';
   public caseSensitive = false;

packages/igx-templates/igx-ts/custom-templates/crm-grid/files/src/app/__path__/data.ts

@@ -34,7 +34,6 @@ export interface Employee {
     tags: string;
 }
 
-/* tslint:disable */
 export const DATA: Employee[] = [
     { "id": 256286239, "avatar": "assets/images/men/43.jpg", "name": "Gawain Beadnall", "email": "[email protected]", "company": "Divanoodle", "position": "Statistician I", "work_phone": "+1-317-866-4381", "mobile_phone": "+1-203-937-3567", "fax": "+1-212-115-1790", "street": "47 Garrison Park", "city": "Indianapolis", "post_code": 46207, "state": "IN", "country": "United States", "referred_by": "Vyky Corwin", "created_on": new Date("12/8/2017"), "birthday": new Date("2/10/2002"), "last_activity": new Date("12/16/2017"), "next_activity": new Date("4/16/2019"), "deals_won": 5, "deals_lost": 13, "deals_pending": 7, "deals_total": 25, "ratio": 28, "estimated_sales": 686210, "actual_sales": 421105, "tags": "warm, engineering" },
     { "id": 863241310, "avatar": "assets/images/women/40.jpg", "name": "Ivy Simkovich", "email": "[email protected]", "company": "Linktype", "position": "Research Nurse", "work_phone": "+1-770-283-2050", "mobile_phone": "+1-509-995-2578", "fax": "+1-907-491-2187", "street": "3 Aberg Street", "city": "Marietta", "post_code": 30061, "state": "GA", "country": "United States", "referred_by": "Hew Chung", "created_on": new Date("6/24/2017"), "birthday": new Date("1/1/1997"), "last_activity": new Date("7/15/2017"), "next_activity": new Date("6/15/2019"), "deals_won": 2, "deals_lost": 4, "deals_pending": 29, "deals_total": 35, "ratio": 33, "estimated_sales": 2008801, "actual_sales": 186592, "tags": "demo, medical" },
@@ -487,4 +486,3 @@ export const DATA: Employee[] = [
     { "id": 75323534, "avatar": "assets/images/women/52.jpg", "name": "Lorena Mousdall", "email": "[email protected]", "company": "Aimbo", "position": "Geologist III", "work_phone": "+1-720-341-5046", "mobile_phone": "+1-916-195-7584", "fax": "+1-215-624-1834", "street": "12 Melby Place", "city": "Denver", "post_code": 80241, "state": "CO", "country": "United States", "referred_by": "Carmina Tomaszek", "created_on": new Date("3/13/2017"), "birthday": new Date("9/13/1978"), "last_activity": new Date("3/24/2017"), "next_activity": new Date("10/24/2018"), "deals_won": 14, "deals_lost": 11, "deals_pending": 2, "deals_total": 27, "ratio": 56, "estimated_sales": 300438, "actual_sales": 1338988, "tags": "cool, engineering" },
     { "id": 46063202, "avatar": "assets/images/women/71.jpg", "name": "Gayle St Pierre", "email": "[email protected]", "company": "Trupe", "position": "VP Accounting", "work_phone": "+1-530-168-6924", "mobile_phone": "+1-646-366-5359", "fax": "+1-757-548-1834", "street": "48 Veith Junction", "city": "Chico", "post_code": 95973, "state": "CA", "country": "United States", "referred_by": "Lynda Drinan", "created_on": new Date("3/26/2017"), "birthday": new Date("3/10/1971"), "last_activity": new Date("4/17/2017"), "next_activity": new Date("10/17/2018"), "deals_won": 13, "deals_lost": 14, "deals_pending": 9, "deals_total": 36, "ratio": 48, "estimated_sales": 1716966, "actual_sales": 668928, "tags": "cold, medical" },
     { "id": 743401827, "avatar": "assets/images/women/56.jpg", "name": "Romy Giacomelli", "email": "[email protected]", "company": "Eimbee", "position": "Cost Accountant", "work_phone": "+1-719-646-0552", "mobile_phone": "+1-203-707-2786", "fax": "+1-214-685-1141", "street": "952 Springs Alley", "city": "Colorado Springs", "post_code": 80915, "state": "CO", "country": "United States", "referred_by": "Alanna Begg", "created_on": new Date("11/18/2017"), "birthday": new Date("10/16/1982"), "last_activity": new Date("12/2/2017"), "next_activity": new Date("2/2/2018"), "deals_won": 5, "deals_lost": 13, "deals_pending": 8, "deals_total": 26, "ratio": 28, "estimated_sales": 1423424, "actual_sales": 949815, "tags": "subscriber, construction" }];
-/* tslint:enable */

packages/igx-templates/igx-ts/custom-templates/fintech-grid/files/src/app/__path__/__filePrefix__.component.html

@@ -5,7 +5,7 @@
         <igx-switch [checked]="true" [(ngModel)]="theme" (change)="onThemeChanged($event)">Dark</igx-switch>
       </div>
       <div class="control-item">
-        <igx-switch [checked]="grouped" (change)="onChange($event)"
+        <igx-switch [checked]="grouped" (change)="onChange()"
           cssClass="fintech-sample-switch">
           Grouped</igx-switch>
       </div>
@@ -203,7 +203,7 @@
 </div>
 
 <igx-dialog #dialog [closeOnOutsideSelect]="true" (closed)="onCloseHandler()">
-  <div (keydown)="closeDialog($event)">
+  <div (keydown)="closeDialog($event)" tabindex="0">
     <igx-dialog-title> Chart </igx-dialog-title>
 
     <div style="padding: 20px">

packages/igx-templates/igx-ts/custom-templates/fintech-grid/files/src/app/__path__/__filePrefix__.component.ts

@@ -93,13 +93,13 @@ export class <%=ClassName%>Component implements OnInit, AfterViewInit, OnDestroy
   @ViewChild('chart1', { static: true }) public chart1!: IgxCategoryChartComponent;
   @ViewChild('dialog', { static: true }) public dialog!: IgxDialogComponent;
 
-  public showToolbar: boolean = false;
+  public showToolbar = false;
   public properties: string[] = [];
   public selectionMode: GridSelectionMode = 'multiple';
   public chartType = CategoryChartType;
-  public theme: boolean = false;
-  public volume: number = 1000;
-  public frequency: number = 500;
+  public theme = false;
+  public volume = 1000;
+  public frequency = 500;
   public data: any[] = [];
   public chartData: any[] = [];
   public multiCellSelection: { data: any[] } = { data: [] };
@@ -133,7 +133,7 @@ export class <%=ClassName%>Component implements OnInit, AfterViewInit, OnDestroy
   public contracts = Contract;
   public regions = REGIONS;
   private subscription: any;
-  private selectedButton: number = -1;
+  private selectedButton = -1;
   private timer: any;
   private volumeChanged: any;
   constructor(
@@ -166,7 +166,7 @@ export class <%=ClassName%>Component implements OnInit, AfterViewInit, OnDestroy
     ];
     this.volumeChanged = this.volumeSlider.valueChange.pipe(debounce(() => timer(200)));
     this.volumeChanged.subscribe(
-      (x: any) => {
+      () => {
         this.localService.getData(this.volume);
       },
       (err: string) => console.log('Error: ' + err));
@@ -250,7 +250,7 @@ export class <%=ClassName%>Component implements OnInit, AfterViewInit, OnDestroy
     }
   }
 
-  public onChange(event: IChangeCheckboxEventArgs): void {
+  public onChange(): void {
     if (this.grid1.groupingExpressions.length > 0) {
       this.grid1.groupingExpressions = [];
     } else {
@@ -364,11 +364,10 @@ export class <%=ClassName%>Component implements OnInit, AfterViewInit, OnDestroy
   private strongPositive = (rowData: any): boolean => {
     return rowData['Change(%)'] >= 1;
   }
-  private strongNegative = (rowData: any, key: string): boolean => {
+  private strongNegative = (rowData: any): boolean => {
     return rowData['Change(%)'] <= -1;
   }
 
-  // tslint:disable:member-ordering
   public trends = {
     changeNeg: this.changeNegative,
     changePos: this.changePositive,
@@ -431,8 +430,6 @@ export class <%=ClassName%>Component implements OnInit, AfterViewInit, OnDestroy
     }
   }
 
-  // tslint:enable:member-ordering
-
   private disableOtherButtons(ind: number, disableButtons: boolean): void {
     if (this.subscription) {
       this.subscription.unsubscribe();
@@ -480,9 +477,8 @@ export class <%=ClassName%>Component implements OnInit, AfterViewInit, OnDestroy
    */
   private updateRandomPrices(data: any[]): any {
     const newData = data.slice();
-    for (let i = Math.round(Math.random() * 10), y = 0; i < data.length; i += Math.round(Math.random() * 10)) {
+    for (let i = Math.round(Math.random() * 10); i < data.length; i += Math.round(Math.random() * 10)) {
       newData[i] = this.randomizeObjectData(data[i]);
-      y++;
     }
     return newData;
   }

packages/igx-templates/igx-ts/custom-templates/fintech-grid/files/src/app/__path__/localData.service.ts

@@ -12,7 +12,7 @@ export class LocalDataService {
     this.records = this.records$.asObservable();
   }
 
-  public getData(count: number = 10) {
+  public getData(count = 10) {
     const financialData: FinancialData = new FinancialData();
     this.records$.next(financialData.generateData(count));
   }

packages/igx-templates/igx-ts/custom-templates/fintech-grid/files/src/app/__path__/localData/financialData.ts

@@ -1,4 +1,3 @@
-/* tslint:disable */
 export const REGIONS: any[] = [
   {
     "Region": "North America",
@@ -48,7 +47,6 @@ export const MOCKFINANCEDATA: any[] = [
   "IndSect": "Consumer, Cyclical",
   "IndSubg": "Airlines",
   "SecType": "PUBLIC",
-  // tslint:disable-next-line:object-literal-sort-keys
   "CpnTyp": "FIXED",
   "IssuerN": "AMERICAN AIRLINES GROUP",
   "Moodys": "WR",
@@ -887,7 +885,6 @@ interface IResponse {
   data: any[];
   recordsUpdated: number;
   }
-/* tslint:enable */
 export class FinancialData {
   public generateData(count: number): any[] {
     const currData = [];
@@ -900,13 +897,10 @@ export class FinancialData {
       const region = REGIONS[this.generateRandomNumber(0, 5)];
       dataObj.Region = region.Region;
       dataObj.Country = this.randomizeCountry(region);
-      // for (let y = 0; y < 80; y++) {
-      //   dataObj["Text" + y] = "Text";
-      // }
 
       for (const mockData of MOCKFINANCEDATA) {
         for (const prop in mockData) {
-          if (mockData.hasOwnProperty(prop)) {
+          if (Object.prototype.hasOwnProperty.call(mockData, prop)) {
             dataObj[prop] = mockData[prop];
           }
         }
@@ -930,12 +924,10 @@ export class FinancialData {
 
   public updateRandomPrices(data: any[]): any {
     const currData = data.slice(0, data.length + 1);
-    let y = 0;
     for (let i = Math.round(Math.random() * 10); i < data.length; i += Math.round(Math.random() * 10)) {
       const dataObj = Object.assign({}, data[i]);
       this.randomizeObjectData(dataObj);
       currData[i] = dataObj;
-      y++;
     }
      // return {data: currData, recordsUpdated: y };
     return currData;