fix: Remove --legacy-peer-deps flag to allow automatic peer dependency installation

Co-authored-by: Lipata <[email protected]>

Author: Copilot

packages/cli/templates/react/igr-es6/grid/basic/index.ts

@@ -16,7 +16,7 @@ class GridTemplate extends IgniteUIForReactTemplate {
 		this.controlGroup = "Data Grids";
 		// TODO: read version from igniteui-react-core in package.json
 		this.packages = ["igniteui-react-grids@~16.15.0", "igniteui-react-inputs@~16.15.0",
-			"igniteui-react-layouts@~16.15.0", "igniteui-react-core@~16.15.0"];
+			"igniteui-react-layouts@~16.15.0"];
 
 		this.hasExtraConfiguration = false;
 	}

packages/cli/templates/react/igr-ts/grid/basic/index.ts

@@ -15,7 +15,7 @@ class GridTemplate extends IgniteUIForReactTemplate {
 		this.components = ["Grid"];
 		this.controlGroup = "Data Grids";
 		this.packages = ["igniteui-react-grids@~19.0.2", "igniteui-react-inputs@~19.0.0",
-			"igniteui-react-layouts@~19.0.0", "igniteui-react@~19.0.3", "igniteui-react-core@~19.0.0"];
+			"igniteui-react-layouts@~19.0.0", "igniteui-react@~19.0.3"];
 
 		this.hasExtraConfiguration = false;
 	}

packages/core/packages/PackageManager.ts

@@ -95,8 +95,7 @@ export class PackageManager {
 				case "npm":
 				/* passes through */
 				default:
-					// TODO: remove --legacy-peer-deps flag igniteui-cli#1338 once new DV package is available
-					command = `${managerCommand} install --quiet --legacy-peer-deps`;
+					command = `${managerCommand} install --quiet`;
 					break;
 			}
 			await this.flushQueue(false);
@@ -166,8 +165,7 @@ export class PackageManager {
 	}
 
 	public static async queuePackage(packageName: string, verbose = false) {
-		// TODO: remove --legacy-peer-deps flag igniteui-cli#1338 once new DV package is available
-		const command = this.getInstallCommand(this.getManager(), packageName).replace("--save", "--no-save").concat(" --legacy-peer-deps");
+		const command = this.getInstallCommand(this.getManager(), packageName).replace("--save", "--no-save");
 		const [packName, version] = packageName.split(/@(?=[^\/]+$)/);
 		const packageJSON = this.getPackageJSON();
 		if (!packageJSON.dependencies) {

spec/templates/react-spec.ts

@@ -27,25 +27,4 @@ describe("React templates", () => {
 			}
 		}
 	});
-
-	it("Grid templates should include igniteui-react-core dependency", async () => {
-		const reactFramework: Framework = require(templatesLocation);
-		
-		// Check all project libraries
-		for (const projLibrary of reactFramework.projectLibraries) {
-			// Find grid templates
-			const gridTemplates = projLibrary.templates.filter(template => 
-				template.id === "grid" && template.packages && 
-				template.packages.some(pkg => pkg.includes("igniteui-react-grids"))
-			);
-			
-			// Verify each grid template includes igniteui-react-core
-			for (const gridTemplate of gridTemplates) {
-				const hasReactCore = gridTemplate.packages.some(pkg => pkg.includes("igniteui-react-core"));
-				expect(hasReactCore).toBeTruthy(
-					`Grid template ${gridTemplate.id} in project type ${gridTemplate.projectType} should include igniteui-react-core dependency`
-				);
-			}
-		}
-	});
 });

spec/unit/packageManager-spec.ts

@@ -296,8 +296,7 @@ describe("Unit - Package Manager", () => {
 		expect(Util.log).toHaveBeenCalledWith(`Installing npm packages`);
 		expect(Util.log).toHaveBeenCalledWith(`Error installing npm packages.`);
 		expect(Util.log).toHaveBeenCalledWith(`Example`);
-		// TODO: remove --legacy-peer-deps flag igniteui-cli#1338 once new DV package is available
-		expect(Util.execSync).toHaveBeenCalledWith(`npm install --quiet --legacy-peer-deps`,
+		expect(Util.execSync).toHaveBeenCalledWith(`npm install --quiet`,
 			{ stdio: ["inherit"], killSignal: "SIGINT" });
 		mockProjectConfig.packagesInstalled = true;
 		expect(ProjectConfig.setConfig).toHaveBeenCalledWith(mockProjectConfig);
@@ -313,8 +312,7 @@ describe("Unit - Package Manager", () => {
 		expect(Util.log).toHaveBeenCalledTimes(2);
 		expect(Util.log).toHaveBeenCalledWith(`Installing npm packages`);
 		expect(Util.log).toHaveBeenCalledWith(`Packages installed successfully`);
-		// TODO: remove --legacy-peer-deps flag igniteui-cli#1338 once new DV package is available
-		expect(Util.execSync).toHaveBeenCalledWith(`npm install --quiet --legacy-peer-deps`,
+		expect(Util.execSync).toHaveBeenCalledWith(`npm install --quiet`,
 			{ stdio: ["inherit"], killSignal: "SIGINT" });
 		mockProjectConfig.packagesInstalled = true;
 		expect(ProjectConfig.setConfig).toHaveBeenCalledWith(mockProjectConfig);
@@ -333,8 +331,7 @@ describe("Unit - Package Manager", () => {
 		await PackageManager.installPackages(true);
 		expect(Util.log).toHaveBeenCalledTimes(1);
 		expect(Util.log).toHaveBeenCalledWith(`Installing npm packages`);
-		// TODO: remove --legacy-peer-deps flag igniteui-cli#1338 once new DV package is available
-		expect(Util.execSync).toHaveBeenCalledWith(`npm install --quiet --legacy-peer-deps`,
+		expect(Util.execSync).toHaveBeenCalledWith(`npm install --quiet`,
 			{ stdio: ["inherit"], killSignal: "SIGINT" });
 		expect(process.exit).toHaveBeenCalled();
 		expect(ProjectConfig.setConfig).toHaveBeenCalledTimes(0);
@@ -420,7 +417,7 @@ describe("Unit - Package Manager", () => {
 		expect(Util.log).toHaveBeenCalledTimes(0);
 		expect(child_process.exec).toHaveBeenCalledTimes(1);
 		expect(child_process.exec).toHaveBeenCalledWith(
-			`npm install test-pack --quiet --no-save --legacy-peer-deps`, {}, jasmine.any(Function));
+			`npm install test-pack --quiet --no-save`, {}, jasmine.any(Function));
 	});
 
 	it("queuePackage should ignore existing package installs", async () => {

yarn.lock

@@ -909,6 +909,11 @@
   resolved "https://registry.npmjs.org/@nx/nx-linux-x64-gnu/-/nx-linux-x64-gnu-20.3.2.tgz"
   integrity sha512-HhgHqOUT05H45zuQL+XPywQbRNFttd7Rkkr7dZnpCRdp4W8GDjfyKCoCS5qVyowAyNh9Vc7VEq9qmiLMlvf6Zg==
 
+"@nx/[email protected]":
+  version "20.3.2"
+  resolved "https://registry.npmjs.org/@nx/nx-linux-x64-musl/-/nx-linux-x64-musl-20.3.2.tgz"
+  integrity sha512-NrZ8L9of2GmYEM8GMJX6QRrLJlAwM+ds2rhdY1bxwpiyCNcD3IO/gzJlBs+kG4ly05F1u/X4k/FI5dXPpjUSgw==
+
 "@octokit/auth-token@^3.0.0":
   version "3.0.4"
   resolved "https://registry.npmjs.org/@octokit/auth-token/-/auth-token-3.0.4.tgz"