Skip to content

Conversation

@Hristo313
Copy link
Contributor

@Hristo313 Hristo313 commented Feb 11, 2025

update packages to fix warnings for angular, react and wc when building the application.
update eslint version to 9.20.0 and update angular, react and wc configurations to use ESM imports
update glob version to 11.0.0

@Hristo313 Hristo313 changed the title update eslint and fix warnings fix: update eslint and fix warnings Feb 11, 2025
@Hristo313 Hristo313 marked this pull request as ready for review February 11, 2025 11:39
@coveralls
Copy link

coveralls commented Feb 13, 2025

Coverage Status

coverage: 70.044% (+0.003%) from 70.041%
when pulling e4080b9 on hhristov/fix-warnings
into 1849e0c on master.

@Hristo313 Hristo313 changed the title fix: update eslint and fix warnings fix: update eslint and fix warnings and alerts Feb 17, 2025
@Hristo313 Hristo313 changed the title fix: update eslint and fix warnings and alerts fix: update eslint and fix warnings Feb 17, 2025
@Lipata
Copy link
Member

Lipata commented Feb 24, 2025

I've tested all the components and all scenarios for angular, react & wc.

I found one problem that is not related to lint and is already reproduced on master, that is why I logged it as a separate issue: #1380.

For React there is the following problem when creating a sample with any DV component (chart, gauge, etc.) and running build command:

[vite]: Rollup failed to resolve import "igniteui-react-core" from "C:/Work/git/igniteui-cli/output/test_react_for_reak/node_modules/igniteui-react-gauges/esm5/lib/igr-bullet-graph.js".

There is a related problem, when running test or start

@Lipata
Copy link
Member

Lipata commented Feb 24, 2025

The problem with react project was, because I didn't have latest [email protected]. Once the latter is installed all the commands on a generated project from the cli are working.

@Lipata Lipata merged commit aa84345 into master Feb 24, 2025
3 checks passed
@Lipata Lipata deleted the hhristov/fix-warnings branch February 24, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants