Skip to content

Commit 21cd28d

Browse files
authored
fix(rating): overwritten properties (#1654)
1 parent 5fa8c55 commit 21cd28d

File tree

5 files changed

+19
-12
lines changed

5 files changed

+19
-12
lines changed

package-lock.json

Lines changed: 4 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@
7979
"globby": "^14.1.0",
8080
"husky": "^9.1.7",
8181
"ig-typedoc-theme": "^6.0.0",
82-
"igniteui-theming": "^17.1.0",
82+
"igniteui-theming": "^17.2.0",
8383
"keep-a-changelog": "^2.6.2",
8484
"lint-staged": "^15.5.1",
8585
"lit-analyzer": "^2.0.3",

src/components/rating/themes/rating.base.scss

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@
1717
}
1818

1919
[part~='symbols'] {
20-
--symbol-size: #{sizable(rem(18px), rem(24px), rem(36px))};
21-
2220
position: relative;
2321
display: flex;
2422
justify-content: center;

src/components/rating/themes/shared/rating.common.scss

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ $theme: $material;
55

66
:host {
77
--component-size: var(--ig-size, #{var-get($theme, 'default-size')});
8+
--symbol-size: #{var-get($theme, 'symbol-size')};
89
--symbol-full-color: #{var-get($theme, 'symbol-full-color')};
910
--symbol-empty-color: #{var-get($theme, 'symbol-empty-color')};
1011
}
@@ -28,16 +29,27 @@ $theme: $material;
2829

2930
:host([disabled]),
3031
:host(:disabled) {
31-
--symbol-full-color: #{var-get($theme, 'disabled-full-symbol-color')};
32-
--symbol-empty-color: #{var-get($theme, 'disabled-empty-symbol-color')};
3332
--disabled-symbol-full-filter: #{var-get($theme, 'symbol-full-filter')};
3433
--disabled-symbol-empty-filter: #{var-get($theme, 'symbol-empty-filter')};
3534

35+
igc-rating-symbol::part(full) {
36+
color: var-get($theme, 'disabled-full-symbol-color');
37+
}
38+
39+
igc-rating-symbol::part(empty) {
40+
color: var-get($theme, 'disabled-empty-symbol-color');
41+
}
42+
3643
[part~='label'] {
3744
color: var-get($theme, 'disabled-label-color');
3845
}
3946

4047
[part~='value-label'] {
4148
color: var-get($theme, 'disabled-label-color');
4249
}
50+
51+
[part~='symbols'] {
52+
--symbol-full-color: #{var-get($theme, 'disabled-full-symbol-color')};
53+
--symbol-empty-color: #{var-get($theme, 'disabled-empty-symbol-color')};
54+
}
4355
}

src/components/rating/themes/shared/rating.indigo.scss

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,5 @@ $theme: $indigo;
2323
}
2424

2525
[part~='symbols'] {
26-
--symbol-size: #{sizable(rem(18px), rem(24px), rem(30px))};
27-
2826
padding-inline-end: 0;
2927
}

0 commit comments

Comments
 (0)