style(lint): Updated Biome rules to a more strict subset (#1575)

* style(lint): Updated Biome rules to a more strict subset

Force to error out on unused variables, import statements,
function arguments and private class members

* build: Typedoc build script return code

Author: rkaraivanov

biome.json

@@ -29,6 +29,10 @@
         "noStaticOnlyClass": "off"
       },
       "correctness": {
+        "noUnusedVariables": "error",
+        "noUnusedFunctionParameters": "error",
+        "noUnusedImports": "error",
+        "noUnusedPrivateClassMembers": "error",
         "useImportExtensions": {
           "options": {
             "suggestedExtensions": {

scripts/build-stories.mjs

@@ -120,7 +120,7 @@ class StoriesBuilder {
     const isArray = (type) => type.includes('[]');
     const isGeneric = (type) => type.match(/<.*>/);
 
-    const t = type.split('|').map((t) => {
+    type.split('|').map((t) => {
       const part = t.trim().replace(/'/g, '"');
       if (
         part &&
@@ -348,7 +348,7 @@ class StoriesBuilder {
 
     try {
       data = await readFile(file, 'utf8');
-    } catch (e) {
+    } catch {
       return;
     }
 

scripts/build-typedoc.js

@@ -2,6 +2,7 @@ import path from 'node:path';
 import { create } from 'browser-sync';
 import watch from 'node-watch';
 import { Application } from 'typedoc';
+import report from './report.mjs';
 
 const browserSync = create();
 const ROOT = path.join.bind(null, path.resolve('./'));
@@ -137,4 +138,9 @@ async function main() {
   }
 }
 
-main().catch(console.error);
+try {
+  await main();
+} catch (e) {
+  report.error(e);
+  process.exit(1);
+}

src/components/icon/icon.spec.ts

@@ -262,8 +262,6 @@ describe('Icon broadcast service', () => {
       const broadcast1 = new IconsStateBroadcast(collections, references);
       const broadcast2 = new IconsStateBroadcast(collections, references);
       // 1 global one, initialized when you get the icon registry first time.
-      const iconReg = getIconRegistry();
-      // total - 3 services now.
 
       // a peer is requesting a state sync
       channel.postMessage({ actionType: ActionType.SyncState });

stories/dialog.stories.ts

@@ -91,10 +91,6 @@ const closeDialog = (id: string) =>
   (document.getElementById(id) as IgcDialogComponent).hide();
 
 const authMethods = ['Basic', 'Bearer', 'Digest', 'OAuth'];
-const authSelected = (ev: CustomEvent) => {
-  (ev.target as HTMLElement).querySelector('igc-input')!.value =
-    ev.detail.value;
-};
 
 const Template = ({
   keepOpenOnEscape,

stories/textarea.stories.ts

@@ -326,7 +326,7 @@ function getInput(event: CustomEvent<string>) {
 }
 
 export const Validation: Story = {
-  play: async (args) => {
+  play: async () => {
     setMaxChars();
   },
   render: () => html`

stories/tree.stories.ts

@@ -93,7 +93,6 @@ const addChildren = (
 const log = () => {
   const item = document.getElementById('parent2');
   item?.parentElement?.removeChild(item);
-  const tree = document.getElementById('tree') as IgcTreeComponent;
 };
 
 const log1 = () => {